- Apr 27, 2018
-
-
Michaël Zasso authored
Migrate some methods from node.cc to JS in order to properly throw errors with codes. PR-URL: https://github.com/nodejs/node/pull/19973 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michaël Zasso authored
Create a file to centralize argument validators that are used in multiple internal modules. Move validateInt32 and validateUint32 to this file. PR-URL: https://github.com/nodejs/node/pull/19973 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/20094 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Eugene Ostroukhov authored
PR-URL: https://github.com/nodejs/node/pull/20254 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
- Apr 26, 2018
-
-
Gabriel Schulhof authored
Remove a superfluos persistent from test_constructor_name.c. PR-URL: https://github.com/nodejs/node/pull/20299 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Gabriel Schulhof authored
Fixes: https://github.com/nodejs/node/issues/20082 PR-URL: https://github.com/nodejs/node/pull/20301 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
One non-static method remains PR-URL: https://github.com/nodejs/node/pull/20292 Reviewed-By:
-
Santiago Gimeno authored
Kill the child process with `SIGKILL` to make sure the child process does not remain alive. Fixes: https://github.com/nodejs/node/issues/20139 PR-URL: https://github.com/nodejs/node/pull/20213 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Daniel Bevenius authored
This commit updates pbkdf2 to use checkIsArrayBufferView from internal/crypto/util. PR-URL: https://github.com/nodejs/node/pull/20251 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Daniel Bevenius authored
This commit adds a checkIsArrayBufferView function to avoid some code duplication in sig.js PR-URL: https://github.com/nodejs/node/pull/20251 Reviewed-By:
-
Daniel Bevenius authored
This commit adds a getIntOption function to reduce the code duplicated for getting the padding, and saltLength options. PR-URL: https://github.com/nodejs/node/pull/20247 Reviewed-By:
-
Daniel Bevenius authored
This commit aims to simplify the getFormat function in diffiehellman.js. PR-URL: https://github.com/nodejs/node/pull/20246 Reviewed-By:
-
Ujjwal Sharma authored
Improve documentation regarding the callback parameters for the frameError event for instances of Http2Session, making it inline with the currently accepted structure, like the rest of the documentation. Refs: https://github.com/nodejs/help/issues/877#issuecomment-381253464 PR-URL: https://github.com/nodejs/node/pull/20236 Reviewed-By:
-
Ajido authored
PR-URL: https://github.com/nodejs/node/pull/20291 Refs: https://github.com/nodejs/node/pull/17156 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/20225 Refs: https://github.com/nodejs/node/pull/20039 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/20225 Refs: https://github.com/nodejs/node/pull/20039 Reviewed-By:
-
- Apr 25, 2018
-
-
Joyee Cheung authored
Also modifies the error messages so they include more information and are more consistent. - The message of ERR_SCRIPT_EXECUTION_INTERRUPTED now mentions SIGINT and the trailing period is dropped for consistency. - Added ERR_SCRIPT_EXECUTION_TIMEOUT and include the timeout in the message. PR-URL: https://github.com/nodejs/node/pull/20147 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
William Cohen authored
The process("node").mark("gc__stop") is actually process("node").mark("gc__done"). Use the proper name so that a developer can use SystemTap to determine the duration of garbage collection. PR-URL: https://github.com/nodejs/node/pull/20152 Reviewed-By:Matheus Marchini <matheus@sthima.com> Reviewed-By:
-
Gabriel Schulhof authored
PR-URL: https://github.com/nodejs/node/pull/20243 Reviewed-By:
-
Gabriel Schulhof authored
PR-URL: https://github.com/nodejs/node/pull/20244 Reviewed-By:
-
Zachary Vacura authored
PR-URL: https://github.com/nodejs/node/pull/20277 Refs: https://github.com/nodejs/node/pull/19125 Reviewed-By:
-
Hackzzila authored
PR-URL: https://github.com/nodejs/node/pull/20271 Reviewed-By:
-
Ulan Degenbaev authored
Foreground tasks that repost themselves can force the draining loop to run indefinitely long without giving other tasks chance to run. This limits the foreground task draining loop to run only the tasks that were in the tasks queue at the beginning of the loop. PR-URL: https://github.com/nodejs/node/pull/19987 Fixes: https://github.com/nodejs/node/issues/19937 Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Daniel Bevenius authored
This commit adds a checkMethods function so that it can be reused to avoid duplicating the same code for instance methods, and static methods of the Certificate object. PR-URL: https://github.com/nodejs/node/pull/20224 Reviewed-By:
-
Daniel Bevenius authored
This commit removes the usage of the deprectated crypto.DEFAULT_ENCODING. PR-URL: https://github.com/nodejs/node/pull/20221 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20265 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/20257 Refs: https://github.com/nodejs/node/pull/19403 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
James M Snell authored
* Assert * Calling `assert.fail()` with more than one argument is deprecated. #70dcacd7 * Calling `assert.ok()` with no arguments will now throw. #3cd7977a * Calling `assert.ifError()` will now throw with any argument other than `undefined` or `null`. Previously the method would throw with any truthy value. #e65a6e81 * The `assert.rejects()` and `assert.doesNotReject()` methods have been added for working with async functions. #599337f4 * Async_hooks * Older experimental async_hooks APIs have been removed. #1cc6b993 * Buffer * Uses of `new Buffer()` and `Buffer()` outside of the `node_modules` directory will now emit a runtime deprecation warning. #9d4ab901 * `Buffer.isEncoding()` now returns `undefined` for falsy values, including an empty string. #452eed95 * `Buffer.fill()` will throw if an attempt is made to fill with an empty `Buffer`. #1e802539 * Child Process * Undefined properties of env are ignored. #38ee25e2, #85739b6c * Console * The `console.table()` method has been added. #97ace044 * Crypto * The `crypto.createCipher()` and `crypto.createDecipher()` methods have been deprecated. Please use `crypto.createCipheriv()` and `crypto.createDecipheriv()` instead. #81f88e30 * The `decipher.finaltol()` method has been deprecated. #19f3927d * The `crypto.DEFAULT_ENCODING` property has been deprecated. #6035beea * The `ECDH.convertKey()` method has been added. #f2e02883 * The `crypto.fips` property has been deprecated. #6e7992e8 * Dependencies * V8 has been updated to 6.6. #9daebb48 * OpenSSL has been updated to 1.1.0h. #66cb29e6 * EventEmitter * The `EventEmitter.prototype.off()` method has been added as an alias for `EventEmitter.prototype.removeListener()`. #3bb6f07d * File System * The `fs.promises` API provides experimental promisified versions of the `fs` functions. #329fc78e * Invalid path errors are now thrown synchronously. #d8f73385 * The `fs.readFile()` method now partitions reads to avoid thread pool exhaustion. #67a4ce1c * HTTP * Processing of HTTP Status codes `100`, `102-199` has been improved. #baf84950 * Multi-byte characters in URL paths are now forbidden. #b961d9fd * N-API * The n-api is no longer experimental. #cd7d7b15 * Net * The `'close'` event will be emitted after `'end'`. #9b7a6914 * Perf_hooks * The `PerformanceObserver` class is now an `AsyncResource` and can be monitored using `async_hooks`. #009e4182 * Trace events are now emitted for performance events. #9e509b62 * The `performance` API has been simplified. #2ec69955 * Performance milestone marks will be emitted as trace events. #96cb4fb7 * Process * Using non-string values for `process.env` is deprecated. #5826fe4e * The `process.assert()` method is deprecated. #703e37cf * REPL * REPL now experimentally supports top-level await when using the `--experimental-repl-await` flag. #eeab7bc0 * The previously deprecated "magic mode" has been removed. #4893f70d * The previously deprecated `NODE_REPL_HISTORY_FILE` environment variable has been removed. #60c9ad79 * Proxy objects are shown as Proxy objects when inspected. #90a43906 * Streams * The `'readable'` event is now always deferred with nextTick. #1e0f3315 * A new `pipeline()` method has been provided for building end-to-data stream pipelines. #a5cf3fea * Experimental support for async for-await has been added to `stream.Readable`. #61b4d60c * Timers * The `enroll()` and `unenroll()` methods have been deprecated. #68783ae0 * TLS * The `tls.convertNONProtocols()` method has been deprecated. #9204a0db * Support for NPN (next protocol negotiation) has been dropped. #5bfbe5ce * The `ecdhCurve` default is now `'auto'`. #af78840b * Trace Events * A new `trace_events` top-level module allows trace event categories to be enabled/disabld at runtime. #da5d818a * URL * The WHATWG URL API is now a global. #31241466 * Util * `util.types.is[…]` type checks have been added. #b20af808 * Support for bigint formatting has been added to `util.inspect()`. #39dc9474
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/20194 PR-URL: https://github.com/nodejs/node/pull/20195 Reviewed-By:
-
- Apr 24, 2018
-
-
Vse Mozhet Byt authored
Modernize: * Replace `var` with `const` / `let`. * Replace common functions with arrow functions. * Use destructuring. * Use `String.prototype.padStart()`, `String.prototype.endsWith()`. Optimize: * Reduce function calls. * Reduce intermediate variables. * Cache retrieved object properties. * Move RegExp declaration out of a cycle. * Simplify RegExps. * Replace RegExp with string when string suffices. * Remove conditions that cannot be false. * Replace for..in with `Object.keys().forEach()`. Also, eliminate needlessly complicated function chains: * `ondone` callback only checks errors; * if there is an error, it is called once and throws, then script exits; * if there are no errors, it is noop; * so there is no need to wrap it into `once()` function * and there is no need to call it without errors; * we can eliminate it and replace with `throw` where an error occurs; * we can also replace `onprogress` callback with `console.log` in place; * at last, we can eliminate `waiting` counter and `once()` utility. The new script produces results identical to the old ones. PR-URL: https://github.com/nodejs/node/pull/20188 Reviewed-By:
-
Kyle Farnung authored
The code currently assumes that `console` is already writable, but that's only if it was previously defined as writable. If it hasn't already been defined then the default value is false. Refs: https://github.com/nodejs/node/pull/17708 PR-URL: https://github.com/nodejs/node/pull/20185 Reviewed-By:
-
Daniel Bevenius authored
Currently the following compiler warnings are issued by clang: ../src/node_crypto.cc:2801:56: warning: '&&' within '||' [-Wlogical-op-parentheses] return tag_len == 4 || tag_len == 8 || tag_len >= 12 && tag_len <= 16; ~~ ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ ../src/node_crypto.cc:2801:56: note: place parentheses around the '&&' expression to silence this warning return tag_len == 4 || tag_len == 8 || tag_len >= 12 && tag_len <= 16; ^ ../src/node_crypto.cc:2925:51: warning: '&&' within '||' [-Wlogical-op-parentheses] if (cipher->auth_tag_len_ != kNoAuthTagLength && ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ ../src/node_crypto.cc:2925:51: note: place parentheses around the '&&' expression to silence this warning if (cipher->auth_tag_len_ != kNoAuthTagLength && ^ This commit adds parenthesis around these expressions to silence the warnings. PR-URL: https://github.com/nodejs/node/pull/20216 Reviewed-By: -
Daniel Bevenius authored
This commit renames the verification result variable, that is currently named i, to verify_result. PR-URL: https://github.com/nodejs/node/pull/20218 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Daniel Bevenius authored
This commit updates node_crypto.cc VerifySpkac function to use false instead of 0 for its return bool value i. PR-URL: https://github.com/nodejs/node/pull/20218 Reviewed-By:
-
Ruben Bridgewater authored
This reverts commit 1d1ab76e. PR-URL: https://github.com/nodejs/node/pull/20228 Fixes: https://github.com/nodejs/node/issues/20227 Reviewed-By:
-
Gabriel Schulhof authored
Much like regular modules, N-API modules can also benefit from having a special symbol which they can expose. Fixes: https://github.com/nodejs/node/issues/19845 PR-URL: https://github.com/nodejs/node/pull/20161 Reviewed-By:
-
Shigeki Ohtsu authored
The current openssl checks assembler version only x86_64 or ia32 target arch for use of AES-NI, AVX and AVX2. This requires --openssl-no-asm option during configure when an older assembler version is found only on x86_64 or ia32. PR-URL: https://github.com/nodejs/node/pull/20226 Fixes: https://github.com/nodejs/node/issues/19944 Refs: https://github.com/nodejs/node/pull/20217 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/20226 Fixes: https://github.com/nodejs/node/issues/19944 Refs: https://github.com/nodejs/node/pull/20217 Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/20226 Fixes: https://github.com/nodejs/node/issues/19944 Refs: https://github.com/nodejs/node/pull/20217 Reviewed-By:
-
- Apr 23, 2018
-
-
Ujjwal Sharma authored
Add parameters for the callback for the Http2Session:error event inline with the pattern in the rest of the documentation. Refs: https://github.com/nodejs/help/issues/877#issuecomment-381253464 PR-URL: https://github.com/nodejs/node/pull/20206 Reviewed-By:
-
