src: fix node_crypto.cc compiler warnings
Currently the following compiler warnings are issued by clang:
../src/node_crypto.cc:2801:56:
warning: '&&' within '||' [-Wlogical-op-parentheses]
return tag_len == 4 || tag_len == 8 || tag_len >= 12 && tag_len <= 16;
~~ ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
../src/node_crypto.cc:2801:56:
note: place parentheses around the '&&' expression to silence this
warning
return tag_len == 4 || tag_len == 8 || tag_len >= 12 && tag_len <= 16;
^
../src/node_crypto.cc:2925:51:
warning: '&&' within '||' [-Wlogical-op-parentheses]
if (cipher->auth_tag_len_ != kNoAuthTagLength &&
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
../src/node_crypto.cc:2925:51:
note: place parentheses around the '&&' expression to silence this
warning
if (cipher->auth_tag_len_ != kNoAuthTagLength &&
^
This commit adds parenthesis around these expressions to silence the
warnings.
PR-URL: https://github.com/nodejs/node/pull/20216
Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By:
Anna Henningsen <anna@addaleax.net>
Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
Reviewed-By:
James M Snell <jasnell@gmail.com>
parent
c07c73ce
Please register or sign in to comment