- Jul 21, 2020
-
-
Beth Griggs authored
PR-URL: https://github.com/nodejs/node/pull/34170
-
- Jul 15, 2020
-
-
Richard Lau authored
Notable changes: - deps: - upgrade npm to 6.14.6 (claudiahdz) https://github.com/nodejs/node/pull/34246 - upgrade openssl sources to 1.1.1g (Hassaan Pasha) https://github.com/nodejs/node/pull/32982 - n-api: - add `napi_detach_arraybuffer` (legendecas) https://github.com/nodejs/node/pull/29768 PR-URL: https://github.com/nodejs/node/pull/34170 -
Sparsh Garg authored
Added the missing single quotes in minVersion and maxVersion of api/tls doc before TLSv1.2. PR-URL: https://github.com/nodejs/node/pull/33641 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Jeremiah Senkpiel authored
If the bug this test is intented to catch is reintroduced, or if 5aac4c42 is effectively reverted, many (50+) tests time out, rendering this test redundant and unnecessary. in particular, the following timer tests catch an effective revert of 5aac4c42: not ok 21 parallel/test-timers-api-refs not ok 22 parallel/test-timers-args not ok 23 parallel/test-timers-destroyed not ok 25 parallel/test-timers-nested not ok 26 parallel/test-timers-interval-throw not ok 28 parallel/test-timers-non-integer-delay not ok 32 parallel/test-timers-ordering not ok 33 parallel/test-timers-refresh not ok 34 parallel/test-timers-refresh-in-callback not ok 35 parallel/test-timers-reset-process-domain-on-throw not ok 40 parallel/test-timers-timeout-to-interval not ok 41 parallel/test-timers-uncaught-exception not ok 42 parallel/test-timers-timeout-with-non-integer not ok 43 parallel/test-timers-unenroll-unref-interval not ok 44 parallel/test-timers-unref not ok 45 parallel/test-timers-unref-active not ok 46 parallel/test-timers-unrefd-interval-still-fires not ok 47 parallel/test-timers-unrefed-in-callback not ok 48 parallel/test-timers-user-call not ok 49 parallel/test-timers-zero-timeout Refs: https://github.com/nodejs/node/issues/21781 PR-URL: https://github.com/nodejs/node/pull/32870 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Jul 14, 2020
-
-
claudiahdz authored
PR-URL: https://github.com/nodejs/node/pull/34246 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/33239 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
- Jul 02, 2020
-
-
Paolo Insogna authored
PR-URL: https://github.com/nodejs/node/pull/33307 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
legendecas authored
As its actual release stage. PR-URL: https://github.com/nodejs/node/pull/30703 Backport-PR-URL: https://github.com/nodejs/node/pull/33061 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Denys Otrishko authored
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer Closes: https://github.com/nodejs/node/issues/29955 PR-URL: https://github.com/nodejs/node/pull/30613 Backport-PR-URL: https://github.com/nodejs/node/pull/33061 Fixes: https://github.com/nodejs/node/issues/29955 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
legendecas authored
As ArrayBuffer#detach is an ecma spec operation ([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)), it might be good to have it in N-API. Fixes: https://github.com/nodejs/node/issues/29674 PR-URL: https://github.com/nodejs/node/pull/29768 Backport-PR-URL: https://github.com/nodejs/node/pull/33061 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Luigi Pinca authored
This reverts commit 24a4f767. PR-URL: https://github.com/nodejs/node/pull/32489 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
cjihrig authored
This commit documents the bigint option to fs.watchFile(), which has been supported since v10.5.0. PR-URL: https://github.com/nodejs/node/pull/32128 Reviewed-By:
-
- Jul 01, 2020
-
-
Jason Macgowan authored
Behavior described in https://github.com/nodejs/node/issues/11771 is still true even though the issue is closed. This PR is to allow DNS and URI names, even when there is not a subject. Refs: https://github.com/nodejs/node/issues/11771 PR-URL: https://github.com/nodejs/node/pull/22906 Reviewed-By:
-
Hassaan Pasha authored
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/32982 Reviewed-By:
-
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1g.tar.gz $ mv openssl-1.1.1g openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/32982 Reviewed-By: -
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz $ mv openssl-1.1.0h openssl $ git add --all openssl $ git commit openssl Backport-PR-URL: https://github.com/nodejs/node/pull/32982 PR-URL: https://github.com/nodejs/node/pull/32583 Reviewed-By:Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64, which is the musl architecture with the biggest MINSIGSTKSZ so let's use that as a lower bound and let's quadruple it just in case. Backport-PR-URL: https://github.com/nodejs/node/pull/33720 PR-URL: https://github.com/nodejs/node/pull/27855 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Michaël Zasso authored
Original commit message: [parser] Validate destructuring assignment pattern in correct classifier Previously we'd first accumulate errors to the parent and validate the destructuring pattern in the parent. In the case of ParseArguments this will invalidly propagate binding pattern errors from one argument to the next. The reason why ParseArguments keeps track of binding pattern errors is because it could also be used to parse async arrow function parameters. If we see async(a,b) we don't yet know whether this is the head of an async arrow function, or a call to async with arguments a and b. Bug: v8:8241 Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f Reviewed-on: https://chromium-review.googlesource.com/c/1296229 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56887} Refs: https://github.com/v8/v8/commit/cd21f71f9cb592b2f9520b97c86eb5456e0e8e6d Fixes: https://github.com/nodejs/node/issues/23142 PR-URL: https://github.com/nodejs/node/pull/33862 Reviewed-By:
-
Sam Roberts authored
Fixes: https://github.com/nodejs/node/issues/33040 error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing] ParameterList result{{}, {}, context->VARARGS(), {}}; Occurs twice: ../../deps/v8/src/torque/ast-generator.cc:123:32: ../../deps/v8/src/torque/ast-generator.cc:144:32: PR-URL: https://github.com/nodejs/node/pull/33094 Reviewed-By:
-
Richard Lau authored
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/28803 PR-URL: https://github.com/nodejs/node/pull/32849 Reviewed-By:
-
- Jun 03, 2020
-
-
Richard Lau authored
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Kamil Rytarowski authored
Detected on NetBSD/amd64. Fixes: https://github.com/nodejs/node/issues/29536 PR-URL: https://github.com/nodejs/node/pull/29541 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Beth Griggs authored
PR-URL: https://github.com/nodejs-private/node-private/pull/211
-
- Jun 02, 2020
-
-
Beth Griggs authored
This is a security release. Vulnerabilities fixed: - CVE-2020-8174: napi_get_value_string_*() allows various kinds of memory corruption (High). - CVE-2020-10531: ICU-20958 Prevent SEGV_MAPERR in append (High). - CVE-2020-11080: HTTP/2 Large Settings Frame DoS (Low). PR-URL: https://github.com/nodejs-private/node-private/pull/211 -
Shigeki Ohtsu authored
Backslashes and spaces are need to be escaped to define OPENSSLDIR to "C:\Program Files\Common Files\SSL". PR-URL: https://github.com/nodejs/node/pull/29456 Refs: https://github.com/nodejs/node/pull/29455 Reviewed-By:
-
Richard Lau authored
Add floating patch for ICU 64.2 from https://github.com/unicode-org/icu/commit/18b212f235c8b1dea3b8bbd0accd57340b32ba55. Original commit message: ICU-21032 Backport to 64.x: ICU-20958 Prevent SEGV_MAPERR in append See #971 (cherry picked from commit b7d08bc04a4296982fcef8b6b8a354a9e4e7afca) Refs: https://unicode-org.atlassian.net/browse/ICU-20958 Refs: https://github.com/unicode-org/icu/pull/1155 CVE-ID: CVE-2020-10531 PR-URL: https://github.com/nodejs/node/pull/33572 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com>
-
James M Snell authored
Adds the maxSettings option to limit the number of settings entries allowed per SETTINGS frame. Default 32 Signed-off-by:
-
James M Snell authored
Fixes: https://hackerone.com/reports/446662 CVE-ID: CVE-2020-11080 PR-URL: https://github.com/nodejs-private/node-private/pull/204 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/207 Reviewed-By:
-
Tobias Nießen authored
Fixes: https://hackerone.com/reports/784186 CVE-ID: CVE-2020-8174 PR-URL: https://github.com/nodejs-private/node-private/pull/203 Reviewed-By:
-
- Apr 12, 2020
-
-
Beth Griggs authored
PR-URL: https://github.com/nodejs/node/pull/32768
-
Beth Griggs authored
Notable changes: Due to release process failures, Node.js v10.20.0 shipped with source and header tarballs that did not properly match the final release commit that was used to build the binaries. We recommend that Node.js v10.20.0 not be used, particularly in any applications using native add-ons or where compiling Node.js from source is involved. Node.js v10.20.1 is a clean release with the correct sources and is strongly recommended in place of v10.20.0. PR-URL: https://github.com/nodejs/node/pull/32768
-
- Apr 08, 2020
-
-
Beth Griggs authored
PR-URL: https://github.com/nodejs/node/pull/31984
-
Beth Griggs authored
macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](https://github.com/nodejs/node/pull/19691) - build: macOS package notarization (Rod Vagg) [#31459](https://github.com/nodejs/node/pull/31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](https://github.com/nodejs/node/pull/32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](https://github.com/nodejs/node/pull/32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](https://github.com/nodejs/node/pull/31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](https://github.com/nodejs/node/pull/30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](https://github.com/nodejs/node/pull/28682) - define release 6 [#32058](https://github.com/nodejs/node/pull/32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](https://github.com/nodejs/node/pull/26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](https://github.com/nodejs/node/pull/27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](https://github.com/nodejs/node/pull/27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](https://github.com/nodejs/node/pull/26226) PR-URL: https://github.com/nodejs/node/pull/31984
-
- Apr 07, 2020
-
-
Richard Lau authored
Path to the versions tool tested by test-doctool-versions.js would be incorrect if the test temporary directory was redirected (e.g. via NODE_TEST_DIR) outside of `test/`. Signed-off-by:
-
Richard Lau authored
Refactor the logic for working out the previous versions of Node.js for the API documentation so that the parsing (including the potential https get) happens at most once per build (as opposed to the current once per generated API doc). Signed-off-by:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Joyee Cheung authored
At the moment the doc builder tries to access the internet for CHANGELOG information and only falls back to local sources after the connection fails or a 5 second timeout. This means that the doc building could take at least 7 minutes on a machine with hijacked connection to Github for useless network attempts. This patch adds a NODE_TEST_NO_INTERNET environment variable to directly bypass these attempts so that docs can be built in reasonable time on a machine like that. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/31849 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Richard Lau authored
Allow doctool to fallback to use local files if not building a release build. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/30214 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By:
-
Rich Trott authored
Doctool tests have been failing a lot in CI on Win2008 R2. It appears async functions and callback-based functions are being used in combination such that the callback-based function cannot guarantee that it will invoke its callback. Convert the callback-based functions to async functions so we have one paradigm and reliable results. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/29979 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Richard Lau authored
Parse `CHANGELOG.md` for versions of Node.js used by the documentation feature `View another version` so that we don't have to manually update the list when we cut a new version or transition a release to LTS. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/27661 Reviewed-By:
-
