Commit 3acc89f8 authored by Michaël Zasso's avatar Michaël Zasso Committed by Richard Lau
Browse files

deps: V8: backport cd21f71f9cb5

Original commit message:

    [parser] Validate destructuring assignment pattern in correct classifier

    Previously we'd first accumulate errors to the parent and validate the
    destructuring pattern in the parent. In the case of ParseArguments this
    will invalidly propagate binding pattern errors from one argument to the
    next. The reason why ParseArguments keeps track of binding pattern errors
    is because it could also be used to parse async arrow function parameters.
    If we see async(a,b) we don't yet know whether this is the head of an
    async arrow function, or a call to async with arguments a and b.

    Bug: v8:8241
    Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f
    Reviewed-on: https://chromium-review.googlesource.com/c/1296229


    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: default avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56887}

Refs: https://github.com/v8/v8/commit/cd21f71f9cb592b2f9520b97c86eb5456e0e8e6d
Fixes: https://github.com/nodejs/node/issues/23142

PR-URL: https://github.com/nodejs/node/pull/33862


Reviewed-By: default avatarRichard Lau <riclau@uk.ibm.com>
parent 89a306bc
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment