Commits · fc264dfd8d3e9c8d2aabf932369a80b5de69ca26 · github.com / v8-riscv / node

Jun 02, 2021

debugger: revise async iterator usage to comply with lint rules · fc264dfd

Rich Trott authored May 29, 2021

I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: https://github.com/nodejs/node/pull/38847


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

fc264dfd

deps: upgrade npm to 7.15.1 · 5d9fd768

npm-robot authored May 31, 2021

PR-URL: https://github.com/nodejs/node/pull/38880


Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>

5d9fd768

test: remove unnecessary `--pending-deprecation` flag · 26bf4f38

Antoine du Hamel authored May 23, 2021

PR-URL: https://github.com/nodejs/node/pull/38819


Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

26bf4f38

os: add os.devNull · 152d675c

Luigi Pinca authored May 06, 2021

Provides the platform-specific file path of the null device.

PR-URL: https://github.com/nodejs/node/pull/38569


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

152d675c

Jun 01, 2021

src: replace `auto`s in node_api.cc · 46acbb05

XadillaX authored May 30, 2021

PR-URL: https://github.com/nodejs/node/pull/38852


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

46acbb05

src: cache necessary isolate & context in api/* · f52dc175

XadillaX authored Apr 23, 2021

Refs: https://github.com/nodejs/node/pull/37473

PR-URL: https://github.com/nodejs/node/pull/38366


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

f52dc175

lib: fix typos · dccf64ee

bl-ue authored May 31, 2021

PR-URL: https://github.com/nodejs/node/pull/38846


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

dccf64ee

src: fix typos · 11e77e44

bl-ue authored May 29, 2021

PR-URL: https://github.com/nodejs/node/pull/38845


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

11e77e44

doc: fixed typo in n-api.md · fc269b37

julianjany authored May 27, 2021

PR-URL: https://github.com/nodejs/node/pull/38822


Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

fc269b37

debugger: removed unused function argument · 910009d5

Rich Trott authored May 29, 2021

PR-URL: https://github.com/nodejs/node/pull/38850


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

910009d5

tools: refloat 7 Node.js patches to cpplint.py · 79d487e3

Rich Trott authored Oct 09, 2020

Cherry-pick 12c8b4d1
Original commit message:
    This commit is a suggestion for adding a rule for NULL usages in the
    code base. This will currently report a number of errors which could be
    ignored using // NOLINT (readability/null_usage)

    PR-URL: https://github.com/nodejs/node/pull/17373


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: https://github.com/nodejs/node/commit/12c8b4d15471cb6211b39c3a2ca5b10fa4b9f12b

Cherry-pick fc81e801
Original commit message:

    Update cpplint.py to check for inline headers when the corresponding
    header is already included.

    PR-URL: https://github.com/nodejs/node/pull/21521


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: https://github.com/nodejs/node/commit/fc81e801913de3e3f3c0c8e26c105f983a74e539

Cherry-pick cbc3dd99
Original commit message:

    src, tools: add check for left leaning pointers

    This commit adds a rule to cpplint to check that pointers in the code
    base lean to the left and not right, and also fixes the violations
    reported.

    PR-URL: https://github.com/nodejs/node/pull/21010


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: https://github.com/nodejs/node/commit/cbc3dd997eb90d629d1b9912b7a5a40eb82343df

Cherry-pick 90299819
Original commit message:

    tools: fix cpplint.py header rules

    THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

    PR-URL: https://github.com/nodejs/node/pull/26306


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Refs: https://github.com/nodejs/node/commit/902998190a55d6915b881936f6dd5b6e9cca6ad8

Cherry-pick 0a25ace9
Original commit message:

    tools: move cpplint configuration to .cpplint

    PR-URL: https://github.com/nodejs/node/pull/27098


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Refs: https://github.com/nodejs/node/commit/0a25ace9c35b62ece4d32fd90b326d8063265109

Cherry-pick afa9a720
Original commit message:

    tools: refloat update link to google styleguide for cpplint

    This commit updates two old links to Google's C++ styleguide which
    currently result in a 404 when accessed.

    PR-URL: https://github.com/nodejs/node/pull/30876


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: https://github.com/nodejs/node/commit/afa9a7206c26a29a2af226696c145c924a6d3754

Cherry-pick e23bf8f7
Original commit message:

    tools,src: refloat forbid usage of v8::Persistent

    `v8::Persistent` comes with the surprising catch that it requires
    manual cleanup. `v8::Global` doesn’t, making it easier to use,
    and additionally provides move semantics. New code should always
    use `v8::Global`.

    PR-URL: https://github.com/nodejs/node/pull/31018


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

PR-URL: https://github.com/nodejs/node/pull/35569


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/35719


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/35866

PR-URL: https://github.com/nodejs/node/pull/36213


Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/36235


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/36324


Reviewed-By: Beth Griggs <bgriggs@redhat.com>

PR-URL: https://github.com/nodejs/node/pull/38851


Reviewed-By: Khaidi Chu <i@2333.moe>

79d487e3

tools: bump cpplint to 1.5.5 · 0fe55c76

Rich Trott authored May 29, 2021

PR-URL: https://github.com/nodejs/node/pull/38851


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>

0fe55c76

tools: remove exception for Node.js 8 and earlier · 0332d31b

Rich Trott authored May 29, 2021

Remove exception in .eslintrc.js to accommodate versions of Node.js
prior to 10.x. 10.x and later all support omitting catch block
arguments.

PR-URL: https://github.com/nodejs/node/pull/38840


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

0332d31b

build: work around bug in MSBuild v16.10.0 · 3457130e

Michaël Zasso authored May 31, 2021

This allows to build Node.js at the (temporary) cost of longer build
times.

Refs: https://github.com/nodejs/node/issues/38872
Refs: https://github.com/dotnet/msbuild/releases/tag/v16.10.0
Refs: https://github.com/dotnet/msbuild/pull/6465
Refs: https://github.com/dotnet/msbuild/issues/6373

PR-URL: https://github.com/nodejs/node/pull/38873


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

3457130e

doc: use "Long Term Support" in collaborator guide · 58bd0463

Rich Trott authored May 29, 2021

Use "Long Term Support" rather than "Long-term support".

Refs: https://github.com/nodejs/node/pull/38839#issuecomment-850853132

PR-URL: https://github.com/nodejs/node/pull/38841


Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

58bd0463

doc: use "Long Term Support" in technical values doc · 0ba7da6f

Rich Trott authored May 29, 2021

Use "Long Term Support" rather than "long term support".

Refs: https://github.com/nodejs/node/pull/38839#issuecomment-850853132

PR-URL: https://github.com/nodejs/node/pull/38841


Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

0ba7da6f

May 31, 2021

doc: use "Long Term Support" in README · 16ae3784

Philip authored May 29, 2021

"Long-Term Support" should have a capital "T" according to most style
guides if we're making it a proper noun as we are here. It's obviously
not super important in the grand scope of the project, but it makes
things appear more formal and correct.

PR-URL: https://github.com/nodejs/node/pull/38839


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

16ae3784

May 29, 2021

tools: update setup-node to setup-node@v2 · 4c508f51

pengjie authored May 27, 2021



Signed-off-by: pengjie <37610029@qq.com>

PR-URL: https://github.com/nodejs/node/pull/38825


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

4c508f51

debugger: wait for V8 debugger to be enabled · f1cbaea7

Michaël Zasso authored May 26, 2021

Refs: https://github.com/nodejs/node/pull/38273#issuecomment-848438189

PR-URL: https://github.com/nodejs/node/pull/38811


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

f1cbaea7

May 28, 2021

test: fix writefile with fd · 0222a10a

Nitzan Uziely authored May 26, 2021

fix writefile with fd so that it'll close the fds
that is uses during the test.

PR-URL: https://github.com/nodejs/node/pull/38820


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

0222a10a

build: add lto build to CI · ef4bf8f0

Jiawen Geng authored May 06, 2021

PR-URL: https://github.com/nodejs/node/pull/38567


Reviewed-By: James M Snell <jasnell@gmail.com>

ef4bf8f0

test: simplify test-path-resolve.js · 8b09629e

himself65 authored May 13, 2021

PR-URL: https://github.com/nodejs/node/pull/38671


Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8b09629e

May 27, 2021

lib: remove unnecessary lazy loads · a4ea9fc4

Joyee Cheung authored May 20, 2021

Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore

PR-URL: https://github.com/nodejs/node/pull/38737
Refs: https://github.com/nodejs/node/issues/35711


Reviewed-By: Anna Henningsen <anna@addaleax.net>

a4ea9fc4

lib: load internal/fs/watchers and internal/fs/read_file_context early · 9e42b4da

Joyee Cheung authored May 20, 2021

So that they are included in the builtin snapshot

PR-URL: https://github.com/nodejs/node/pull/38737
Refs: https://github.com/nodejs/node/issues/35711


Reviewed-By: Anna Henningsen <anna@addaleax.net>

9e42b4da

src: support fs_event_wrap binding in the snapshot · 39b0f4fe

Joyee Cheung authored May 20, 2021

PR-URL: https://github.com/nodejs/node/pull/38737
Refs: https://github.com/nodejs/node/issues/35711


Reviewed-By: Anna Henningsen <anna@addaleax.net>

39b0f4fe

tools: update ESLint to 7.27.0 · b6471c9e

Luigi Pinca authored May 22, 2021

PR-URL: https://github.com/nodejs/node/pull/38764


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

b6471c9e

May 26, 2021

src: remove redundant v8 namespaces in `env.cc` · d3987121

Juan José Arboleda authored May 23, 2021

PR-URL: https://github.com/nodejs/node/pull/38792


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

d3987121

doc,url: clarify domainTo* when built without ICU · bbab59d7

Darshan Sen authored May 23, 2021

Continuation of: https://github.com/nodejs/node/pull/35099



Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/38789


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

bbab59d7

doc: fix grammar in `fs.md` · d28eedba

yotamselementor authored May 26, 2021

PR-URL: https://github.com/nodejs/node/pull/38818


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>

d28eedba

tools: use PrintCaughtException in the snapshot builder · 308ab8ae

Joyee Cheung authored May 20, 2021

This prints not only the error message but also the error
source line and the stack trace wherever possible.

PR-URL: https://github.com/nodejs/node/pull/38745


Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

308ab8ae

test: improve coverage for `question` in readline · ccde7fc2

Qingyu Deng authored May 24, 2021

PR-URL: https://github.com/nodejs/node/pull/38799
Refs: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ccde7fc2

benchmark: output JSON-compatible numbers · 2a1dea8a

Michaël Zasso authored May 23, 2021

This is to simplify the implementation of a JavaScript version of the
compare.R script.

PR-URL: https://github.com/nodejs/node/pull/38778


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

2a1dea8a

test: os, replace custom flatten method with built-in Array.flat · a43a140e

Wael Almattar authored May 22, 2021

PR-URL: https://github.com/nodejs/node/pull/38770


Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

a43a140e

May 25, 2021

stream: add a non-destroying iterator to Readable · df85d370

Nitzan Uziely authored Apr 17, 2021

add a non-destroying iterator to Readable

fixes: https://github.com/nodejs/node/issues/38491

PR-URL: https://github.com/nodejs/node/pull/38526
Fixes: https://github.com/nodejs/node/issues/38491


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

df85d370

doc: fixup code sample in http.md · 5a67f150

TodorTotev authored May 22, 2021

PR-URL: https://github.com/nodejs/node/pull/38776


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

5a67f150

worker: use rwlock for sibling group · 46eb417b

Anna Henningsen authored May 23, 2021

Since it is much more common to send messages than to add or
remove ports from a sibling group, using a rwlock is appropriate here.

Refs: https://github.com/nodejs/node/issues/38780#issuecomment-846548949

PR-URL: https://github.com/nodejs/node/pull/38783


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

46eb417b

fs: fix rmsync error swallowing · f9447b71

Nitzan Uziely authored May 14, 2021

fix rmsync swallowing errors instead of throwing them.

fixes: https://github.com/nodejs/node/issues/38683
fixes: https://github.com/nodejs/node/issues/34580

PR-URL: https://github.com/nodejs/node/pull/38684
Fixes: https://github.com/nodejs/node/issues/38683
Fixes: https://github.com/nodejs/node/issues/34580


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

f9447b71

src: use SPrintF in ProcessEmitWarning · fa7cdd6f

Darshan Sen authored May 21, 2021

PR-URL: https://github.com/nodejs/node/pull/38758


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

fa7cdd6f

cli: add -C alias for --conditions flag · 3ad4fa01

Guy Bedford authored May 21, 2021

PR-URL: https://github.com/nodejs/node/pull/38755


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>

3ad4fa01

build: allow LTO with Clang 3.9.1+ · ab71af34

Jesse Chan authored May 21, 2021



Bug: #38568
Test: manual,
      - arm64-apple-darwin20.5.0 / Apple clang version 12.0.5 (clang-1205.0.22.9)
      - x86_64-pc-linux-gnu / Ubuntu clang version 13.0.0-++20210520052624+48780527dd68-1~exp1~20210520153429.417
Signed-off-by: Jesse Chan <jc@linux.com>

PR-URL: https://github.com/nodejs/node/pull/38751


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

ab71af34