- Jun 02, 2021
-
-
Rich Trott authored
I'm not sure that this is any clearer than the existing code, but I don't think it's significantly less clear, and it avoids comment disabling a lint rule. PR-URL: https://github.com/nodejs/node/pull/38847 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
npm-robot authored
PR-URL: https://github.com/nodejs/node/pull/38880 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ruy Adorno <ruyadorno@github.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38819 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Luigi Pinca authored
Provides the platform-specific file path of the null device. PR-URL: https://github.com/nodejs/node/pull/38569 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
- Jun 01, 2021
-
-
XadillaX authored
PR-URL: https://github.com/nodejs/node/pull/38852 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
XadillaX authored
Refs: https://github.com/nodejs/node/pull/37473 PR-URL: https://github.com/nodejs/node/pull/38366 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
bl-ue authored
PR-URL: https://github.com/nodejs/node/pull/38846 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
bl-ue authored
PR-URL: https://github.com/nodejs/node/pull/38845 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
julianjany authored
PR-URL: https://github.com/nodejs/node/pull/38822 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/38850 Reviewed-By:
-
Rich Trott authored
Cherry-pick 12c8b4d1 Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: https://github.com/nodejs/node/pull/17373 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/38851 Reviewed-By:
-
Rich Trott authored
Remove exception in .eslintrc.js to accommodate versions of Node.js prior to 10.x. 10.x and later all support omitting catch block arguments. PR-URL: https://github.com/nodejs/node/pull/38840 Reviewed-By:
-
Michaël Zasso authored
This allows to build Node.js at the (temporary) cost of longer build times. Refs: https://github.com/nodejs/node/issues/38872 Refs: https://github.com/dotnet/msbuild/releases/tag/v16.10.0 Refs: https://github.com/dotnet/msbuild/pull/6465 Refs: https://github.com/dotnet/msbuild/issues/6373 PR-URL: https://github.com/nodejs/node/pull/38873 Reviewed-By:
-
Rich Trott authored
Use "Long Term Support" rather than "Long-term support". Refs: https://github.com/nodejs/node/pull/38839#issuecomment-850853132 PR-URL: https://github.com/nodejs/node/pull/38841 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
-
Rich Trott authored
Use "Long Term Support" rather than "long term support". Refs: https://github.com/nodejs/node/pull/38839#issuecomment-850853132 PR-URL: https://github.com/nodejs/node/pull/38841 Reviewed-By:
-
- May 31, 2021
-
-
Philip authored
"Long-Term Support" should have a capital "T" according to most style guides if we're making it a proper noun as we are here. It's obviously not super important in the grand scope of the project, but it makes things appear more formal and correct. PR-URL: https://github.com/nodejs/node/pull/38839 Reviewed-By:
-
- May 29, 2021
-
-
pengjie authored
Signed-off-by:
pengjie <37610029@qq.com> PR-URL: https://github.com/nodejs/node/pull/38825 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/nodejs/node/pull/38273#issuecomment-848438189 PR-URL: https://github.com/nodejs/node/pull/38811 Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
-
- May 28, 2021
-
-
Nitzan Uziely authored
fix writefile with fd so that it'll close the fds that is uses during the test. PR-URL: https://github.com/nodejs/node/pull/38820 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/38567 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/38671 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
- May 27, 2021
-
-
Joyee Cheung authored
Now that more modules are included in the snapshot, it's not necessary to lazy load them anymore PR-URL: https://github.com/nodejs/node/pull/38737 Refs: https://github.com/nodejs/node/issues/35711 Reviewed-By:
-
Joyee Cheung authored
So that they are included in the builtin snapshot PR-URL: https://github.com/nodejs/node/pull/38737 Refs: https://github.com/nodejs/node/issues/35711 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/38737 Refs: https://github.com/nodejs/node/issues/35711 Reviewed-By:
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/38764 Reviewed-By:
-
- May 26, 2021
-
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/38792 Reviewed-By:
-
Darshan Sen authored
Continuation of: https://github.com/nodejs/node/pull/35099 Signed-off-by:
-
yotamselementor authored
PR-URL: https://github.com/nodejs/node/pull/38818 Reviewed-By:
Harshitha K P <harshitha014@gmail.com>
-
Joyee Cheung authored
This prints not only the error message but also the error source line and the stack trace wherever possible. PR-URL: https://github.com/nodejs/node/pull/38745 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com>
-
Qingyu Deng authored
PR-URL: https://github.com/nodejs/node/pull/38799 Refs: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
-
Michaël Zasso authored
This is to simplify the implementation of a JavaScript version of the compare.R script. PR-URL: https://github.com/nodejs/node/pull/38778 Reviewed-By:
-
Wael Almattar authored
PR-URL: https://github.com/nodejs/node/pull/38770 Reviewed-By:
-
- May 25, 2021
-
-
Nitzan Uziely authored
add a non-destroying iterator to Readable fixes: https://github.com/nodejs/node/issues/38491 PR-URL: https://github.com/nodejs/node/pull/38526 Fixes: https://github.com/nodejs/node/issues/38491 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
TodorTotev authored
PR-URL: https://github.com/nodejs/node/pull/38776 Reviewed-By:
-
Anna Henningsen authored
Since it is much more common to send messages than to add or remove ports from a sibling group, using a rwlock is appropriate here. Refs: https://github.com/nodejs/node/issues/38780#issuecomment-846548949 PR-URL: https://github.com/nodejs/node/pull/38783 Reviewed-By:
-
Nitzan Uziely authored
fix rmsync swallowing errors instead of throwing them. fixes: https://github.com/nodejs/node/issues/38683 fixes: https://github.com/nodejs/node/issues/34580 PR-URL: https://github.com/nodejs/node/pull/38684 Fixes: https://github.com/nodejs/node/issues/38683 Fixes: https://github.com/nodejs/node/issues/34580 Reviewed-By:
-
Darshan Sen authored
PR-URL: https://github.com/nodejs/node/pull/38758 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/38755 Reviewed-By:
Jan Krems <jan.krems@gmail.com>
-
Jesse Chan authored
Bug: #38568 Test: manual, - arm64-apple-darwin20.5.0 / Apple clang version 12.0.5 (clang-1205.0.22.9) - x86_64-pc-linux-gnu / Ubuntu clang version 13.0.0-++20210520052624+48780527dd68-1~exp1~20210520153429.417 Signed-off-by:Jesse Chan <jc@linux.com> PR-URL: https://github.com/nodejs/node/pull/38751 Reviewed-By:
-
