- Apr 17, 2018
-
-
Rod Vagg authored
c-ares switched to using ares_ssize_t for platform-independent ssize_t, our GYP usage to include config/<platform>/ares_config.h causes problems when including gyp as a library in core, i.e. in env.h and cares_wrap.h, where the defines don't get pulled in properly. This, so far, is the easiest approach to just making it work nicely--explicitly defining ares_ssize_t for the different Windows variants and ssize_t for non-Windows where we don't have a configured type from an ares_config.h. In all of our non-Windows platforms it is ssize_t anyway so this is safe. PR-URL: https://github.com/nodejs/node/pull/15378 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/19939 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
* Fix patch for CVE-2017-1000381 to not be overly aggressive. * win32: Preserve DNS server order returned by Windows when sorting and exclude DNS servers in legacy subnets. * win32: Support most recent Visual Studio 2017. * gethostbyaddr should fail with ECANCELLED not ENOTFOUND when ares_cancel is called. * win32: Exclude legacy ipv6 subnets. * android: Applications compiled for Oreo can no longer use __system_property_get and must use Java calls to retrieve DNS servers. * win32: Force use of ANSI functions. * CMake minimum version is now 3.1. * ares_gethostbyname.3: fix callback status values. * docs: Document WSAStartup requirement. * Fix a typo in init_by_resolv_conf. * Android JNI code leaks local references in some cases. * Force using the ANSI versions of WinAPI functions. The most important changes have already been included via * 50e580df deps: cherry-pick 0ef4a0c64b6 from c-ares upstream * 9a0631df deps: cherry-pick 18ea996 from c-ares upstream PR-URL: https://github.com/nodejs/node/pull/19939 Reviewed-By:
-
Beth Griggs authored
PR-URL: https://github.com/nodejs/node/pull/19378 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This adds a example to `assert.throws` to document checking against error instances. It also makes it clearer what some arguments can receive as input. PR-URL: https://github.com/nodejs/node/pull/19885 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Ruben Bridgewater authored
This makes sure `assert.rejects` is always called with a second argument. Besides that it is also changes a eslint error message to suggest objects instead of a regular expression. PR-URL: https://github.com/nodejs/node/pull/19885 Reviewed-By:
-
Ruben Bridgewater authored
This adds direct promise support to `assert.rejects` and `assert.doesNotReject`. It will now accept both, functions and ES2015 promises as input. Besides this the documentation was updated to reflect the latest changes. It also refactors the tests to a non blocking way to improve the execution performance and improves the coverage. PR-URL: https://github.com/nodejs/node/pull/19885 Reviewed-By:
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/19643 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Taking the source code of a function and running it in another context does not play well with coverage instrumentation. For now, do the simple thing and just write the source code as a string literal. Fixes: https://github.com/nodejs/node/issues/19912 Refs: https://github.com/nodejs/node/pull/19524 PR-URL: https://github.com/nodejs/node/pull/20035 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/20016 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Gus Caplan authored
Original commit message: [api] introduce v8::Value::IsModuleNamespaceObject This allows an embedder to check if a Value is a module namespace object. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idffceff451dd5f5c6a53d4cb3ce02c1c2c5b653c Reviewed-on: https://chromium-review.googlesource.com/1011762 Reviewed-by:Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#52597} Refs: https://github.com/v8/v8/commit/39d546a24022b62b00aedf7b556ac6c9e2306aab PR-URL: https://github.com/nodejs/node/pull/20016 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/20003 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Vse Mozhet Byt authored
Also, make signatures easier for copy-paste testing. PR-URL: https://github.com/nodejs/node/pull/20036 Reviewed-By:
-
Joseph Gordon authored
PR-URL: https://github.com/nodejs/node/pull/18689 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20028 Reviewed-By:
-
Bartosz Sosnowski authored
Adds NASM installation to the Boxstarter script. Refs: https://github.com/nodejs/node/issues/19918 PR-URL: https://github.com/nodejs/node/pull/19950 Reviewed-By:
-
davidmarkclements authored
changes the base instance for ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED from Error to TypeError as a more accurate representation of the error.. PR-URL: https://github.com/nodejs/node/pull/19958 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
-
Snehil Verma authored
PR-URL: https://github.com/nodejs/node/pull/19882 Reviewed-By:
-
Ben Noordhuis authored
Original commit message: [intl] unbreak build with ICU 57 Remove a call to `icu::toUCharPtr()` that wasn't present in other similar looking call sites either, just reinterpret_cast directly. Fixes https://github.com/nodejs/node/issues/19656. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3 Reviewed-on: https://chromium-review.googlesource.com/987953 Reviewed-by:Daniel Ehrenberg <littledan@chromium.org> Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Cr-Commit-Position: refs/heads/master@{#52311} PR-URL: https://github.com/nodejs/node/pull/19710 Fixes: https://github.com/nodejs/node/issues/19656 Refs: https://github.com/v8/v8/commit/b767cde1e7bb94b3fea13f2d7e10cd90e6813d6c Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Yang Guo <yangguo@chromium.org>
-
Chin Huang authored
Add sync trace to fs operations which is enabled by the node.fs.sync trace event category. Also add a general test js file to verify all operations. PR-URL: https://github.com/nodejs/node/pull/19649 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Harry Sarson authored
Link text and url were swapped around, this pr puts the link text inside [] and the url inside (). PR-URL: https://github.com/nodejs/node/pull/20030 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Ujjwal Sharma authored
Add `HandleError`s to the AsyncScope constructor and destructor in async_wrap-inl.h to fix "FATAL ERROR" incurring observed while running test-http2-respond-with-file using the --trace-events-enabled flag. Fixes: https://github.com/nodejs/node/issues/19921 PR-URL: https://github.com/nodejs/node/pull/19972 Reviewed-By:
-
Indranil Dasgupta authored
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: https://github.com/nodejs/node/issues/20018 PR-URL: https://github.com/nodejs/node/pull/20031 Reviewed-By:
-
Daniel Bevenius authored
I looks like this test has not worked as expected since commit 2bc7841d ("test: use random ports where possible"). The test in that commit checked for `CERT_REVOKED` which was returned by CheckWhitelistedServerCert. CheckWhitelistedServerCert was later removed in commit dc875438 ("src: drop CNNIC+StartCom certificate whitelisting"). I'm suggesting that this test case be removed as I don't think it is valid anymore. PR-URL: https://github.com/nodejs/node/pull/19767 Reviewed-By:
-
Daniel Bevenius authored
Currently this test will overwrite the clientOpts object with the port, instead of setting the port property on the clientOpts object which looks like the original intent. Doing this the test fails reporting that the fake-cnnic-root-cert has expired. This is indeed true: $ openssl x509 -in test/fixtures/keys/fake-cnnic-root-cert.pem \ -text -noout Certificate: ... Validity Not Before: Jun 9 17:15:16 2015 GMT Not After : Mar 29 17:15:16 2018 GMT This commit sets the errorCode to CERT_HAS_EXPIRED. I tried updating the certificate using test/fixtures/keys/Makefile but then no error is thrown and I'm currently looking into this. PR-URL: https://github.com/nodejs/node/pull/19767 Reviewed-By: -
Daniel Bevenius authored
Currently when running make clean, followed by make not all certificates get genenerated. In addition there are also the following error messages related to the startdate in agent8-cert.pem, and agent9-cert.pem: start date is invalid, it should be YYMMDDHHMMSSZ After this commit it is possible to perform the following commands: $ make clean $ make $ make test PR-URL: https://github.com/nodejs/node/pull/19975 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
davidmarkclements authored
changes the base instance for ERR_INVALID_REPL_EVAL_CONFIG from Error to TypeError as a more accurate representation of the error and adds a unit test for the repl options that trigger this error. PR-URL: https://github.com/nodejs/node/pull/19984 Reviewed-By:
-
Rich Trott authored
Replace mentions of `RangeError` with the specific error code (e.g., `ERR_INVALID_OPT_VALUE`). Minor improvements to nearby text (wrap at 80 chars, serial comma, remove unnecessary articles, use present tense consistently). PR-URL: https://github.com/nodejs/node/pull/19982 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
davidmarkclements authored
changes the base instance for ERR_INVALID_IP_ADDRESS from Error to TypeError as a more accurate representation of the error. PR-URL: https://github.com/nodejs/node/pull/19979 Reviewed-By:
-
Ruben Bridgewater authored
The property is not necessary as it is possible to check for the operator instead. PR-URL: https://github.com/nodejs/node/pull/19467 Reviewed-By:
-
Ruben Bridgewater authored
This improves the error messages for: - assert.notDeepStrictEqual - assert.deepStrictEqual - assert.notStrictEqual - assert.strictEqual Those will now always use the same error message as used in the strict mode. PR-URL: https://github.com/nodejs/node/pull/19467 Reviewed-By:
-
Ruben Bridgewater authored
Right now it is not possible to distinguish arguments from a regular object. This adds a arguments indicator. PR-URL: https://github.com/nodejs/node/pull/19467 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20022 Reviewed-By:
-
Daniel Bevenius authored
Currently when configuring --without-ssl the following warning is displayed: WARNING: openssl_no_asm is enabled due to missed or old assembler. Please refer BUILDING.md This commit adds a check of options.without_ssl to avoid this warning when --without-ssl is used. PR-URL: https://github.com/nodejs/node/pull/19934 Reviewed-By: -
Daniel Bevenius authored
Currently, the following compiler warning is issued: ../binding.cc:26:27: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations] const String::Utf8Value filename(args[0]); ^ This commit updates the code to use the Isolate version. PR-URL: https://github.com/nodejs/node/pull/19966 Reviewed-By: -
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20023 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/19587 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
willhayslett authored
* Alphabetize the command line options and environment variables in doc/api/cli.md for consistency and readability. * Update doc/api/cli.md to include command line options being printed in the `node.PrintHelp()` function in src/node.cc but weren't otherwise documented in the cli spec. Options added include: --napi-modules --v8-pool-size=num --experimental-modules --experimental-vm-modules * ASCII sort the node man page command line options. This change brings sort order consistency between the cli options displayed in doc/node.1 and the cli options enumerated in other areas of the project. Also rearrange the language for `--use-bundled-ca`, `--use-openssl-ca` to correspond with the order of the options as displayed. * Update `node.PrintHelp()` function to return command line options and environment variables sorted in ASCII order. Additionally, add missing options as sourced from doc/api/cli.md. Options added include `--`, `--help` and the `NODE_PRESERVE_SYMLINKS` environment variable. Also update the comments in the `node.PrintHelp()` method to C++ style. * Create tests to validate that the newly ASCII sorted cli options in the `node.PrintHelp()` function are being returned according to build configurations as expected. PR-URL: https://github.com/nodejs/node/pull/19878 Refs: https://github.com/nodejs/node/issues/19814 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Ruben Bridgewater authored
By default eslint does not validate variables that are placed in a typeof check. PR-URL: https://github.com/nodejs/node/pull/19926 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/20004 Fixes: https://github.com/nodejs/node/issues/6799 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Otherwise, potentially no output is shown for aborts. PR-URL: https://github.com/nodejs/node/pull/19990 Refs: https://github.com/nodejs/node/issues/19903 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
