Unverified Commit 9a0631df authored by Anna Henningsen's avatar Anna Henningsen Committed by Ruben Bridgewater
Browse files

deps: cherry-pick 18ea996 from c-ares upstream

Original commit message:

    ares_parse_naptr_reply: make buffer length check more accurate

    9478908a490a6bf009ba58d81de8c1d06d50a117 introduced a length check
    for records parsed by `ares_parse_naptr_reply()`. However, that
    function is designed to parse replies which also contain non-NAPTR
    records; for A records, the `rr_len > 7` check will fail as there
    are only 4 bytes of payload.
    In particular, parsing ANY replies for NAPTR records was broken
    by that patch.

    Fix that by moving the check into the case in which it is already
    known that the record is a NAPTR record.

Ref: https://github.com/c-ares/c-ares/commit/18ea99693d63f957ecb670045adbd2c1da8a4641
PR-URL: https://github.com/nodejs/node/pull/13883


Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
parent 34d125f1
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment