- Jan 30, 2020
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/31538 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jan 29, 2020
-
-
Tobias Nießen authored
Dynamic error messages often contain important information that depends on the context, e.g., which argument caused an ERR_INVALID_ARG_TYPE, which type was expected, and which type was received. I don't think that internal breakage when changing a dynamic error message should prevent us from testing such properties properly. PR-URL: https://github.com/nodejs/node/pull/31421 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Matteo Collina authored
A test was missing for an async iterator created after the stream had emitted 'close'. This was regressed by #31314. See: https://github.com/nodejs/node/pull/31314 PR-URL: https://github.com/nodejs/node/pull/31508 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Matteo Collina authored
This reverts commit d15b8ea3. PR-URL: https://github.com/nodejs/node/pull/31508 Reviewed-By:
-
This is a Built-In change in Python 3 used by compile_commands_json.py to generate compile_commands_json.json. Node.js dropped Python 2 support in this script, `items()` works as expected replacement. PR-URL: https://github.com/nodejs/node/pull/31528 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com> Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Daniele Belardi authored
Use let and const in domain, es, events, fixtures, fs, http, http2 and misc. PR-URL: https://github.com/nodejs/node/pull/31518 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/31522 Reviewed-By:
-
Rusty Conover authored
When internal debug is enabled, output null strings as "(null)" rather than crashing, matching glibc's behavior. PR-URL: https://github.com/nodejs/node/pull/31523 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Denys Otrishko authored
Fixes: https://github.com/nodejs/node/issues/31517 PR-URL: https://github.com/nodejs/node/pull/31524 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Robert Nagy authored
writable/readable does not indicate whether as stream is a Writable/Readable. This implements a better check for whether a object is a Writable/Readable. PR-URL: https://github.com/nodejs/node/pull/31527 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
- Jan 28, 2020
-
-
XhmikosR authored
PR-URL: https://github.com/nodejs/node/pull/31492 Reviewed-By:
-
kenzo-spaulding authored
Updated to conform to style guide. PR-URL: https://github.com/nodejs/node/pull/31503 Reviewed-By:
-
Justin Ridgewell authored
This seems to be a leftover from the chromium project. Nothing uses `#reverseMappingsBySourceURL`, so constructing it isn't necessary. PR-URL: https://github.com/nodejs/node/pull/31512 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/31519 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
legendecas authored
If terminating the process with ctrl-c / SIGINT, prints a JS stacktrace leading up to the currently executing code. The feature would be enabled under option `--trace-sigint`. Conditions of no stacktrace on sigint: - has (an) active sigint listener(s); - main thread is idle (i.e. uv polling), a message instead of stacktrace would be printed. PR-URL: https://github.com/nodejs/node/pull/29207 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Christopher Hiller <boneskull@boneskull.com> Reviewed-By:
-
Anna Henningsen authored
Make `SetImmediate()` behave more like `process.nextTick()` (which matches how we use it) by also running tasks that have been added during previous `SetImmediate()` calls. PR-URL: https://github.com/nodejs/node/pull/31502 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Previously, this code could have closed the server before the connection was actually received by the server, as the `'close'` event on the client side can be emitted before the connection is established. The following commit exacerbates this problem, so fix the test first. PR-URL: https://github.com/nodejs/node/pull/31502 Reviewed-By:
-
- Jan 27, 2020
-
-
bcoe authored
When creating directories recursively, the logic should bail immediately on UV_EACCES and bubble the error to the user. PR-URL: https://github.com/nodejs/node/pull/31505 Fixes: https://github.com/nodejs/node/issues/31481 Reviewed-By:
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/31504 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Justin Ridgewell authored
These both have to do with extremely large numbers, so it's unlikely to cause a problem in practice. Still, correctness. First, encoding `-2147483648` in VLQ returns the value `"B"`. When decoding, we get the value `1` after reading the base64. We then check if the first bit is set (it is) to see if we should negate it, then we shift all bits right once. Now, `value` will be `0` and `negate` will be `true`. So, we'd return `-0`. Which is a bug! `-0` isn't `-2147483648`, and we've broken a round trip. Second, encoding any number with the 31st bit set, we'd return the opposite sign. Let's use `1073741824`. Encoding, we get `"ggggggC"`. When decoding, we get the value `-2147483648` after reading the base64. Notice, it's already negative (the 32nd bit is set, because the 31st was set and we shifted everything left once). We'd then check the first bit (it's not) and shift right. But we used `>>`, which does not shift the sign bit. We actually wanted `>>>`, which will. Because of that bug, we get back `-1073741824` instead of the positive `1073741824`. It's even worse if the 32nd and 31st bits are set, `-1610612736` becomes `536870912` after a round trip. I recently fixed the same two bugs in Closure Compiler: https://github.com/google/closure-compiler/commit/584418eb PR-URL: https://github.com/nodejs/node/pull/31490 Reviewed-By:
Gus Caplan <me@gus.host>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/31489 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Brian White authored
This implementation provides optimizations not included upstream. PR-URL: https://github.com/nodejs/node/pull/31201 Reviewed-By:
-
cjihrig authored
Original commit message: allow windows to detect tty types uv_fs_fstat() fails on TTYs on Windows. This commit updates uvwasi__get_filetype_by_fd() to detect this case and map the fd to the WASI character device type. Refs: https://github.com/nodejs/node/issues/31461 Fixes: https://github.com/nodejs/node/issues/31461 PR-URL: https://github.com/nodejs/node/pull/31495 Reviewed-By: -
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By:
-
Rich Trott authored
This enables the grey background for inline code in headers. Refs: https://github.com/nodejs/node/pull/31460#issuecomment-577154740 PR-URL: https://github.com/nodejs/node/pull/31493 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
-
- Jan 26, 2020
-
-
Gabriel Schulhof authored
Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. PR-URL: https://github.com/nodejs/node/pull/31488 Reviewed-By:
-
Daniel Bevenius authored
This commit suggests that cast-function-type warnings be ignored from v8.h. Currently, GCC reports a number of warnings like this: In file included from ../src/util.h:27, from ../src/aliased_buffer.h:7, from ../src/memory_tracker.h:5, from ../src/base_object.h:27, from ../src/async_wrap.h:27, from ../src/req_wrap.h:6, from ../src/req_wrap-inl.h:6, from ../src/connect_wrap.h:6, from ../src/connect_wrap.cc:1: ../deps/v8/include/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak( P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::BaseObject; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)]’: ../src/base_object-inl.h:123:42: required from here ../deps/v8/include/v8.h:10374:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<node::BaseObject>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type] reinterpret_cast<Callback>(callback), type); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The motivation for doing this that it makes it difficult to spot other warnings that might be important. Since it is v8 that performs this cast I was not able to find a way around it. PR-URL: https://github.com/nodejs/node/pull/31475 Reviewed-By:Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/31474 Reviewed-By:
-
cjihrig authored
Notable changes: - SetApplicationDaemon() is no longer called on macOS. - uv_interface_addresses() is implemented on IBMi. - The return value of uv__open_cloexec() is now handled properly. - A race condition in fsevents has been fixed. Fixes: https://github.com/nodejs/node/issues/31328 Fixes: https://github.com/nodejs/help/issues/2099 PR-URL: https://github.com/nodejs/node/pull/31477 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Alexander Smarus authored
PR-URL: https://github.com/nodejs/node/pull/31467 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/31465 Reviewed-By:
-
Anna Henningsen authored
This test was broken by de2c68c7. Refs: https://github.com/nodejs/node/pull/31386 PR-URL: https://github.com/nodejs/node/pull/31494 Reviewed-By:
-
- Jan 25, 2020
-
-
Ruben Bridgewater authored
This makes sure `util.inspect()` does not throw in case the typed array's length property was set to something invalid. Instead, always use the original information. PR-URL: https://github.com/nodejs/node/pull/31458 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Eran Levin authored
This pull request makes fs.watch throw exception, whenever it is used in an incompatible platform. For this change following changes were made to api: 1.a new error type has been introduced. 2.fs.watch has been changed accordingly. Users who use recursive on non-windows and osx platforms, will face a new exception. For this reason, it's a breaking change. Fixes: https://github.com/nodejs/node/issues/29901 PR-URL: https://github.com/nodejs/node/pull/29947 Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By:
-
Robert Nagy authored
Further fixes an issue with the async iterator example where an incorrect assumption was made in regards that drain or error is always invoked after !write(). Fixes: https://github.com/nodejs/node/issues/31365 PR-URL: https://github.com/nodejs/node/pull/31367 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/31498 Reviewed-By:
-
