- Oct 28, 2018
-
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/23841 Fixes: https://github.com/nodejs/node/issues/23836 Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Anna Henningsen authored
Add overloads of the error generation/throwing methods that take an `Isolate*` argument, since the created objects don’t depend on the `Environment*` in question. Also, remove `THROW_ERR_OUT_OF_RANGE_WITH_TEXT`, which did the same thing as `THROW_ERR_OUT_OF_RANGE` in a more convoluted way. PR-URL: https://github.com/nodejs/node/pull/23879 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Matteo Collina authored
Fixes: https://github.com/nodejs/node/issues/23890 PR-URL: https://github.com/nodejs/node/pull/23901 Reviewed-By:
-
Matteo Collina authored
Fixes: https://github.com/nodejs/node/issues/23891 PR-URL: https://github.com/nodejs/node/pull/23901 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/7.0.276.28...7.0.276.32 PR-URL: https://github.com/nodejs/node/pull/23851 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Anna Henningsen authored
These have been overlooked in 036fbdb6. PR-URL: https://github.com/nodejs/node/pull/23880 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Anna Henningsen authored
This fixes a compiler warning about comparing against the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant. PR-URL: https://github.com/nodejs/node/pull/23880 Reviewed-By:
-
Anna Henningsen authored
Otherwise, the compiler complains about a missing definition for the (inline) `Calloc` function. PR-URL: https://github.com/nodejs/node/pull/23880 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/23881 Reviewed-By:
-
- Oct 27, 2018
-
-
cjihrig authored
The deprecation code was not updated when landing the PR. PR-URL: https://github.com/nodejs/node/pull/23883 Refs: https://github.com/nodejs/node/pull/23760 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This was introduced in 48d1335b. Previously, values such as `undefined` would not be coerced properly because `NumberValue()` returns `NaN` for them. Refs: https://github.com/nodejs/node/pull/23158 PR-URL: https://github.com/nodejs/node/pull/23898 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Instead of getting a reference to the main `AliasedBuffer`, which would always unnecesarily allocate and destroy a `Persistent` handle, store and use a reference to the owning object. PR-URL: https://github.com/nodejs/node/pull/23844 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
- Oct 26, 2018
-
-
Ben Noordhuis authored
Make fs.open() and fs.openSync() more economic to use by making the flags argument optional. You can now write: fs.open(file, cb) Instead of the more verbose: fs.open(file, 'r', cb) This idiom is already supported by functions like fs.readFile(). PR-URL: https://github.com/nodejs/node/pull/23767 Reviewed-By: -
Joyee Cheung authored
From the WHATWG console spec: > For historical web-compatibility reasons, the namespace object for > console must have as its [[Prototype]] an empty object, created as > if by ObjectCreate(%ObjectPrototype%), instead of %ObjectPrototype%. Since in Node.js, the Console constructor has been exposed through require('console'), we need to keep the Console constructor but we cannot actually use `new Console` to construct the global console. This patch changes the prototype chain of the global console object, so the console.Console.prototype is not in the global console prototype chain anymore. ``` const proto = Object.getPrototypeOf(global.console); // Before this patch proto.constructor === global.console.Console // After this patch proto.constructor === Object ``` But, we still maintain that ``` global.console instanceof global.console.Console ``` through a custom Symbol.hasInstance function of Console that tests for a special symbol kIsConsole for backwards compatibility. This fixes a case in the console Web Platform Test that we commented out. PR-URL: https://github.com/nodejs/node/pull/23509 Refs: https://github.com/whatwg/console/issues/3 Refs: https://console.spec.whatwg.org/#console-namespace Reviewed-By:Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Loic authored
PR-URL: https://github.com/nodejs/node/pull/23829 Reviewed-By:
-
Raoof authored
PR-URL: https://github.com/nodejs/node/pull/19780 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
cjihrig authored
This function was undocumented and only used in one place throughout the codebase, plus a test. PR-URL: https://github.com/nodejs/node/pull/23820 Reviewed-By:
-
Ouyang Yadong authored
Refs: https://github.com/nodejs/node/pull/23804 PR-URL: https://github.com/nodejs/node/pull/23826 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Anna Henningsen authored
These APIs have been deprecated upstream in V8. PR-URL: https://github.com/nodejs/node/pull/23414 Reviewed-By:
-
Jonathan Cardoso Machado authored
Those categories are necessary to build addons that depends on libcurl and libssh, the following were the missing symbols: libcurl: OCSP_cert_status_str OCSP_check_validity OCSP_basic_verify OCSP_RESPONSE_free OCSP_single_get0_status OCSP_response_get1_basic OCSP_BASICRESP_free OCSP_crl_reason_str OCSP_resp_count OCSP_response_status OCSP_response_status_str OCSP_resp_get0 d2i_OCSP_RESPONSE SSL_CTX_set_next_proto_select_cb libssh: EVP_ripemd160 EVP_cast5_cbc Fixes: https://github.com/nodejs/node/issues/23293 PR-URL: https://github.com/nodejs/node/pull/23344 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/23784 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/23870 Fixes: https://github.com/nodejs/node/issues/23860 Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/23864 Reviewed-By:
-
James M Snell authored
This is an undocumented utility function that is of questionable utility. Fixes: https://github.com/nodejs/node/issues/18391 PR-URL: https://github.com/nodejs/node/pull/23760 Reviewed-By:
-
- Oct 25, 2018
-
-
Anna Henningsen authored
This documents existing practices. PR-URL: https://github.com/nodejs/node/pull/23805 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Refael Ackermann authored
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: https://github.com/nodejs/node/pull/23778 Reviewed-By:
-
cclauss authored
PR-URL: https://github.com/nodejs/node/pull/21952 Reviewed-By:
-
James M Snell authored
These are known issues that can be flaky on certain platforms because they rely entirely on timing differences. PR-URL: https://github.com/nodejs/node/pull/23743 Refs: https://github.com/nodejs/node/issues/3020 Reviewed-By:
-
James M Snell authored
Using `process.nextTick()`, `Promise`, or `queueMicrotask()`, it is possible to escape the `timeout` set when running code with `vm.runInContext()`, `vm.runInThisContext()`, and `vm.runInNewContext()`. This documents the issue and adds three known_issues tests. Refs: https://github.com/nodejs/node/issues/3020 PR-URL: https://github.com/nodejs/node/pull/23743 Refs: https://github.com/nodejs/node/issues/3020 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23808 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Refael Ackermann authored
refactor grow_async_ids_stack PR-URL: https://github.com/nodejs/node/pull/23808 Reviewed-By:
-
Anna Henningsen authored
Because instances of `napi_env` are created on a per-global-object basis and because since most N-API functions refer to builtin JS objects, `napi_env` is essentially in 1:1 correspondence with `v8::Context`. This was not clear from the implementation by itself, but has emerged from conversations with the N-API team. This patch changes the `napi_env` implementation to: - Actually store the `v8::Context` it represents. - Provide more direct access to the `node::Environment` to which the `Context` belongs. - Do not store the `uv_loop_t*` explicitly, since it can be inferred from the `node::Environment` and we actually have an N-API method for that. - Replace calls to `isolate->GetCurrentContext()` with the more appropriate `napi_env` `Context`. - Implement a better (although not perfect) way of cleaning up `napi_env` instances. PR-URL: https://github.com/nodejs/node/pull/23689 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Oct 24, 2018
-
-
Refael Ackermann authored
* explicitly delete move overloads * default initialize all members * explicitly discard unused return values * const some possibles PR-URL: https://github.com/nodejs/node/pull/23793 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23793 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23793 Reviewed-By:
-
Steven R. Loomis authored
- Full release notes: http://site.icu-project.org/download/63 Fixes: https://github.com/nodejs/node/issues/22344 PR-URL: https://github.com/nodejs/node/pull/23715 Reviewed-By:
-
Steven R. Loomis authored
Building on #23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. https://github.com/nodejs/node/issues/23244 PR-URL: https://github.com/nodejs/node/pull/23715 Fixes: https://github.com/nodejs/node/issues/22344 Reviewed-By:
-
Anna Henningsen authored
Forbid modifying tracing state from worker threads, either through the built-in module or inspector sessions, since the main thread owns all global state, and at least the `async_hooks` integration is definitely not thread safe in its current state. PR-URL: https://github.com/nodejs/node/pull/23781 Fixes: https://github.com/nodejs/node/issues/22767 Refs: https://github.com/nodejs/node/issues/22513 Reviewed-By:
-
Anna Henningsen authored
As per the conversation in https://github.com/nodejs/node/issues/22513, this is essentially global, and adding this on the Environment is generally just confusing. Refs: https://github.com/nodejs/node/issues/22513 Fixes: https://github.com/nodejs/node/issues/22767 PR-URL: https://github.com/nodejs/node/pull/23781 Reviewed-By:
-
Daniel Bevenius authored
This commit extracts identical code from Connect and Connect6 into a separate function to avoid some code duplication. PR-URL: https://github.com/nodejs/node/pull/23753 Reviewed-By:
-
