- Mar 19, 2020
-
-
Matheus Marchini authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Matheus Marchini authored
PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Jonathan MERCIER authored
PR-URL: https://github.com/nodejs/node/pull/31659 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/32200 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Gabriel Schulhof authored
We have received feedback indicating that the N-API support matrix as present now can be misinterpreted to mean that old versions of N-API are no longer supported on newer versions of Node.js. Filling out the bottom of the matrix should hopefully make it clear that support for such old versions continues. PR-URL: https://github.com/nodejs/node/pull/32304 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Gus Caplan authored
Adds `--disable-proto` CLI option which can be set to `delete` or `throw`. Fixes #31951 PR-URL: https://github.com/nodejs/node/pull/32279 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com>
-
- Mar 18, 2020
-
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32276 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By:
-
Rich Trott authored
We have several tests where a number of asynchronous processes need to finish before some checks happen. These are done in a number of ways, including (as here) using our Countdown testing module. I think Promise.all() may be the idiomatic and ergonomic way to go for a lot of these tests. Using this one to get feedback on the idea. PR-URL: https://github.com/nodejs/node/pull/32273 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32230 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me>
-
cjihrig authored
This commit drops pronouns from the ERR_WORKER_PATH message, and also shortens the text a bit. PR-URL: https://github.com/nodejs/node/pull/32285 Refs: https://github.com/nodejs/node/pull/31664 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Sam Roberts authored
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so move the OpenSSL one there, too. PR-URL: https://github.com/nodejs/node/pull/32209 Reviewed-By:
-
- Mar 17, 2020
-
-
Sam Roberts authored
Multi-line JSON is more human readable, but harder for log aggregators to consume, they usually require a log message per line, particularly for JSON. Compact output will be consumable by aggregators such as EFK (Elastic Search-Fluentd-Kibana), LogDNA, DataDog, etc. PR-URL: https://github.com/nodejs/node/pull/32254 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32275 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By:
-
Rich Trott authored
Update minimist used by lint-md.js to 1.2.5. Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764 Signed-off-by:
-
Michael Dawson authored
Remove the comment about the expected version so that it does not get out of sync. The code shows the expected version anyway. Signed-off-by:
-
- Mar 16, 2020
-
-
Gabriel Schulhof authored
Use `dl_iterate_phdr(3)` to find the mapping containing `__node_text_start` instead of parsing `/proc/self/maps`. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Co-Authored-By:
-
Matheus Marchini authored
`test-inspector-multisession-ws` and `test-inspector-break-when-eval` will be affected by an upstream bug when we upgrade V8 to 8.1. The bug is caused when the Inspector sets a pause at the start of a function compiled with `CompileFunctionInContext`, but that function hasn't been executed yet. On both tests, this issue is triggered by pausing while in C++ executing LookupAndCompile, which is called by requiring internal modules while running `console.log`. To eliminate this issue in both tests, we add an extra `console.log` to ensure we only pause we required all internal modules we need. On `test-inspector-break-when-eval`, we also need to start the child process with `--inspect-brk` instead of `--inspect` to ensure the test is predictable (this test would occasianlly fail on slower machines, when console.log doesn't run fast enough to finish after emitting `Runtime.consoleAPICalled` and before the parent process sending `Runtime.evaluate` message. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10287 PR-URL: https://github.com/nodejs/node/pull/32234 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10287 Reviewed-By:
-
cjihrig authored
This commit updates the stability documentation for the report feature. All diagnostic report APIs are now listed as stable, with the exception of report-on-fatalerror, which still has a few bugs to work out. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By:
-
cjihrig authored
This commit makes the --experimental-report CLI flag a no-op. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By:
-
cjihrig authored
The report feature won't ever be disabled moving forward, so checking for its existence in the tests is no longer needed. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By:
-
cjihrig authored
This commit makes the configure --without-report flag a no-op. This commit also updates a test that depends on the report CLI flags being conditionally present. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By:
-
cjihrig authored
This commit removes all #ifdef NODE_REPORT checks in the src directory. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By:
-
- Mar 15, 2020
-
-
cjihrig authored
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: https://github.com/nodejs/node/pull/32241 Refs: https://github.com/nodejs/node/pull/31972 Reviewed-By:
-
Matheus Marchini authored
The current test relies on undeterministic behavior from V8 GC, and on newer versions of V8 this test ocasionally fails because that behavior changed. Prevent that from happening using --predictable-gc-schedule. If this test fails in the future, it should fail consistently instead of ocasionally, which should help debug. Ref: https://github.com/nodejs/node-v8/issues/144#issuecomment-597945219 Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32239 Reviewed-By:
-
Rich Trott authored
Update acorn to 7.1.1 in the dev dependencies for the markdown linter. Refs: https://app.snyk.io/vuln/SNYK-JS-ACORN-559469 Signed-off-by:
-
- Mar 14, 2020
-
-
cjihrig authored
Notable changes: - The UV_UDP_MMSG_CHUNK UDP flag has been added. - Support has been dropped for FreeBSD < 10. - The FreeBSD and Linux system call logic has been simplified to assume the presence of features covered by libuv's minimum system requirements. - Listening on IPC pipes is no longer allowed. - Fix iOS and Android builds. PR-URL: https://github.com/nodejs/node/pull/32204 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
cjihrig authored
This commit adds a test to verify that exceptions thrown from a WASI application are properly caught and rethrown. This also gets the code coverage in lib/wasi.js back to 100%. PR-URL: https://github.com/nodejs/node/pull/32157 Reviewed-By:
-
Anna Henningsen authored
There is no reason for this to be in C++. Using JavaScript means that the code is more accessible to more developers, which is important for any Node.js feature. This also simplifies the code significantly in some areas. On the technical side, this potentially also enables making some of the file system operations that are involved asynchronous. PR-URL: https://github.com/nodejs/node/pull/32201 Reviewed-By:
Guy Bedford <guybedford@gmail.com>
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/32203 Fixes: https://github.com/nodejs/node/issues/32199 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Matheus Marchini authored
Original commit message: Fix scanner-level error reporting for hashbang When the file begins with a hashbang, the scanner is in a failed state when SkipHashbang() is called. This is usually not an issue but when the parser encounters an ILLEGAL token, it will reset the SyntaxError location because of it. Bug: v8:10110 Change-Id: I1c7344bf5ad20079cff80130c991f3bff4d7e9a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995312 Reviewed-by:Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66038} Refs: https://github.com/v8/v8/commit/f9257802c1c0a0663a1d05bacf662283f6bd9050 Fixes: https://github.com/nodejs/node/issues/31284 Signed-off-by:
-
- Mar 13, 2020
-
-
Harshitha KP authored
Add a new scenario of multiple clients sharing a single data callback function managing their response data through AsyncLocalStorage APIs Refs: https://github.com/nodejs/node/pull/32063 Refs: https://github.com/nodejs/node/issues/32060 Refs: https://github.com/nodejs/node/issues/32062#issuecomment-593957787 Co-authored-by:
-
Mateusz Krawczuk authored
This change is to prevent potential bugs - e.g., someone might automatically use the variable `k` instead of `key`, that is used in vicinity of this loop. Also changed postincrement to preincrement in iteration steps. It is probably done by the optimizer anyway, but otherwise it will save an opcode each iteration. And it is a good practice. PR-URL: https://github.com/nodejs/node/pull/32012 Reviewed-By:
-
Harshitha KP authored
The test wanted to cut huge string into 1KB strings, for which a new line character was inserted at appropriate places. The value is different in Windows (10, 13). Make it portable, by making use of os.EOL semantics Refs: https://github.com/nodejs/node/issues/25988 PR-URL: https://github.com/nodejs/node/pull/32104 Reviewed-By:
-
Antoine du HAMEL authored
The explicit goal is to let users use `import.meta.url` to re-load thecurrent module inside a Worker instance. Fixes: https://github.com/nodejs/node/issues/30780 PR-URL: https://github.com/nodejs/node/pull/31664 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Guy Bedford authored
Co-Authored-By:
Geoffrey Booth <GeoffreyBooth@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/32098 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Ruben Bridgewater authored
Use an object to indicate which part belongs to the input and which to the output. On top of that this also simplifies the expected output by automatically inserting the default repl line for previews and by automatically checking for the correct output line length. PR-URL: https://github.com/nodejs/node/pull/32154 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This adds preview output for input that may not be wrapped. PR-URL: https://github.com/nodejs/node/pull/32154 Reviewed-By:
-
Bartosz Sosnowski authored
Document Windows specific fs.watch caveats. Fixes: https://github.com/nodejs/node/issues/31702 PR-URL: https://github.com/nodejs/node/pull/32176 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
