Commit 86f146a2 authored by Matheus Marchini's avatar Matheus Marchini Committed by Gireesh Punathil
Browse files

test: make test-memory-usage predictable

The current test relies on undeterministic behavior from V8 GC, and on
newer versions of V8 this test ocasionally fails because that behavior
changed.  Prevent that from happening using --predictable-gc-schedule.
If this test fails in the future, it should fail consistently instead of
ocasionally, which should help debug.

Ref: https://github.com/nodejs/node-v8/issues/144#issuecomment-597945219


Signed-off-by: default avatarMatheus Marchini <mmarchini@netflix.com>

PR-URL: https://github.com/nodejs/node/pull/32239


Reviewed-By: default avatarAnna Henningsen <anna@addaleax.net>
Reviewed-By: default avatarMichaël Zasso <targos@protonmail.com>
Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
Reviewed-By: default avatarJiawen Geng <technicalcute@gmail.com>
Reviewed-By: default avatarGireesh Punathil <gpunathi@in.ibm.com>
parent 3967f865
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment