- Nov 03, 2020
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35928 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
Cherry-pick 12c8b4d1 Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: https://github.com/nodejs/node/pull/17373 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Refs: https://github.com/nodejs/node/commit/12c8b4d15471cb6211b39c3a2ca5b10fa4b9f12b Cherry-pick fc81e801 Original commit message: Update cpplint.py to check for inline headers when the corresponding header is already included. PR-URL: https://github.com/nodejs/node/pull/21521 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Refs: https://github.com/nodejs/node/commit/fc81e801913de3e3f3c0c8e26c105f983a74e539 Cherry-pick cbc3dd99 Original commit message: src, tools: add check for left leaning pointers This commit adds a rule to cpplint to check that pointers in the code base lean to the left and not right, and also fixes the violations reported. PR-URL: https://github.com/nodejs/node/pull/21010 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Refs: https://github.com/nodejs/node/commit/902998190a55d6915b881936f6dd5b6e9cca6ad8 Cherry-pick 0a25ace9 Original commit message: tools: move cpplint configuration to .cpplint PR-URL: https://github.com/nodejs/node/pull/27098 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Refs: https://github.com/nodejs/node/commit/0a25ace9c35b62ece4d32fd90b326d8063265109 Cherry-pick afa9a720 Original commit message: tools: refloat update link to google styleguide for cpplint This commit updates two old links to Google's C++ styleguide which currently result in a 404 when accessed. PR-URL: https://github.com/nodejs/node/pull/30876 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Refs: https://github.com/nodejs/node/commit/afa9a7206c26a29a2af226696c145c924a6d3754 Cherry-pick e23bf8f7 Original commit message: tools,src: refloat forbid usage of v8::Persistent `v8::Persistent` comes with the surprising catch that it requires manual cleanup. `v8::Global` doesn’t, making it easier to use, and additionally provides move semantics. New code should always use `v8::Global`. PR-URL: https://github.com/nodejs/node/pull/31018 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> PR-URL: https://github.com/nodejs/node/pull/35569 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35719 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35866
-
Rich Trott authored
https://github.com/cpplint/cpplint/releases/tag/1.5.1 PR-URL: https://github.com/nodejs/node/pull/35866 Reviewed-By:
-
- Nov 02, 2020
-
-
Anna Henningsen authored
Remove deprecated APIs (and deprecate one legacy API). PR-URL: https://github.com/nodejs/node/pull/35897 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
- Nov 01, 2020
-
-
Ben Turner authored
Passing strings to `crypto.createSecretKey` was not added until v15.0.0 (specifically with commit dae283d9). The existing documentation implies its availability in prior versions which may cause confusion. PR-URL: https://github.com/nodejs/node/pull/35874 Reviewed-By:
-
Ben Noordhuis authored
It's been ten years and it's time for a change. September 30 was my last day at IBM and my last day as a full-time Node.js maintainer. I feel Deno is the future and that's why I'm joining that scrappy startup, Deno Land Inc., to make that future happen. PR-URL: https://github.com/nodejs/node/pull/35865 Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
-
Daijiro Wachi authored
Refs: https://github.com/web-platform-tests/wpt/pull/9361 PR-URL: https://github.com/nodejs/node/pull/35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By:
-
Daijiro Wachi authored
The AbortController abort event should have EventTarget as a target property of the argument event. PR-URL: https://github.com/nodejs/node/pull/35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35901 Reviewed-By:
-
cjihrig authored
Update ESLint to 7.12.1 PR-URL: https://github.com/nodejs/node/pull/35799 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
cjihrig authored
Update ESLint to 7.12.0 PR-URL: https://github.com/nodejs/node/pull/35799 Reviewed-By:
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/34895 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/34895 Reviewed-By:
-
- Oct 31, 2020
-
-
tyankatsu authored
Add test pattern to setImmediate when ref's type is not boolean PR-URL: https://github.com/nodejs/node/pull/35852 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
This commit renames the check function to createJob which seems to be more descriptive of what this function does. PR-URL: https://github.com/nodejs/node/pull/35858 Reviewed-By:
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35610 Reviewed-By:
-
Myles Borins authored
This is consistently failing in CI right now. Lets mark it flaky while we figure out what is going on. Refs: https://github.com/nodejs/node/issues/35844 PR-URL: https://github.com/nodejs/node/pull/35886 Reviewed-By:
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/35830 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
legendecas authored
instead of emit async init with receiver of the callback. PR-URL: https://github.com/nodejs/node/pull/32930 Fixes: https://github.com/nodejs/node/issues/32898 Reviewed-By:
-
Myles Borins authored
This is now failing inconsistently across many platforms. This appears to be the result of the addition of mustSucceed being added to the test during testing refactoring. We should mark flaky until we have figured out what the issue is. Refs: https://github.com/nodejs/node/issues/35881 PR-URL: https://github.com/nodejs/node/pull/35883 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35747 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
- Oct 30, 2020
-
-
Michaël Zasso authored
This adds support for the new logical assignment operators. PR-URL: https://github.com/nodejs/node/pull/35827 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Tobias Nießen authored
The W3C testharness.js was moved to the `web-platform-tests/wpt` repository a while ago. PR-URL: https://github.com/nodejs/node/pull/35814 Reviewed-By:
-
Takuya Noguchi authored
Signed-off-by:
Takuya Noguchi <takninnovationresearch@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35804 Reviewed-By:
-
Rich Trott authored
In email, ronkorving indicated that he could/should be moved to emeritus at this time. PR-URL: https://github.com/nodejs/node/pull/35828 Reviewed-By:
Ron Korving <ron@ronkorving.nl> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/35840 Reviewed-By:
-
Antoine du Hamel authored
This is to unsure that code using those methods won't crash if the methods are deleted in userland. PR-URL: https://github.com/nodejs/node/pull/35837 Reviewed-By:
-
James M Snell authored
Fixes a handful of regressions in scrypt support following the refactor. Fixes: https://github.com/nodejs/node/issues/35815 PR-URL: https://github.com/nodejs/node/pull/35821 Reviewed-By:
-
Antoine du Hamel authored
The documentation style guide used to recommend checking changes in the docs by running `make lint-md`. This leaves out some important checks which are contained in the `test-doc` build target. This commit also replaces `lint` by `lint-md` in the list of `test-doc`'s prerequisites. PR-URL: https://github.com/nodejs/node/pull/35708 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/35708 Reviewed-By:
-
Antoine du Hamel authored
Add a build target to lint JS code in Markdown files only. PR-URL: https://github.com/nodejs/node/pull/35708 Reviewed-By:
-
Filip Skokan authored
This fixes the importKey operation when importing a JWK for the ECDH algorithm. As per the Web Crypto API specification the JWK `alg` property is not checked (as opposed to ECDSA). PR-URL: https://github.com/nodejs/node/pull/35855 Fixes: https://github.com/nodejs/node/issues/35812 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/35813 Reviewed-By:
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/35735 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35871 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
- Oct 29, 2020
-
-
Daijiro Wachi authored
Increase test coverage of lib/internal/policy/manifest.js PR-URL: https://github.com/nodejs/node/pull/35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
Myles Borins authored
These features are being used in production and are ready to be considered stable. Refs: https://github.com/nodejs/modules/issues/564 PR-URL: https://github.com/nodejs/node/pull/35742 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
-
Myles Borins authored
I've had to update this one too many times, and much of it can be automated, so let's do that! The maintenance instructions have also been updated. PR-URL: https://github.com/nodejs/node/pull/35822 Reviewed-By:
-
Chris Opperwall authored
The `node-inspect` debugging client supports passing an optional third parameter as a string to be evaluated when the breakpoint is hit. If the condition evaluates to `true` in the current context, the breakpoint pauses execution; otherwise the execution continues. This was raised as an issue in https://github.com/nodejs/node-inspect/issues/68, but the client already supports that functionality, so I thought it'd be helpful to add it to the node documentation. PR-URL: https://github.com/nodejs/node/pull/35823 Reviewed-By:
-
- Oct 27, 2020
-
-
Daijiro Wachi authored
Refs: https://github.com/web-platform-tests/wpt/pull/25988 Refs: https://github.com/web-platform-tests/wpt/pull/26158 PR-URL: https://github.com/nodejs/node/pull/35794 Reviewed-By:
-
