- Apr 15, 2020
-
-
Robert Nagy authored
Remove nesting in favor of early returns. PR-URL: https://github.com/nodejs/node/pull/32801 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/32797#discussion_r407222290 PR-URL: https://github.com/nodejs/node/pull/32798 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Anna Henningsen authored
Suggest using `--trace-warnings` or `--trace-deprecation` the first time a warning is emitted without a stack trace, similar to how we suggest `--trace-uncaught` when printing uncaught exceptions without a stack trace. PR-URL: https://github.com/nodejs/node/pull/32797 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Jesus Hernandez authored
PR-URL: https://github.com/nodejs/node/pull/32727 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Robert Nagy authored
Ensure that the socket is not destroyed when the 'end' event is emitted. Refs: https://github.com/nodejs/node/pull/32780#issuecomment-612602551 PR-URL: https://github.com/nodejs/node/pull/32794 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Notable changes: New file system APIs: * Added a new function, `fs.readv` (with sync and promisified versions). This function takes an array of `ArrayBufferView` elements and will write the data it reads sequentially to the buffers (Sk Sajidul Kadir). https://github.com/nodejs/node/pull/32356 * A new overload is available for `fs.readSync`, which allows to optionally pass any of the `offset`, `length` and `position` parameters. https://github.com/nodejs/node/pull/32460 Other changes: * dns: * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4 mapped IPv6 addresses (murgatroid99). https://github.com/nodejs/node/pull/32183 * http: * The default maximum HTTP header size was changed from 8KB to 16KB (rosaxny). https://github.com/nodejs/node/pull/32520 * n-api: * Calls to `napi_call_threadsafe_function` from the main thread can now return the `napi_would_deadlock` status in certain circumstances (Gabriel Schulhof). https://github.com/nodejs/node/pull/32689 * util: * Added a new `maxStrLength` option to `util.inspect`, to control the maximum length of printed strings. Its default value is `Infinity` (rosaxny). https://github.com/nodejs/node/pull/32392 * worker: * Added support for passing a `transferList` along with `workerData` to the `Worker` constructor (Juan José Arboleda). https://github.com/nodejs/node/pull/32278 New core collaborators: With this release, we welcome three new Node.js core collaborators: * himself65. https://github.com/nodejs/node/pull/32734 * flarna (Gerhard Stoebich). https://github.com/nodejs/node/pull/32620 * mildsunrise (Alba Mendez). https://github.com/nodejs/node/pull/32525 PR-URL: https://github.com/nodejs/node/pull/32813
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/26401#issuecomment-613095719 PR-URL: https://github.com/nodejs/node/pull/32826 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/29802 Refs: https://github.com/nodejs/node/pull/32595 PR-URL: https://github.com/nodejs/node/pull/32825 Reviewed-By:
-
- Apr 14, 2020
-
-
Reşat SABIQ authored
PR-URL: https://github.com/nodejs/node/pull/32591 Fixes: https://github.com/nodejs/node/issues/32559 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Julian Duque authored
PR-URL: https://github.com/nodejs/node/pull/32751 Reviewed-By:
Adrian Estrada <edsadr@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
Currently, the following warnings are emitted during compilation: In file included from ../src/string_bytes.h:29, from ../src/string_bytes.cc:22: ../deps/v8/include/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak( P*,typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::BaseObject; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)]’: ../src/base_object-inl.h:135:42: required from here ../deps/v8/include/v8.h:10732:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<node::BaseObject>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type] 10732 | reinterpret_cast<Callback>(callback), type); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ And the same from test/cctest/test_aliased_buffer.cc We have an open pull request against v8 for this: https://chromium-review.googlesource.com/c/v8/v8/+/2080361 PR-URL: https://github.com/nodejs/node/pull/32679 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Yash Ladha authored
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well. PR-URL: https://github.com/nodejs/node/pull/32665 Reviewed-By:
-
Anna Henningsen authored
Add a configure flag that enables building V8 with `-DDEBUG`, in particular with debug checks enabled and with runtime debugging features, e.g. inspecting JS objects from debuggers, enabled. PR-URL: https://github.com/nodejs/node/pull/32787 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32788 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
cjihrig authored
This commit moves the last experimental feature of diagnostic reports to stable status. PR-URL: https://github.com/nodejs/node/pull/32496 Reviewed-By:
-
Michael Dawson authored
Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by:
Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32721 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com>
-
James M Snell authored
For http2 (and eventually QUIC) we have a struct that is backed by a v8::BackingStore and exposed to the JavaScript side as an ArrayBuffer and TypedArray. This is similar to AliasedBuffer except that it is fronted by a struct on the C++ side. ```c++ struct foo { uint32_t ex1; uint32_t ex2; }; AliasedStruct<foo> foo_; foo_->ex1 = 1; foo_->ex2 = 2; foo_.GetArrayBuffer(); ``` Signed-off-by: -
Matheus Marchini authored
clang's linker seems to use considerably less memory than gcc, allowing us to run on Actions without running out of memory. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32776 Reviewed-By:
-
Matheus Marchini authored
Signed-off-by:
-
Cecchi MacNaughton authored
The example referenced as being potentially unsafe specifies Content-Length correctly. PR-URL: https://github.com/nodejs/node/pull/32700 Reviewed-By:
-
Gerhard Stoebich authored
Add a type check in bidirectionalIndexOf to avoid using something else as Buffer. This may happen if e.g. lastIndexOf is called with invalid this. PR-URL: https://github.com/nodejs/node/pull/32770 Fixes: https://github.com/nodejs/node/issues/32753 Fixes: https://github.com/nodejs/node/issues/32747 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
unknown authored
Refs: https://github.com/nodejs/node/pull/32392 PR-URL: https://github.com/nodejs/node/pull/32744 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Anna Henningsen authored
Avoid storing data that depends on command line options on internal bindings. This is generally a cleaner way of accessing CLI options. PR-URL: https://github.com/nodejs/node/pull/32760 Reviewed-By:
-
Anna Henningsen authored
This removes a footgun in which users could attempt to transfer the pooled ArrayBuffer underlying a regular `Buffer`, which would lead to all `Buffer`s that share the same pool being rendered unusable as well, and potentially break creation of new pooled `Buffer`s. This disables this kind of transfer. Refs: https://github.com/nodejs/node/issues/32752 PR-URL: https://github.com/nodejs/node/pull/32759 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32757 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32749 Reviewed-By:
-
Harshitha KP authored
Fixes: https://github.com/nodejs/node/issues/22139 Co-authored-by:
Mritunjay Goutam <mritunjaygoutam2204@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32703 Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/31950 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/31950 Reviewed-By:
-
John Kleinschmidt authored
Fixes: https://github.com/nodejs/build/issues/1931 PR-URL: https://github.com/nodejs/node/pull/32129 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
John Kleinschmidt authored
Git for Windows includes `C:\Program Files\Git\bin\bash.exe`, which spawns ..\usr\bin\bash.exe, so copying that executable won't work. However, if a symlink is used to test paths with spaces, this executable will still work. PR-URL: https://github.com/nodejs/node/pull/32129 Reviewed-By:
-
- Apr 13, 2020
-
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32817 Reviewed-By:
-
Anna Henningsen authored
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: https://github.com/nodejs/node/issues/32742 PR-URL: https://github.com/nodejs/node/pull/32745 Reviewed-By:
-
Robert Nagy authored
Refs: https://github.com/nodejs/node/issues/32764 PR-URL: https://github.com/nodejs/node/pull/32767 Reviewed-By:
-
Jesus Hernandez authored
PR-URL: https://github.com/nodejs/node/pull/32779 Reviewed-By:
-
- Apr 12, 2020
-
-
Beth Griggs authored
Notable changes: Due to release process failures, Node.js v10.20.0 shipped with source and header tarballs that did not properly match the final release commit that was used to build the binaries. We recommend that Node.js v10.20.0 not be used, particularly in any applications using native add-ons or where compiling Node.js from source is involved. Node.js v10.20.1 is a clean release with the correct sources and is strongly recommended in place of v10.20.0. PR-URL: https://github.com/nodejs/node/pull/32768
-
Michaël Zasso authored
This makes the output much smaller and lets us focus on errors if there are any. PR-URL: https://github.com/nodejs/node/pull/32714 Reviewed-By:
-
Juan José Arboleda authored
Replace the obsolete node-test-pull-request-lite-pipeline CI task in favour of node-test-pull-request. PR-URL: https://github.com/nodejs/node/pull/32736 Reviewed-By:
-
- Apr 11, 2020
-
-
Richard Lau authored
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Nimit authored
This adds new section for v8 options and --max-old-space-size Fixes: https://github.com/nodejs/node/issues/32252 PR-URL: https://github.com/nodejs/node/pull/32262 Reviewed-By:
-
