- May 28, 2024
-
-
Jeremy Bennett authored
gas/ * testsuite/gas/riscv/cv-simd-march-fail.l: Update for cv.shuffle.sci.h which should error if more than 2 bits specified for the immediate to match architecture specification. * testsuite/gas/riscv/cv-simd-march-fail.s: Likewise. * testsuite/gas/riscv/cv-simd-march-xcvsimd.d: Likewise. * testsuite/gas/riscv/cv-simd-march-xcvsimd.s: Likewise. * testsuite/gas/riscv/cv-simd-shuffle-sci-h-fail.l: Likewise. * testsuite/gas/riscv/cv-simd-shuffle-sci-h-pass.d: Likewise. * testsuite/gas/riscv/cv-simd-shuffle-sci-h-pass.s: Likewise. opcodes/ * riscv-opc.c: Fix operand constraint for cv.shuffle.sci.h Signed-off-by:Jeremy Bennett <jeremy.bennett@embecosm.com>
-
Jeremy Bennett authored
bfd/ * elfxx-riscv.c: Put CORE-V extensions in alphabetical order. gas/ * testsuite/gas/riscv/march-help.l: Add all CORE-V extensions in alphabetical order. Signed-off-by:
-
- Apr 16, 2024
-
-
Mary Bennett authored
Issues [#104](https://github.com/openhwgroup/corev-binutils-gdb/issues/104), [#96](https://github.com/openhwgroup/corev-binutils-gdb/issues/96) cv.{sll,sra,srl}.sci.{h,b}, cv.extract[u].{h,b}, and cv.insert.{h,b} use 6-bit immediates but sets the top bits as 0. An error has been added to prevent the full 6-bits being set. Files Changed: * gas/config/tc-riscv.c: Add operands `b81`, `b82`, `b83`, `b84`. * opcodes/riscv-dis.c: Likewise. * opcodes/riscv-opc.c: Likewise. * gas/testsuite/gas/riscv/cv-simd-extract-b-fail.l: Update test. * gas/testsuite/gas/riscv/cv-simd-extract-b-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-extract-b-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-extract-b-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-extract-h-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-extract-h-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-extract-h-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-extract-h-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-extractu-b-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-extractu-b-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-extractu-b-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-extractu-b-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-extractu-h-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-extractu-h-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-extractu-h-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-extractu-h-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-insert-b-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-insert-b-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-insert-b-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-insert-b-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-insert-h-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-insert-h-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-insert-h-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-insert-h-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-march-xcvsimd.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-march-xcvsimd.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-sll-sci-b-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-sll-sci-b-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-sll-sci-b-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-sll-sci-b-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-sll-sci-h-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-sll-sci-h-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-sll-sci-h-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-sll-sci-h-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-sra-sci-b-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-sra-sci-b-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-sra-sci-b-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-sra-sci-b-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-sra-sci-h-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-sra-sci-h-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-sra-sci-h-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-sra-sci-h-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-srl-sci-b-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-srl-sci-b-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-srl-sci-b-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-srl-sci-b-pass.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-srl-sci-h-fail.l: Likewise. * gas/testsuite/gas/riscv/cv-simd-srl-sci-h-fail.s: Likewise. * gas/testsuite/gas/riscv/cv-simd-srl-sci-h-pass.d: Likewise. * gas/testsuite/gas/riscv/cv-simd-srl-sci-h-pass.s: Likewise.
-
Jiawei authored
-
Mary Bennett authored
-
Simon Cook authored
This fixes an issue whereby .option arch with the zc extensions can result in gas refusing to accept otherwise valid instructions because the base C extension is not enabled.
-
Jiawei authored
-
Jiawei authored
-
NandniJamnadas authored
Bit manipulation instructions are useful to work on single bits or groups of bits within a word. The cv.bitrev instruction from a bit manipulation perspective without describing it’s application as part of an FFT. The bit reverse instruction will reverse bits in groupings of 1, 2 or 3 bits. bfd/ * elfxx-riscv.c: Added INSN_CLASS_COREV_BITMANIP. gas/config/ * tc-riscv.c: Added b6 for ENCODE_CV_BITMANIP_UIMM5 for unsigned 5-bit immediate and b7 for ENCODE_CV_BITMANIP_UIMM2 for unsigned 2-bit immediate. gas/doc/ * c-riscv.texi: Updated documentation to include COREV bit manipulation version 1 and 2. include/opcode/ * riscv-opc.h: Added corresponding 16 MATCH and MASK macros for bit manipulation. * riscv.h: Added EXTRACT_CV_BITMANIP_UIMM5 EXTRACT_CV_BITMANIP_UIMM2, ENCODE_CV_BITMANIP_UIMM5, ENCODE_CV_BITMANIP_UIMM2. opcodes/ * riscv-dis.c: Added disassemble information for EXTRACT_CV_BITMANIP_UIMM5 and EXTRACT_CV_BITMANIP_UIMM2. * riscv-opc.c: Added 16 instructions to riscv_opcode[]. Signed-off-by:NandniJamnadas <nandni.jamnadas@embecosm.com>
-
NandniJamnadas authored
extension in assembler The SIMD instructions perform operations on multiple sub-word elements at the same time. This is done by segmenting the data path into smaller parts when 8 or 16-bit operations should be performed. The custom SIMD extensions are only supported if PULP_XPULP == 1. bfd/ * elfxx-riscv.c: (riscv_multi_subset_supports): Added INSN_CLASS_XCOREVSIMD. * elfxx-riscv.c: (riscv_multi_subset_supports_ext): Likewise. gas/config/ * tc-riscv.c: (validate_riscv_insn): Added operand code 'b5' for SIMD Imm6 operand. * tc-riscv.c: (riscv_ip): Added signed Imm6 range. include/opcode/ * riscv-opc.h: Added SIMD Match and Mask Macros. * riscv.h: Added EXTRACT_CV_SIMD_IMM6 and ENCODE_CV_SIMD_IMM6. * riscv.h: (riscv_insn_class): Added INSN_CLASS_COREV_SIMD. opcodes/ * riscv-dis.c: (print_insn_args): Disassemble info with EXTRACT_CV_SIMD_IMM6. * riscv-opc.c: Added SIMD Instructions. Signed-off-by: -
Pietra Ferreira authored
Added two relocations REL12 and RELU5, the CORE-V INSN_CLASSes, the MATCH and MASKs and the hardware loop instructions. bfd/ChangeLog: * bfd-in2.h: REGENERATED. * elfnn-riscv.c: Add relocations for CORE-V hardware loop. * elfxx-riscv.c: Add relocations and amend howto lookup. * riscv.c: Add BFD_RELOC_RISCV_CVPCREL_UI12 and BFD_RELOC_RISCV_CVPCREL_URS1. gas/ChangeLog: * config/tc-riscv.c: Add CORE-V harware loop support. * config/tc-riscv.h: Likewise. * doc/c-riscv.texi: Note Xcvhwlp as additional ISA extension for CORE-V.
-
Jessica Mills authored
Spec: https://docs.openhwgroup.org/projects/cv32e40p-user-manual/en/latest/instruction_set_extensions.html Contributors: Mary Bennett <mary.bennett@embecosm.com> Nandni Jamnadas <nandni.jamnadas@embecosm.com> Pietra Ferreira <pietra.ferreira@embecosm.com> Charlie Keaney Jessica Mills Craig Blackmore <craig.blackmore@embecosm.com> Simon Cook <simon.cook@embecosm.com> Jeremy Bennett <jeremy.bennett@embecosm.com> Helene Chelin <helene.chelin@embecosm.com> bfd/ChangeLog: * elfxx-riscv.c (riscv_multi_subset_supports): Add `xcvmem` instruction class. (riscv_multi_subset_supports_ext): Likewise. gas/ChangeLog: * doc/c-riscv.texi: Note XCVmem as an additional ISA extension for CORE-V. * testsuite/gas/riscv/cv-mem-fail-march.d: New test. * testsuite/gas/riscv/cv-mem-fail-march.l: New test. * testsuite/gas/riscv/cv-mem-fail-march.s: New test. * testsuite/gas/riscv/cv-mem-fail-operand-01.d: New test. * testsuite/gas/riscv/cv-mem-fail-operand-01.l: New test. * testsuite/gas/riscv/cv-mem-fail-operand-01.s: New test. * testsuite/gas/riscv/cv-mem-fail-operand-02.d: New test. * testsuite/gas/riscv/cv-mem-fail-operand-02.l: New test. * testsuite/gas/riscv/cv-mem-fail-operand-02.s: New test. * testsuite/gas/riscv/cv-mem-fail-operand-03.d: New test. * testsuite/gas/riscv/cv-mem-fail-operand-03.l: New test. * testsuite/gas/riscv/cv-mem-fail-operand-03.s: New test. * testsuite/gas/riscv/cv-mem-fail-operand-04.d: New test. * testsuite/gas/riscv/cv-mem-fail-operand-04.l: New test. * testsuite/gas/riscv/cv-mem-fail-operand-04.s: New test. * testsuite/gas/riscv/cv-mem-fail-operand-05.d: New test. * testsuite/gas/riscv/cv-mem-fail-operand-05.l: New test. * testsuite/gas/riscv/cv-mem-fail-operand-05.s: New test. * testsuite/gas/riscv/cv-mem-lbpost.d: New test. * testsuite/gas/riscv/cv-mem-lbpost.s: New test. * testsuite/gas/riscv/cv-mem-lbrr.d: New test. * testsuite/gas/riscv/cv-mem-lbrr.s: New test. * testsuite/gas/riscv/cv-mem-lbrrpost.d: New test. * testsuite/gas/riscv/cv-mem-lbrrpost.s: New test. * testsuite/gas/riscv/cv-mem-lbupost.d: New test. * testsuite/gas/riscv/cv-mem-lbupost.s: New test. * testsuite/gas/riscv/cv-mem-lburr.d: New test. * testsuite/gas/riscv/cv-mem-lburr.s: New test. * testsuite/gas/riscv/cv-mem-lburrpost.d: New test. * testsuite/gas/riscv/cv-mem-lburrpost.s: New test. * testsuite/gas/riscv/cv-mem-lhpost.d: New test. * testsuite/gas/riscv/cv-mem-lhpost.s: New test. * testsuite/gas/riscv/cv-mem-lhrr.d: New test. * testsuite/gas/riscv/cv-mem-lhrr.s: New test. * testsuite/gas/riscv/cv-mem-lhrrpost.d: New test. * testsuite/gas/riscv/cv-mem-lhrrpost.s: New test. * testsuite/gas/riscv/cv-mem-lhupost.d: New test. * testsuite/gas/riscv/cv-mem-lhupost.s: New test. * testsuite/gas/riscv/cv-mem-lhurr.d: New test. * testsuite/gas/riscv/cv-mem-lhurr.s: New test. * testsuite/gas/riscv/cv-mem-lhurrpost.d: New test. * testsuite/gas/riscv/cv-mem-lhurrpost.s: New test. * testsuite/gas/riscv/cv-mem-lwpost.d: New test. * testsuite/gas/riscv/cv-mem-lwpost.s: New test. * testsuite/gas/riscv/cv-mem-lwrr.d: New test. * testsuite/gas/riscv/cv-mem-lwrr.s: New test. * testsuite/gas/riscv/cv-mem-lwrrpost.d: New test. * testsuite/gas/riscv/cv-mem-lwrrpost.s: New test. * testsuite/gas/riscv/cv-mem-sbpost.d: New test. * testsuite/gas/riscv/cv-mem-sbpost.s: New test. * testsuite/gas/riscv/cv-mem-sbrr.d: New test. * testsuite/gas/riscv/cv-mem-sbrr.s: New test. * testsuite/gas/riscv/cv-mem-sbrrpost.d: New test. * testsuite/gas/riscv/cv-mem-sbrrpost.s: New test. * testsuite/gas/riscv/cv-mem-shpost.d: New test. * testsuite/gas/riscv/cv-mem-shpost.s: New test. * testsuite/gas/riscv/cv-mem-shrr.d: New test. * testsuite/gas/riscv/cv-mem-shrr.s: New test. * testsuite/gas/riscv/cv-mem-shrrpost.d: New test. * testsuite/gas/riscv/cv-mem-shrrpost.s: New test. * testsuite/gas/riscv/cv-mem-swpost.d: New test. * testsuite/gas/riscv/cv-mem-swpost.s: New test. * testsuite/gas/riscv/cv-mem-swrr.d: New test. * testsuite/gas/riscv/cv-mem-swrr.s: New test. * testsuite/gas/riscv/cv-mem-swrrpost.d: New test. * testsuite/gas/riscv/cv-mem-swrrpost.s: New test. include/ChangeLog: * opcode/riscv-opc.h: Add corresponding MATCH and MASK macros for XCVmem. * opcode/riscv.h: Add corresponding EXTRACT and ENCODE macros for XCVmem. (enum riscv_insn_class): Add the XCVmem instruction class. opcodes/ChangeLog: * riscv-opc.c: Add XCVmem instructions.
-
Nazareno Bruschi authored
Spec: https://docs.openhwgroup.org/projects/cv32e40p-user-manual/en/latest/instruction_set_extensions.html Contributors: Mary Bennett <mary.bennett@embecosm.com> Nandni Jamnadas <nandni.jamnadas@embecosm.com> Pietra Ferreira <pietra.ferreira@embecosm.com> Charlie Keaney Jessica Mills Craig Blackmore <craig.blackmore@embecosm.com> Simon Cook <simon.cook@embecosm.com> Jeremy Bennett <jeremy.bennett@embecosm.com> Helene Chelin <helene.chelin@embecosm.com> Nazareno Bruschi <nazareno.bruschi@embecosm.com> Lin Sinan include/ChangeLog: * opcode/riscv-opc.h: Add corresponding MATCH and MASK macros for XCVbi. * opcode/riscv.h: Add corresponding EXTRACT and ENCODE macros for XCVbi. (enum riscv_insn_class): Add the XCVbi instruction class. gas/ChangeLog: * config/tc-riscv.c (validate_riscv_insn): Add the necessary operands for the extension. (riscv_ip): Likewise. * doc/c-riscv.texi: Note XCVbi as an additional ISA extension for CORE-V. * testsuite/gas/riscv/cv-bi-beqimm.d: New test. * testsuite/gas/riscv/cv-bi-beqimm.s: New test. * testsuite/gas/riscv/cv-bi-bneimm.d: New test. * testsuite/gas/riscv/cv-bi-bneimm.s: New test. * testsuite/gas/riscv/cv-bi-fail-march.d: New test. * testsuite/gas/riscv/cv-bi-fail-march.l: New test. * testsuite/gas/riscv/cv-bi-fail-march.s: New test. * testsuite/gas/riscv/cv-bi-fail-operand-01.d: New test. * testsuite/gas/riscv/cv-bi-fail-operand-01.l: New test. * testsuite/gas/riscv/cv-bi-fail-operand-01.s: New test. * testsuite/gas/riscv/cv-bi-fail-operand-02.d: New test. * testsuite/gas/riscv/cv-bi-fail-operand-02.l: New test. * testsuite/gas/riscv/cv-bi-fail-operand-02.s: New test. * testsuite/gas/riscv/cv-bi-fail-operand-03.d: New test. * testsuite/gas/riscv/cv-bi-fail-operand-03.l: New test. * testsuite/gas/riscv/cv-bi-fail-operand-03.s: New test. include/ChangeLog: * opcode/riscv-opc.h: Add corresponding MATCH and MASK macros for XCVbi. * opcode/riscv.h: Add corresponding EXTRACT and ENCODE macros for XCVbi. (enum riscv_insn_class): Add the XCVbi instruction class. ld/ChangeLog: * testsuite/ld-riscv-elf/cv-bi-beqimm.d: New test. * testsuite/ld-riscv-elf/cv-bi-beqimm.s: New test. * testsuite/ld-riscv-elf/cv-bi-bneimm.d: New test. * testsuite/ld-riscv-elf/cv-bi-bneimm.s: New test. * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Add new tests. opcodes/ChangeLog: * riscv-dis.c (print_insn_args): Add disassembly for new operand. * riscv-opc.c: Add XCVbi instructions.
-
NandniJamnadas authored
Spec: https://docs.openhwgroup.org/projects/cv32e40p-user-manual/en/latest/instruction_set_extensions.html Contributors: Mary Bennett <mary.bennett@embecosm.com> Nandni Jamnadas <nandni.jamnadas@embecosm.com> Pietra Ferreira <pietra.ferreira@embecosm.com> Charlie Keaney Jessica Mills Craig Blackmore <craig.blackmore@embecosm.com> Simon Cook <simon.cook@embecosm.com> Jeremy Bennett <jeremy.bennett@embecosm.com> Helene Chelin <helene.chelin@embecosm.com> bfd/ChangeLog: * elfxx-riscv.c (riscv_multi_subset_supports): Add `xcvelw` instruction class. (riscv_multi_subset_supports_ext): Likewise. gas/ChangeLog: * doc/c-riscv.texi: Note XCVelw as an additional ISA extension for CORE-V. * testsuite/gas/riscv/cv-elw-fail.d: New test. * testsuite/gas/riscv/cv-elw-fail.l: New test. * testsuite/gas/riscv/cv-elw-fail.s: New test. * testsuite/gas/riscv/cv-elw-fail-march.d: New test. * testsuite/gas/riscv/cv-elw-fail-march.l: New test. * testsuite/gas/riscv/cv-elw-fail-march.s: New test. * testsuite/gas/riscv/cv-elw-pass.d: New test. * testsuite/gas/riscv/cv-elw-pass.s: New test. opcodes/ChangeLog: * riscv-opc.c: (riscv_opcode) Add event load instructions. include/ChangeLog: * opcode/riscv-opc.h: Add corresponding MATCH and MASK instruction opcode macros. * opcode/riscv.h (riscv_insn_class): Add INSN_CLASS_XCVELW.
-
Nick Clifton authored
PR 31255
-
Simon Cook authored
-
GDB Administrator authored
-
Tom Tromey authored
commit bdcd50f9 ("Strip trailing newlines from input string") introduced a crash in eof-exit.exp. This patch fixes the problem by adding a NULL check in the appropriate spot. Regression tested on x86-64 Fedora 38. I'm checking this in.
-
Tom Tromey authored
I noticed that add_using_directive's 'copy_names' parameter is only used by a single caller. This patch removes the parameter and changes that caller to copy the names itself. I chose to use intern here since I suspect the names may well be repeated in a given objfile. Approved-By:John Baldwin <jhb@FreeBSD.org>
-
John Baldwin authored
This includes both the i386 and x86-64 architectures.
-
- Apr 15, 2024
-
-
Nick Clifton authored
PR 31527
-
Tom Tromey authored
commit e8cd90f0 ("Rewrite gdb_bfd_error_handler") broke the clang build. The problem here is that print_error_callback isn't marked as being printf-like, but it calls string_file::vprintf, triggering: ../../binutils-gdb/gdb/gdb_bfd.c:1202:18: error: format string is not a string literal [-Werror,-Wformat-nonliteral] This patch applies the attribute to this function. It also removes the attribute from gdb_bfd_error_handler, because that function is no longer really printf-like.
-
Vijay Shankar authored
When mapping sections to segments ensure that we do not add sections whose VMA->LMA relationship does not match the relationship of earlier sections in the segment. PR 31540
-
Tom Tromey authored
The mingw build currently issues a warning: ./../../src/gdb/utils.h:378:56: warning: ignoring attributes on template argument 'void(const char*, va_list)' {aka 'void(const char*, char*)'} [-Wignored-attributes] This patch fixes the problem as suggested by Simon: https://sourceware.org/pipermail/gdb-patches/2024-April/207908.html ...that is, by changing the warning interceptor to a class with a single 'warn' method. Approved-By:Simon Marchi <simon.marchi@efficios.com>
-
Tom Tromey authored
A co-worker noticed a strange situation where "target remote" would fail due to a trailing newline in the address part of the command. Eventually he tracked this down to the fact that he was pasting the command into the terminal, and due to bracketed paste mode, the newline was being preserved by readline. It seems to me that we basically never want a trailing newline on a gdb command, so this patch removes it when handling the readline result. Co-Authored-By:
Kévin Le Gouguec <legouguec@adacore.com> Approved-By:
Luis Machado <luis.machado@arm.com> Tested-By:
-
Christophe Lyon authored
This patch fixes 'install-dvi'.
-
Bernd Edlinger authored
There was apparently a confusion which cpu model uses compressed JAL and which ADDIW. Fixed that in execute_c, case MATCH_C_JAL | MATCH_C_ADDIW. Fixes 3224e32f ("sim: riscv: Add support for compressed integer instructions") Approved-By:
Andrew Burgess <aburgess@redhat.com>
-
Bernd Edlinger authored
Various gcc test cases fail due to the stack alignment of 16 bytes is expected by gcc, causing issues mostly with vararg functions, e.g. FAIL: gcc.c-torture/execute/nest-align-1.c -O0 execution test FAIL: gcc.c-torture/execute/nest-stdar-1.c -O0 execution test FAIL: gcc.c-torture/execute/va-arg-12.c -O0 execution test FAIL: gcc.c-torture/execute/va-arg-15.c -O0 execution test FAIL: gcc.c-torture/execute/va-arg-16.c -O0 execution test FAIL: gcc.c-torture/execute/va-arg-17.c -O0 execution test FAIL: gcc.c-torture/execute/va-arg-20.c -O0 execution test FAIL: gcc.c-torture/execute/va-arg-26.c -O0 execution test ... Approved-By: -
Bernd Edlinger authored
The uncompressed EBREAK instruction does not work correctly this way, and the comment saying that GDB expects us to step over EBREAK is just wrong. The PC was always 4 bytes too high, which skips one instruction at break and step over commands, and causes complete chaos. The compressed EBREAK was already implemented correctly. Tested by using gdb's "target sim" and single-stepping. Approved-By: -
Lulu Cai authored
If we generate an object file using an assembler with the new relocations added, and then linking those files with an older linker, the link will still complete and the linked file will be generated. In this case we should report an error instead of continuing the linking process.
-
GDB Administrator authored
-
- Apr 14, 2024
-
-
GDB Administrator authored
-
- Apr 13, 2024
-
-
GDB Administrator authored
-
Pedro Alves authored
Currently, when the current thread is running, you can print global variables. However, if you try to set a watchpoint on the same globals, GDB errors out, complaining that the selected thread is running. Like so: (gdb) c& Continuing. (gdb) p global $1 = 1098377287 (gdb) watch global Selected thread is running. This patch makes setting the watchpoint work. You'll now get: (gdb) c& Continuing. (gdb) [New Thread 0x7ffff7d6e640 (LWP 434993)] [New Thread 0x7ffff756d640 (LWP 434994)] p global $1 = 88168 (gdb) watch global Hardware watchpoint 2: global (gdb) [Switching to Thread 0x7ffff7d6e640 (LWP 434993)] Thread 2 "function0" hit Hardware watchpoint 2: global Old value = 185420 New value = 185423 int_return () at threads.c:39 39 } The problem is that update_watchpoint calls get_selected_frame unconditionally. We can skip it if the watchpoint expression is only watching globals. This adds a testcase that exercises both all-stop and non-stop, and also software and hardware watchpoints. It is kfailed for software watchpoints, as those require another fix not handled by this patch (the sw watchpoint doesn't fire because GDB doesn't force the running-free thread to switch to single-stepping). Change-Id: I68ca948541aea3edd4f70741f272f543187abe40
-
Pedro Alves authored
Add a new testcase for exercising attaching to a process after its main thread has exited. This is not possible on Linux, the kernel does not allow attaching to a zombie task, so the test is kfailed there. It is possible however on Windows at least, and was the scenario addressed by the Windows backend fix in https://sourceware.org/legacy-ml/gdb-patches/2003-12/msg00479.html, nowadays PR threads/8153, back in 2003. Passes cleanly on Cygwin. KFAILed on GNU/Linux native and gdbserver. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=8153 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31554 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31555 Change-Id: Ib554f92f68c965bb4603cdf2aadb55ca45ded53b
-
Pedro Alves authored
On Cygwin, the gdb.base/fork-no-detach-follow-child-dlopen.exp testcase hits a sequence of cascading FAILs: (gdb) run Starting program: ..../gdb.base/fork-no-detach-follow-child-dlopen/fork-no-detach-follow-child-dlopen [New Thread 12672.0x318c] [New Thread 12672.0x2844] [New Thread 12672.0x714] FAIL: gdb.base/fork-no-detach-follow-child-dlopen.exp: runto: run to add (timeout) frame FAIL: gdb.base/fork-no-detach-follow-child-dlopen.exp: frame (timeout) list FAIL: gdb.base/fork-no-detach-follow-child-dlopen.exp: list (timeout) And the test program never makes progress. ... and at this point, Cygwin is completely stuck. I can't run any other Cygwin program. However, if we run the test program outside DejaGnu, we see something different: (gdb) b add Function "add" not defined. Make breakpoint pending on future shared library load? (y or [n]) y Breakpoint 1 (add) pending. (gdb) r Starting program: ..../gdb.base/fork-no-detach-follow-child-dlopen/fork-no-detach-follow-child-dlopen [New Thread 10968.0x834] [New Thread 10968.0x29a4] [New Thread 10968.0x16b8] [New Thread 10968.0xf9c] [Switching to Thread 10968.0x16b8] Thread 4 "sig" hit Breakpoint 1.2, pending_signals::add (pack=..., this=0x7ffa1e748a40 <sigq>) at /usr/src/debug/cygwin-3.4.9-1/winsup/cygwin/sigproc.cc:1304 1304 se = sigs + pack.si.si_signo; (gdb) Ah, the test wanted to run to a global "add" function, but managed to stop at an internal Cygwin method called "add". And stopping there deadlocks everything Cygwin in the system. (I believe some cygwin1.dll mechanisms use cross-process synchronization or communication, we're probably blocking something like that.) Fix this by using "break -q". The tests FAIL because we don't support follow-fork for Cygwin, but at least we no longer deadlock the machine. Approved-by:Kevin Buettner <kevinb@redhat.com> Change-Id: I7181d8481c2ae1024b0d73e3bb194f9a4f0a7eb9
-
Andrew Burgess authored
After my recent changes the data-directory build now uses silent-rules.mk to reduce the output. One problem that remains was the use of mkinstalldirs by stamp-python and stamp-guile for creating some directories, the mkinstalldirs prints some messages, so we're left with output like this: GEN stamp-python mkdir -p -- ./python/gdb mkdir -p -- ./python/gdb/command mkdir -p -- ./python/gdb/dap mkdir -p -- ./python/gdb/function mkdir -p -- ./python/gdb/printer I was looking at adding a --silent option to the mkinstalldirs script, however, when I took a look at the automake package (which is where mkinstalldirs comes from) it turns out that mkinstalldirs is deprecated, at the advice is to use 'install-sh -d' instead. Just like we carry mkinstalldirs in the top-level directory, we also carry install-sh, and a version of install-sh which supports the -d flag. And best of all, 'install-sh -d' doesn't appear to print any of the information messages to stdout that mkinstalldirs does, so if we switch to use that, we get a quieter build. There should be no changes in what is built after this commit Approved-By:Tom Tromey <tom@tromey.com>
-
- Apr 12, 2024
-
-
Nick Clifton authored
PR 31255
-
H.J. Lu authored
* gen-sframe.c (sframe_xlate_ctx_cleanup): Call XDELETE on xlate_ctx->cur_fre. (create_sframe_all): Call XDELETE on xlate_ctx after use.
-
GDB Administrator authored
-
