Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e9917693

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Don't invalidate ExtModule ports in an explicitInvalidate = true context (#2795)

* Don't invalidate ExtModule ports in an explicitInvalidate = true context

ExtModule ports were previously invalidated in the emitted FIRRTL, which is correct in a NonStrict / `Chisel._` compatibility context but not in newer chisel3 code where `explicitInvalidate = true`.

(cherry picked from commit 8e24a281

)

# Conflicts:
#	core/src/main/scala/chisel3/BlackBox.scala
#	src/test/scala/chiselTests/ExtModule.scala
#	src/test/scala/chiselTests/aop/InjectionSpec.scala

* Resolve backport conflicts

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

Referenced to: chipsalliance/chisel3#2728

(cherry picked from commit a4dae9c3

)

Co-authored-by: Marco Origlia <30799310+moriglia@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Add a cookbook and publicly visible scaladoc for prefix, noPrefix (#2687)

* Add a cookbook and publicly visible scaladoc for prefix, noPrefix

(cherry picked from commit ae7dc30b

)

# Conflicts:
#	docs/src/cookbooks/naming.md

* fix backport conflict

* Update docs/src/cookbooks/naming.md

* Update docs/src/cookbooks/naming.md

Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Improve CI sentinel job for better branch protection (#2743)

Previously, failed jobs in the CI matrix would cause the sentinel job
(all-tests-passed) to be skipped, which for purposes of Github Actions
branch protection would count as "success". This allowed PRs with
failing CI to be merged. This new approach which uses two sentinel jobs
should not suffer from this same issue.

(cherry picked from commit cc507a84

)

# Conflicts:
#	.github/workflows/test.yml

* Resolve backport conflicts

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Publish unidoc as ScalaDoc in chisel project (#2595)

This makes it such that we can stop hosting ScalaDoc on the Chisel
website, instead just pointing to the latest docs on javadoc.io

(cherry picked from commit 8b9f3d78

)

# Conflicts:
#	build.sbt

* Resolve backport conflicts

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Support Vecs of empty Bundles (#2543)

(cherry picked from commit a1e3a6b5

)

* Handle differences between Chisel 3.4 and 3.5

Also a minor difference in Scala 2.11

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 52165fe2

)

Co-authored-by: Lucheng Zhang <79909456+geekLucian@users.noreply.github.com>

Loosen restrictions on clocks to enable them to be connected to
DontCare, i.e., be invalidated.

Co-authored-by: Jack Koenig <koenig@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 5d8a0c8e

)

# Conflicts:
#	core/src/main/scala/chisel3/Clock.scala

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit 2c2d72ce

)

# Conflicts:
#	src/main/scala/chisel3/util/BlackBoxUtils.scala
#	src/main/scala/chisel3/util/ExtModuleUtils.scala

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>

(cherry picked from commit d6a357d2

)

Co-authored-by: Megan Wachs <megan@sifive.com>

(cherry picked from commit 98fdfc5e

)

Co-authored-by: Megan Wachs <megan@sifive.com>

* Fix variable-name typo (#2397)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 01575574

)

# Conflicts:
#	core/src/main/scala/chisel3/internal/Builder.scala

* Update Builder.scala

Co-authored-by: Tynan McAuley <tynan@galois.com>
Co-authored-by: Jiuyang Liu <liu@jiuyang.me>

(cherry picked from commit 055a8529

)

Co-authored-by: John Ingalls <43973001+ingallsj@users.noreply.github.com>

* Better documentation for := and <> (#2312)

(cherry picked from commit 3d5ae7eb

)

* Update interfaces-and-connections.md

Co-authored-by: Olushola Ogunkelu <77856859+Shorla@users.noreply.github.com>
Co-authored-by: Megan Wachs <megan@sifive.com>

preserves input/output information of the type being reduced.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 55cb5887

)

Co-authored-by: Øyvind Harboe <oyvind.harboe@zylin.com>

* catch None.get in BitPat.apply(x: UInt): BitPat (#2276)

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 849d4a0b

)

# Conflicts:
#	src/test/scala/chiselTests/util/BitPatSpec.scala

* Resolve backport conflicts

Remove BitPatSpec since this backport is just a simple require.

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
Co-authored-by: Jack Koenig <koenig@sifive.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 2e2c7c08

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

Remove the body from the emitted Verilog. This was the original intent
of the example, and it avoids an issue where Jekyll was not able to
render the Markdown file due to Verilog concatenation looking like a
variable escape.

(cherry picked from commit e85bfebb

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

* [docs] add minimizing output bits recipe (#2278)

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 12ed3fe9

)

* Docs fix for Chisel 3.4.x

Co-authored-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

Include plugin in instructions since it will be required in 3.5.
Also make sure the example actually works.

(cherry picked from commit cdb02ea4

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Add field grouping ScalaDoc for other subclasses of Bundle  (#2214)

* Add field grouping scaladocs for DecoupledIo

* Added groupdesc to DecoupledIO

* Added groupings for IrrevocableIO

* Add groupings for ValidIO

* Add field grouping scaladoc for PRNGIO

* Add field grouping scaladoc for QueueIO

* Added groupings for PipeIO

* Update src/main/scala/chisel3/util/Decoupled.scala

Commited Sugestion

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update src/main/scala/chisel3/util/Decoupled.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update src/main/scala/chisel3/util/Decoupled.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update src/main/scala/chisel3/util/Decoupled.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update src/main/scala/chisel3/util/Decoupled.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update src/main/scala/chisel3/util/Valid.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update src/main/scala/chisel3/util/Valid.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update src/main/scala/chisel3/util/Valid.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

Co-authored-by: Megan Wachs <megan@sifive.com>
(cherry picked from commit a79f5756

)

# Conflicts:
#	src/main/scala/chisel3/util/Decoupled.scala

* Fix merge conflicts (#2235)

* Fix merge conflicts

* Added removed bracket

Co-authored-by: Abongwa Bonalais <81782853+Burnleydev1@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Update Arbiter.scala

* Update src/main/scala/chisel3/util/Arbiter.scala

changed group name

Co-authored-by: Megan Wachs <megan@sifive.com>

* minor changes on grouping ArbiterIO

* removed unmatched closing brace

* Remove groupdesc from Arbiter.scala

* Added groupdesc to Aggregate.scala

* Update Arbiter.scala

* Update core/src/main/scala/chisel3/Aggregate.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update Arbiter.scala

* Update src/main/scala/chisel3/util/Arbiter.scala

Added suugestions.

Co-authored-by: Megan Wachs <megan@sifive.com>

* added suggestions from review

* added suggestions from review

* Resolved conflicts

* update Arbiter.scala

* Update core/src/main/scala/chisel3/Aggregate.scala

deleted groudesc for ArbiterIO

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update Scaladoc syntax

* removed some lines

* Better documentation

* Removed @param and @gen

* Update core/src/main/scala/chisel3/Aggregate.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update src/main/scala/chisel3/util/Arbiter.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Added groupdesc to ArbiterIO

* Update src/main/scala/chisel3/util/Arbiter.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update core/src/main/scala/chisel3/Aggregate.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update Arbiter.scala

* Update src/main/scala/chisel3/util/Arbiter.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update Arbiter.scala

Co-authored-by: Megan Wachs <megan@sifive.com>
(cherry picked from commit 61455123

)

Co-authored-by: Abongwa Bonalais <81782853+Burnleydev1@users.noreply.github.com>

Previously, the example had an extra wrapping module that led
to the interesting example getting optimized away.

(cherry picked from commit 84da5fdb

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Update bundles-and-vecs.md

* Update docs/src/explanations/bundles-and-vecs.md

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update naming.md

Added a title to the cookbook

* Add name to Multiple Clock Domain page

* Update multi-clock.md

Co-authored-by: Megan Wachs <megan@sifive.com>
(cherry picked from commit 9c026fd3

)

Co-authored-by: Shorla <77856859+Shorla@users.noreply.github.com>

* Update computeName and callsites (#2192)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit d6907893

)

# Conflicts:
#	core/src/main/scala/chisel3/internal/Builder.scala

* Mergify/bp/3.4.x/pr-2192 Deprecate computeName (#2198)

* Fix merge conflict
* Restore public API for computeName and deprecate it
* Build waiver

Co-authored-by: Aditya Naik <91489422+adkian-sifive@users.noreply.github.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

* Update docs README with instructions for new pages

* Update docs/README.md

(cherry picked from commit 7931172c

)

Co-authored-by: Megan Wachs <megan@sifive.com>

* Update bundles-and-vecs.md

* Update docs/src/explanations/bundles-and-vecs.md

Co-authored-by: Megan Wachs <megan@sifive.com>

Co-authored-by: Megan Wachs <megan@sifive.com>
(cherry picked from commit ce8e4207

)

Co-authored-by: Shorla <77856859+Shorla@users.noreply.github.com>

* Update experimental-features.md

Added title to Experimental features

* Update experimental-features.md

* Update docs/src/appendix/experimental-features.md

Co-authored-by: Megan Wachs <megan@sifive.com>

Co-authored-by: Megan Wachs <megan@sifive.com>
(cherry picked from commit 463a352e

)

Co-authored-by: Abongwa Bonalais <81782853+Burnleydev1@users.noreply.github.com>

* Added title

* Update docs/src/explanations/blackboxes.md

Co-authored-by: Megan Wachs <megan@sifive.com>

Co-authored-by: Megan Wachs <megan@sifive.com>
(cherry picked from commit d06ba691

)

Co-authored-by: Abongwa Bonalais <81782853+Burnleydev1@users.noreply.github.com>

* Update developer documentation in README (#2160)

(cherry picked from commit 3643b7ba

)

# Conflicts:
#	README.md

* Update README.md

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Added title to "Namimg Cookbook" website.

Co-authored-by: Megan Wachs <megan@sifive.com>
(cherry picked from commit 2439974e

)

Co-authored-by: Abongwa Bonalais <81782853+Burnleydev1@users.noreply.github.com>

* Remove all Bundle cloneTypes and chiselRuntimeDeprecate its use (#2052)

* Remove all manual cloneTypes and make it chisel runtime deprecated to add one
* runtime deprecate cloneType with runtime reflection
* [Backport this commit] Bundle: add check that override def cloneType still works (will be made an error later)
* Plugin: make it an error to override cloneType and add a test for that
* Docs: can't compile the cloneType anymore
* BundleSpec: comment out failing test I cannot get to fail or ignore

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit ce15ad50)

# Conflicts:
#	src/test/scala/chiselTests/BundleSpec.scala

* BundleSpec: fix merge conflict and change test to check that it does compile with a cloneType, just a warning not an error

* Downgrade warning to error

* restore import that is still needed on the backport

* Put bac...

* Turn on fatal warnings in mdoc documentation (#2146)

(cherry picked from commit df76831c

)

# Conflicts:
#	build.sbt

* Resolve merge conflicts

Co-authored-by: Jack Koenig <koenig@sifive.com>

Close #2138

(cherry picked from commit 7360c815

)

Co-authored-by: Nick <handnf@gmail.com>

Also update binary compatibility checking to 3.4.4

(cherry picked from commit 1ae18008

)

Co-authored-by: Adam Izraelevitz <adam.izraelevitz@sifive.com>

* Fix a bug causes incorrect pla generation when input is `?` (backport #2113) (#2118)Add a test case to demonstrate the bug found in #2112

(cherry picked from commit 89679a3c)

* Test case rework

(cherry picked from commit 0ca4ce23)

* Fix #2112, handle `?->1` case

(cherry picked from commit 189da982

)

* Remove trailing comma

Co-authored-by: mergify-bot <noreply@mergify.io>
Co-authored-by: Jack Koenig <koenig@sifive.com>

* Update sbt installation instructions

The bintray reference is dead.

* fix grammar

(cherry picked from commit ff1bcb09

)

Co-authored-by: Martin Schoeberl <martin@jopdesign.com>

Previous incomplete fixes in #2023 and #2031.

The legality of a FIRRTL connection is determined by type and flow.
Chisel does not have access to true flow information. Previous fix
attempts tried to use ActualDirection as a stand-in for flow, but it is
incorrect in many cases. This new approach checks the flows of the
lvalue and rvalues in the connect and flips the connection if either
the lvalue cannot be a sink or the rvalue cannot be a source.

(cherry picked from commit 7fb2c1eb

)

Co-authored-by: Jack Koenig <koenig@sifive.com>