Unverified Commit 6d794802 authored by mergify[bot]'s avatar mergify[bot] Committed by GitHub
Browse files

~Remove all Bundle cloneTypes and~ chiselRuntimeDeprecate its use (backport #2052) (#2151)



* Remove all Bundle cloneTypes and chiselRuntimeDeprecate its use (#2052)

* Remove all manual cloneTypes and make it chisel runtime deprecated to add one
* runtime deprecate cloneType with runtime reflection
* [Backport this commit] Bundle: add check that override def cloneType still works (will be made an error later)
* Plugin: make it an error to override cloneType and add a test for that
* Docs: can't compile the cloneType anymore
* BundleSpec: comment out failing test I cannot get to fail or ignore

Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
(cherry picked from commit ce15ad50

)

# Conflicts:
#	src/test/scala/chiselTests/BundleSpec.scala

* BundleSpec: fix merge conflict and change test to check that it does compile with a cloneType, just a warning not an error

* Downgrade warning to error

* restore import that is still needed on the backport

* Put back override def cloneType

* Checkpoint -- tests pass but with more errors than one would expect

* Bundle Spec: tests still passing despite throwing runtime deprecation errors

* BundleSpec: clean up some assertTesterPasses so I can check they don't have the runtime exception

* bundles-and-vecs: docs now more strict about warnings

* BundleSpec:  stop trying to test plugin things because 2.11 doesn't use plugin

Co-authored-by: default avatarMegan Wachs <megan@sifive.com>
parent 6e7d1c59
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment