- Jul 18, 2021
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/39402 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Jul 17, 2021
-
-
Rich Trott authored
This (along with a corresponding PR for the TSC repo) moves the strategic initiatives from the TSC repository to the main core repo. This will increase visibility for strategic initiatives. It will also facilitate the proposed reduced centrality of TSC champions to strategic plans. In the process, I made the text less wordy. I moved the Build Resources initiatve out of the active list, as discussed at the most recent TSC meeting. I alphabetized the table entries. (Chronological order isn't obvious to a reader if no dates are provided.) Refs: https://github.com/nodejs/TSC/issues/962#issuecomment-880233678 PR-URL: https://github.com/nodejs/node/pull/39394 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
hemanth.hm authored
Unflags top-level await for the REPL by enabling --experimental-repl-await by default. Opt-out is supported via --no-experimental-repl-await. PR-URL: https://github.com/nodejs/node/pull/34733 Reviewed-By:
Guy Bedford <guybedford@gmail.com>
-
Rich Trott authored
Sometimes we capitalize _pull request_ and sometimes we don't. Standardize on lowercase based on Microsoft Style Guide, Chicago Manual of Style, and GitHub's own docs and UI. Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request Refs: https://docs.microsoft.com/en-us/style-guide/capitalization PR-URL: https://github.com/nodejs/node/pull/39384 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
- Jul 16, 2021
-
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/39386 Refs: https://github.com/nodejs/node/pull/39361 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Daniel Bevenius authored
This commit sets SSL_OP_ALLOW_CLIENT_RENEGOTIATION for OpenSSL 3.0 as this option is not set by default as it was in previous versions. Without this option set there are a few tests that fail when linked against OpenSSl 3.0.0-alpha-17, for example test-https-client-renegotiation-limit.js. I'm not sure we should be setting this for OpenSSL 3.0 or not, but I'll take a closer look at the implications but if nothing else this would allow for us to update to alpha-17 in the mean time. PR-URL: https://github.com/nodejs/node/pull/38753 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39383 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Daniel Bevenius authored
This commit add the contents that should go into the docker-node and build issues when doing a security release. PR-URL: https://github.com/nodejs/node/pull/39215 Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Daniel Bevenius authored
This commit adds instructions for adding machine-readable json files to the security-wg repo in the security release guide. PR-URL: https://github.com/nodejs/node/pull/39220 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Sometimes we capitalize _collaborator_ and sometimes not. After consulting the Microsoft Style Guide and The Chicago Manual of Style, I've concluded it is best to not capitalize it. For consistency, apply that to our various .md files. Refs: https://docs.microsoft.com/en-us/style-guide/capitalization PR-URL: https://github.com/nodejs/node/pull/39379 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
All other files in `lib/internal` do not start with `_`. For consistency, move `lib/internal/debugger/_inspect.js` to `lib/internal/debugger/inspect.js`. PR-URL: https://github.com/nodejs/node/pull/39378 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
Makes the FileHandle::ClosePromise() idempotent, always returning the same Promise after it has already been successfully called once. Avoids the possibility of accidental double close events. Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39331 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39331 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
James M Snell authored
Adds an experimental `readableWebStream()` method to `FileHandle` that returns a web `ReadableStream` Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39331 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
- Jul 15, 2021
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/39175 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39391 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
legendecas authored
Add `process.setSourceMapsEnabled` to enable source-maps programmatically. PR-URL: https://github.com/nodejs/node/pull/39085 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39367 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
commit-lint.yml uses setup-node@v1 but all our other GitHub Actions use v2. Update commit-lint.yml. PR-URL: https://github.com/nodejs/node/pull/39366 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39348 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
James M Snell authored
Experimental as part of the web streams implementation Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39347 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
- Jul 14, 2021
-
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/38334 Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Rich Trott authored
In email, John-David Dalton confirmed that it was appropriate to move to emeritus at this time. PR-URL: https://github.com/nodejs/node/pull/39380 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
GitHub Action workflows can be told to clone a certain number of commits or else everything. Change find-inactive-collaborators to take a number of commits to examine rather than a date range so that the parameter can be used in GitHub Actions. PR-URL: https://github.com/nodejs/node/pull/39362 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Rich Trott authored
find-inactive-collaborators.mjs works fine with Node.js 16.x, but GitHub Actions currently use 14.x by default. PR-URL: https://github.com/nodejs/node/pull/39362 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Robert Nagy authored
Refs: https://github.com/nodejs/node/issues/39356 PR-URL: https://github.com/nodejs/node/pull/39364 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Robert Nagy authored
Adds readableDidRead to streams and applies usage to http, http2 and quic. PR-URL: https://github.com/nodejs/node/pull/36820 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Michaël Zasso authored
Notable changes: deps: * upgrade npm to 7.19.1 (npm team) https://github.com/nodejs/node/pull/39225 fs: * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) https://github.com/nodejs/node/pull/39028 stream: * (SEMVER-MINOR) implement Web Streams API (James M Snell) https://github.com/nodejs/node/pull/39062 PR-URL: https://github.com/nodejs/node/pull/39373
-
himself65 authored
GYP uses the system path when parsing node.gyp; However, if system python is different from our gyp runtime python, like '2.7', gyp would crash. Co-authored-by:
Michaël Zasso <targos@protonmail.com> PR-URL: https://github.com/nodejs/node/pull/39293 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Rich Trott authored
For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file. PR-URL: https://github.com/nodejs/node/pull/39358 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
* Replace _PR_ with Pull Request * Make some content more concise PR-URL: https://github.com/nodejs/node/pull/39359 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
James M Snell authored
Fixup the definitions of the properties to avoid the possibility of prototype polution on the object definitions. Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39371 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
James M Snell authored
Experimental adapters for the webstreams API Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39134 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
- Jul 13, 2021
-
-
James M Snell authored
Refs: https://github.com/nodejs/node/issues/39368 Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39369 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/39351 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/39352 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Danielle Adams authored
PR-URL: https://github.com/nodejs/node/pull/39186 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Rich Trott authored
This also changes a line in the man page to be sentence case. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/special-characters PR-URL: https://github.com/nodejs/node/pull/39345 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/special-characters PR-URL: https://github.com/nodejs/node/pull/39344 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Rich Trott authored
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/bits-bytes-terms PR-URL: https://github.com/nodejs/node/pull/39343 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-