- Dec 07, 2017
-
-
Anatoli Papirovski authored
Instead of callback bound apply, instead use the standard Reflect.apply. This is both safer and appears to offer a slight performance benefit. PR-URL: https://github.com/nodejs/node/pull/17456 Refs: https://github.com/nodejs/node/issues/12956 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
IHsuan authored
PR-URL: https://github.com/nodejs/node/pull/17247 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Anatoli Papirovski authored
Remove length prop on NextTickQueue class. We technically don't need to keep track of the length of the queue in two places as we already have tickInfo doing that work (between the index & the length we have enough data for everything). Store asyncId in a const within the _tickCallback function. Accessing Symbol properties seems to be quite a bit more expensive than string keys so this actually has a decent performance impact. PR-URL: https://github.com/nodejs/node/pull/17421 Reviewed-By:
-
cjihrig authored
Refs: https://github.com/nodejs/node/pull/17427 PR-URL: https://github.com/nodejs/node/pull/17501 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
If fill() attempts to write a string to a buffer, but fails silently, then uninitialized memory could be leaked. This commit causes fill() to throw if the string write operation fails. Refs: https://github.com/nodejs/node/issues/17423 PR-URL: https://github.com/nodejs/node/pull/17427 Reviewed-By:
-
Mithun Sasidharan authored
PR-URL: https://github.com/nodejs/node/pull/17459 Reviewed-By:
-
- Dec 06, 2017
-
-
Mithun Sasidharan authored
PR-URL: https://github.com/nodejs/node/pull/17437 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Anna Henningsen authored
Original commit message: [platform] Return task runners as shared_ptr At the moment, task runners are returned as unique_ptr. This is inconvenient, however. In all implementations I did, the platform holds a shared pointer of the task runner and wraps it in a wrapper class just to return it as a unique_ptr. With this CL the platform API is changed to return a shared_ptr directly. R=rmcilroy@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ide278db855199ea239ad0ae14d97fd17349dac8c Reviewed-on: https://chromium-review.googlesource.com/768867 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49366} Refs: https://github.com/v8/v8/commit/98c40a4bae915a9762c73de3307300c61e4fd91a PR-URL: https://github.com/nodejs/node/pull/17134 Fixes: https://github.com/nodejs/node-v8/issues/24 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Anna Henningsen authored
Original commit message: [platform] Add TaskRunner to the platform API With the existing platform API it is not possible to post foreground tasks from background tasks. This is, however, required to implement asynchronous compilation for WebAssembly. With this CL we add the concept of a TaskRunner to the platform API. The TaskRunner contains all data needed to post a foreground task and can be used both from a foreground task and a background task. Eventually the TaskRunner should replace the existing API. In addition, this CL contains a default implementation of the TaskRunner. This implementation has tempory workaround for platforms which do not provide a TaskRunner implementation yet. This default implementation should be deleted again when all platforms provide a TaskRunner implementation. R=rmcilroy@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I6ea4a1c9da1eb9a19e8ce8f2163000dbc2598802 Reviewed-on: https://chromium-review.googlesource.com/741588 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Franziska Hinkelmann authored
Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example https://github.com/nodejs/node/pull/13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: https://github.com/nodejs/node/pull/16294 Reviewed-By:
-
Marja Hölttä authored
V8 has changed their invalid UTF-8 handling. See https://chromium-review.googlesource.com/c/v8/v8/+/671020 for more info PR-URL: https://github.com/nodejs/node/pull/16271 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Peter Marshall authored
V8 changed the typed array threshold option from a runtime flag to a compile-time option. PR-URL: https://github.com/nodejs/node/pull/16271 Reviewed-By:
-
Sergei Datsenko authored
It is required by a change in V8. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/598666 PR-URL: https://github.com/nodejs/node/pull/16271 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.3. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/16271 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/16271 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/16271 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/17452 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Rich Trott authored
common.hasMultiLocalhost() uses common.PORT under the hood. This is problematic in parallel tests because another test using port 0 to get an arbitrary open port may end up getting common.PORT before the test using common.PORT gets it. Therefore, change common.PORT to port 0 in common.hasMultiLocalhost(). PR-URL: https://github.com/nodejs/node/pull/17466 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17464 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17464 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17464 Reviewed-By:
-
Rich Trott authored
The module introduction includes some uninformative text and some repetitive text. Edit for clarity and brevity. PR-URL: https://github.com/nodejs/node/pull/17463 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Rich Trott authored
"On <operating system>" is used everywhere in this file except for one use of "In <operating system>". Standardize to "On". PR-URL: https://github.com/nodejs/node/pull/17463 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17463 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17463 Reviewed-By:
-
Rich Trott authored
Add settings to test-benchmark-dgram such that it only runs benchmark per benchmark file. PR-URL: https://github.com/nodejs/node/pull/17462 Reviewed-By:
-
jopann authored
PR-URL: https://github.com/nodejs/node/pull/17462 Reviewed-By:
-
XadillaX authored
Fix this issue follow these two points: 1. Keep track of how many queries are currently open. If `setServers()` is called while there are open queries, error out. 2. For `Resolver` instances, use option 1. For dns.setServers(), just create a fresh new default channel every time it is called, and then set its servers list. PR-URL: https://github.com/nodejs/node/pull/14891 Fixes: https://github.com/nodejs/node/issues/14734 Reviewed-By:
-
Rich Trott authored
Make sure each benchmark file only runs one combination of options. Allow for zero iterations for short benchmark. PR-URL: https://github.com/nodejs/node/pull/17472 Reviewed-By:
-
Mithun Sasidharan authored
PR-URL: https://github.com/nodejs/node/pull/17438 Reviewed-By:
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/17445 Reviewed-By:
-
Anna Henningsen authored
Keep track of C++ `TryCatch` state to avoid aborting when an exception is thrown inside one, and re-throw in JS to make sure the exception is being picked up a second time by a second uncaught exception handler, if necessary. Add a bit of a hack to `AppendExceptionLine` to avoid overriding the line responsible for re-throwing the exception. PR-URL: https://github.com/nodejs/node/pull/17394 Fixes: https://github.com/nodejs/node/issues/13258 Reviewed-By:
-
Anna Henningsen authored
This is unnecessary since we only run `AppendExceptionLine()` once per exception at this point anyway. PR-URL: https://github.com/nodejs/node/pull/17394 Reviewed-By:
-
Gibson Fahnestock authored
Notable Changes: - **console**: - avoid adding infinite error listeners (Matteo Collina) [#16770](https://github.com/nodejs/n de/pull/16770) - **http2**: - improve errors thrown in header validation (Joyee Cheung) [#16718](https://github.com/nodej s/node/pull/16718) PR-URL: https://github.com/nodejs/node/pull/17204
-
Franziska Hinkelmann authored
Update return type of `Init` function in documentation to match `napi_addon_register_func` signature. Return type used to be `void`, now it is `napi_value`. PR-URL: https://github.com/nodejs/node/pull/17424 Reviewed-By:
-
Mithun Sasidharan authored
PR-URL: https://github.com/nodejs/node/pull/17439 Reviewed-By:
-
Rich Trott authored
`common.mustCall()` and `common.mustCallAtLeast()` need to be called before process exit handlers to work because checks are done inside a process exit handler. Detect if being used inside a process exit handler and throw. PR-URL: https://github.com/nodejs/node/pull/17453 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
- Dec 05, 2017
-
-
Myles Borins authored
Notable Changes: * build: - fix npm install with --shared (Ben Noordhuis) https://github.com/nodejs/node/pull/16438 * build: - building with python 3 is now supported (Emily Marigold Klassen) https://github.com/nodejs/node/pull/16058 * src: - v8 options can be specified with either '\_' or '-' in NODE_OPTIONS (Sam Roberts) https://github.com/nodejs/node/pull/14093 PR-URL: https://github.com/nodejs/node/pull/17180 -
Anna Henningsen authored
Zero-fill when `Buffer.alloc()` receives invalid fill data. A solution like https://github.com/nodejs/node/pull/17427 which switches to throwing makes sense, but is likely a breaking change. This suggestion leaves the behaviour of `buffer.fill()` untouched, since any change to it would be a breaking change, and lets `Buffer.alloc()` check whether any filling took place or not. PR-URL: https://github.com/nodejs/node/pull/17428 Refs: https://github.com/nodejs/node/pull/17427 Refs: https://github.com/nodejs/node/issues/17423 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17428 Reviewed-By:
-
