Commits · efd16672185e85611d995eec36474eaf1fed39cc · github.com / v8-riscv / node

Jul 19, 2020

src: avoid strcmp in SecureContext::Init · efd16672

Tobias Nießen authored Jul 12, 2020

PR-URL: https://github.com/nodejs/node/pull/34329


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

efd16672

tls: remove setMaxSendFragment guards · e3f8dc16

Tobias Nießen authored Jul 12, 2020

Refs: https://github.com/nodejs/node-v0.x-archive/pull/6900
Refs: https://github.com/nodejs/node-v0.x-archive/issues/6889

PR-URL: https://github.com/nodejs/node/pull/34323


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

e3f8dc16

src: refactor CertCbDone to avoid goto statement · a6ba8dee

Tobias Nießen authored Jul 12, 2020

PR-URL: https://github.com/nodejs/node/pull/34325


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

a6ba8dee

doc: add changes metadata to TLS newSession event · 9cbfabac

Tobias Nießen authored Jul 10, 2020

Refs: https://github.com/nodejs/node/issues/33715

PR-URL: https://github.com/nodejs/node/pull/34294


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

9cbfabac

doc: introduce a triager role · 193dfa94

Gireesh Punathil authored Jul 10, 2020

The role helps triaging issue backlogs effectively
Fixes: https://github.com/nodejs/node/issues/34054
Refs: https://github.com/nodejs/TSC/pull/891

PR-URL: https://github.com/nodejs/node/pull/34295


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

193dfa94

doc: strengthen suggestion in errors.md · 0c81cade

Rich Trott authored Jul 15, 2020

Sure, I'm advocating for permitting second-person pronouns in a current
PR, but the use in errors.md is superfluous and weakens the sentence.
Remove it.

PR-URL: https://github.com/nodejs/node/pull/34390


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

0c81cade

Jul 18, 2020

src: snapshot node · 7a447bcd

Joyee Cheung authored Apr 22, 2020

This runs `lib/internal/bootstrap/node.js` before creating
the builtin snapshot and deserialize the loaders from the
snapshot in deserialization mode.

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

7a447bcd

lib: initialize instance members in class constructors · b1c3909b

Joyee Cheung authored Jul 14, 2020

Since V8 snapshot does not currently support instance member
initialization, initialize them in ordianry class constructors
for now so that these classes can be included in the snapshot.
This may be reverted once
https://bugs.chromium.org/p/v8/issues/detail?id=10704
is fixed and backported.

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

b1c3909b

bootstrap: build fast APIs in pre-execution · f8bde7ce

Joyee Cheung authored Jun 23, 2020

Fast APIs need to work with ArrayBuffers which we need
to rebuild connections to after deserializing them
from the snapshot. For now, postpone their creation
until pre-execution to simplify the process.

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

f8bde7ce

src: reset zero fill toggle at pre-execution · c943cb48

Joyee Cheung authored May 07, 2020

The connection between the JS land zero fill toggle and the
C++ one in the NodeArrayBufferAllocator gets lost if the toggle
is deserialized from the snapshot, because V8 owns the underlying
memory of this toggle. This resets the connection at pre-execution.

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

c943cb48

src: snapshot loaders · 0b8ae5f2

Joyee Cheung authored Apr 21, 2020

This runs `lib/internal/bootstrap/loaders.js` before creating
the builtin snapshot and deserialize the loaders from the
snapshot in deserialization mode.

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

0b8ae5f2

src: make code cache test work with snapshots · 7ecb2858

Joyee Cheung authored Apr 22, 2020

Keep track of snapshotted modules in JS land, and move
bootstrap switches into StartExecution() so that
they are not included into part of the environment-independent
bootstrap process.

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

7ecb2858

src: snapshot Environment upon instantiation · 1faf6f45

Joyee Cheung authored Apr 21, 2019

This includes the initial Environment (without running bootstrap
scripts) into the builtin snapshot

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

1faf6f45

tools: enable Node.js command line flags in node_mksnapshot · f0453876

Joyee Cheung authored Apr 30, 2020

Pass the flags down to node_mksnapshot so that we can use them
when generating the snapshot (e.g. to debug or enable V8 flags)

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

f0453876

src: add an ExternalReferenceRegistry class · ef9964f4

Joyee Cheung authored Apr 20, 2019

Add an ExternalReferenceRegistry class for registering static
external references.

To register the external JS to C++ references created in a binding
(e.g. when a FunctionTemplate is created):

- Add the binding name (same as the id used for `internalBinding()`
  and `NODE_MODULE_CONTEXT_AWARE_INTERNAL`) to
  `EXTERNAL_REFERENCE_BINDING_LIST` in `src/node_external_reference.h`.
- In the file where the binding is implemented, create a registration
  function to register the static C++ references (e.g. the C++
  functions in `v8::FunctionCallback` associated with the function
  templates), like this:

  ```c++
  void RegisterExternalReferences(
          ExternalReferenceRegistry* registry) {
    registry->Register(cpp_func_1);
  }
  ```
- At the end of the file where `NODE_MODULE_CONTEXT_AWARE_INTERNAL` is
  also usually called, register the registration function with

  ```
  NODE_MODULE_EXTERNAL_REFERENCE(binding_name,
                                 RegisterExternalReferences);
  ```

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

ef9964f4

src: split the main context initialization from Environemnt ctor · 404302ff

Joyee Cheung authored Apr 20, 2020

So that it's possible to create an Environment not yet attached
to any V8 context. We'll use this to deserialize the V8 context
before attaching an Environment to it.

PR-URL: https://github.com/nodejs/node/pull/32984


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

404302ff

Jul 17, 2020

test: do not write to fixtures dir in test-watch-file · d379b000

Rich Trott authored Jul 14, 2020

Switch to tmpDir rather than fixtures for file writing.

PR-URL: https://github.com/nodejs/node/pull/34376


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

d379b000

benchmark,test: remove output from readable-async-iterator benchmark · d10c59fc

Rich Trott authored Jul 17, 2020

Extra output makes test-benchmark-streams fail. Change console.log() to
console.assert().

Fixes: https://github.com/nodejs/node/issues/34409

PR-URL: https://github.com/nodejs/node/pull/34411


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

d10c59fc

stream: refactor lazyLoadPromises · 5aeaff64

rickyes authored Jul 14, 2020

PR-URL: https://github.com/nodejs/node/pull/34354


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

5aeaff64

stream: simpler and faster Readable async iterator · 08e8997d

Robert Nagy authored Jun 23, 2020

Reimplement as an async generator instead of a custom
iterator class.

PR-URL: https://github.com/nodejs/node/pull/34035


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

08e8997d

test: remove common.localhostIPv6 · bf0d82c1

Rich Trott authored Jul 14, 2020

common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: https://github.com/nodejs/node/pull/34373


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

bf0d82c1

net: allow wider regex in interface name · 9cb72930

Stewart Addison authored Jul 14, 2020

Zone IDs on Linux are network interface names. The regex we use to
determine valid IPs does not allow for non-alphanumeric characters
in the zone ID suffix. Some machines (including the RHEL Linux/s390x
machines from Marist) have zone IDs with a '.' character in them
which the regex in net.isIP rejects. This changes the regex.

Ref: https://github.com/nodejs/node/pull/14500



Signed-off-by: Stewart Addison <sxa@uk.ibm.com>

PR-URL: https://github.com/nodejs/node/pull/34364


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

9cb72930

test: fix test-net-pingpong pummel test for non-IPv6 hosts · 54870542

Rich Trott authored Jul 14, 2020

Use `common.hasIPv6` instead of an OS check for more reliable
operation.

PR-URL: https://github.com/nodejs/node/pull/34359


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

54870542

Jul 16, 2020

stream: finished on closed OutgoingMessage · a55b77d2

Robert Nagy authored Jul 11, 2020

finished should invoke callback on closed OutgoingMessage the
same way as for regular streams.

Fixes: https://github.com/nodejs/node/issues/34301

PR-URL: https://github.com/nodejs/node/pull/34313
Fixes: https://github.com/nodejs/node/issues/34274


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

a55b77d2

doc: strengthen wording about fs.access() misuse · d46fc91b

Rich Trott authored Jul 13, 2020

PR-URL: https://github.com/nodejs/node/pull/34352


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

d46fc91b

quic: fixup quic.md · 89453cfc

James M Snell authored Jul 13, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

89453cfc

quic: fixup closing/draining period timing · 4523d4a8

James M Snell authored Jul 13, 2020

When entering the closing or draining periods, servers should wait
three times the current probe timeout before releasing session
state.

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

4523d4a8

quic: properly pass readable/writable constructor options · ed488224
James M Snell authored Jul 10, 2020
```
PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>
```
ed488224

quic: implement QuicSession close as promise · 57c11295

James M Snell authored Jul 10, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

57c11295

quic: cleanup QuicClientSession constructor · 8e5c5b16

James M Snell authored Jul 10, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

8e5c5b16

quic: use promisified dns lookup · fe4e7e45

James M Snell authored Jul 10, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

fe4e7e45

quic: eliminate "ready"/"not ready" states for QuicSession · 346aeaf8

James M Snell authored Jul 10, 2020

QuicClientSession and QuicServerSessions are now always immediately
ready for use when they are created, so no more need to track
ready state.

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

346aeaf8

quic: implement QuicSocket Promise API, part 2 · 6665dda9

James M Snell authored Jul 10, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

6665dda9

quic: implement QuicSocket Promise API, part 1 · 79c0e892

James M Snell authored Jul 09, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

79c0e892

quic: implement QuicEndpoint Promise API · 53b12f0c

James M Snell authored Jul 09, 2020

This is the start of a conversion over to a fully Promise-centric API
for the QUIC implementation.

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

53b12f0c

quic: handle unhandled rejections on QuicSession · 16b32eae

James M Snell authored Jul 09, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

16b32eae

quic: fixup kEndpointClose · e5d963e2

James M Snell authored Jul 09, 2020

Ensure that the QuicSocket is properly destroyed if the QuicEndpoint
is destroyed directly rather than through QuicSocket destroy

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

e5d963e2

quic: fix endpointClose error handling, document · 9f552df5

James M Snell authored Jul 09, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

9f552df5

quic: restrict addEndpoint to before QuicSocket bind · b80108c0

James M Snell authored Jul 09, 2020

Restricting this to pre-bind keeps things simple

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

b80108c0

quic: use a getter for stream options · 81c01bbd

James M Snell authored Jul 09, 2020

Doesn't need to be a function

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

81c01bbd