Commits · defbc2ed823e77fdbfaa3536e9f9fa6549cebb37 · github.com / v8-riscv / node

Mar 30, 2020

fs: fix fs.read when passing null value · defbc2ed

himself65 authored Mar 25, 2020

PR-URL: https://github.com/nodejs/node/pull/32479


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

defbc2ed

test: fix a typo on test-fs-read-optional-params · fb254d2a

himself65 authored Mar 25, 2020

PR-URL: https://github.com/nodejs/node/pull/32461


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

fb254d2a

test: skip a wasi test on IBMi PASE · 4898c1d4

Xu Meng authored Mar 24, 2020

The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID
is not supported on IBM i PASE.

PR-URL: https://github.com/nodejs/node/pull/32459


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

4898c1d4

worker: runtime error on pthread creation · b6459ec4

Harshitha KP authored Mar 18, 2020

With large number of worker threads pthread
fails with hard assertion.
Instead of hard assertion throw a runtime error.

PR-URL: https://github.com/nodejs/node/pull/32344
Fixes: https://github.com/nodejs/node/issues/32319


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

b6459ec4

lib: removed unused error code · a5e81e72

Yash Ladha authored Mar 25, 2020

PR-URL: https://github.com/nodejs/node/pull/32481


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

a5e81e72

stream: change var to let/const in stream files · 4fc13b01

Saajan authored Mar 12, 2020

PR-URL: https://github.com/nodejs/node/pull/32214


Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

4fc13b01

http: move free socket error handling to agent · 2bf02285

Robert Nagy authored Feb 28, 2020

The http client should not know anything about free sockets. Let
the agent handle its pool of sockets.

PR-URL: https://github.com/nodejs/node/pull/32003


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

2bf02285

test: harden the tick sampling logic · bffc9324

Harshitha KP authored Mar 11, 2020

Under peculiar system load conditions, the profiler thread
does not get enough CPU slices to perform the sampling.
Improve the interaction between worker and parent thread
by performing a large disc read, which is a better blend of
CPU and I/O bound work, than earlier versions.
This produces x10 more samples than the existing one,
in 10 iterations, as opposed to 1024.

Also capture worker error situations to improve debugging

Refs: https://github.com/nodejs/node/issues/26401#issuecomment-597438516

PR-URL: https://github.com/nodejs/node/pull/32190


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

bffc9324

win,build: set exit_code on configure failure · 5e05f8ac

Bartlomiej Brzozowski authored Mar 09, 2020

PR-URL: https://github.com/nodejs/node/pull/32205
Fixes: https://github.com/nodejs/node/issues/31573


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

5e05f8ac

lib: replace Array to ArrayIsArray by primordials · 1bbd679a

himself65 authored Mar 14, 2020

PR-URL: https://github.com/nodejs/node/pull/32258


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1bbd679a

http: don't emit 'readable' after 'close' · e034f5c3

Robert Nagy authored Mar 15, 2020

PR-URL: https://github.com/nodejs/node/pull/32277
Refs: https://github.com/nodejs/node/issues/28710


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

e034f5c3

doc: tests local links in markdown documents · 19db0e60

Antoine du HAMEL authored Mar 19, 2020

PR-URL: https://github.com/nodejs/node/pull/32359


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

19db0e60

test: als variant of test-timers-clearImmediate · bac401c4

Harshitha KP authored Mar 16, 2020

Refs: https://github.com/nodejs/node/issues/31978

PR-URL: https://github.com/nodejs/node/pull/32303


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

bac401c4

test: skip some binding tests on IBMi PASE · b416993c

Xu Meng authored Feb 26, 2020

IBMi PASE Node.js always links to shared openssl
and zlib libraries. So skip the static binding tests.

PR-URL: https://github.com/nodejs/node/pull/31967


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

b416993c

fs: add fs.readv() · 97ef4d76

Sk Sajidul Kadir authored Mar 17, 2020

Fixes: https://github.com/nodejs/node/issues/2298
PR-URL: https://github.com/nodejs/node/pull/32356


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

97ef4d76

util: fix inspecting document.all · 89ae1f1b

Gus Caplan authored Feb 24, 2020

Fixes: https://github.com/nodejs/node/issues/31889

PR-URL: https://github.com/nodejs/node/pull/31938


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

89ae1f1b

benchmark: use let instead of var in zlib · 75aaf749

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

75aaf749

benchmark: use let instead of var in worker · 806899fd

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

806899fd

benchmark: use let instead of var in util · d9a77c64

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

d9a77c64

benchmark: use let instead of var in url · a33e9c9d

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

a33e9c9d

benchmark: use let instead of var in tls · 8ec533d8

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

8ec533d8

benchmark: use let instead of var in timers · de877c57

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

de877c57

benchmark: use let instead of var in run.js · 13ad05ce

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

13ad05ce

benchmark: use let instead of var in dns · a2e70157

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

a2e70157

benchmark: use let instead of var in common.js · e18f5af2

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

e18f5af2

benchmark: use const instead of var in async_hooks · 435fe977

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

435fe977

benchmark: add `no-var` rule in .eslintrc.yaml · d8f44bc2

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

d8f44bc2

src: add test/abort build tasks · e08ac095

Christian Niederer authored Feb 14, 2020

The Aliased*Array overflow check test introduced a dependency to a
compiled artifact. Add this artifact to the build process in a
similar fashion as test/addons and test/js-native-api do.

PR-URL: https://github.com/nodejs/node/pull/31740


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

e08ac095

src: add aliased-buffer-overflow abort test · babeb58c

Christian Niederer authored Feb 12, 2020

Added native extension similar to
test/addons/stringbytes-external-exceeded-max.
Added an abort test to regression test the non overflow behaviour.

PR-URL: https://github.com/nodejs/node/pull/31740


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

babeb58c

src: check for overflow when extending AliasedBufferBase · 8245a781

Christian Niederer authored Feb 11, 2020

When resizing an aliased_buffer check if the new size will overflow.

PR-URL: https://github.com/nodejs/node/pull/31740


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8245a781

doc: fix typo in http2 docs · 575b4e36

Nitin Kumar authored Mar 30, 2020

PR-URL: https://github.com/nodejs/node/pull/32292


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

575b4e36

doc: fix typo in maintaining-zlib guide · 988f5bf6

Nitin Kumar authored Mar 30, 2020

PR-URL: https://github.com/nodejs/node/pull/32292


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

988f5bf6

doc: fix typo in maintaining-openssl guide · be2f36a5

Nitin Kumar authored Mar 30, 2020

PR-URL: https://github.com/nodejs/node/pull/32292


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

be2f36a5

src: unify Linux and FreeBSD large pages implem · 67d5c907

Gabriel Schulhof authored Mar 26, 2020

dl_iterate_phdr(3) is also available for FreeBSD. This change adds the
same trimming code for the start and end of the .text section as on
Linux, making it work on FreeBSD, and removing the need for the
additional FreeBSD-specific check.

Manually tested on
  * https://www.osboxes.org/freebsd/#freebsd-12-1-vbox
  * https://www.osboxes.org/freebsd/#freebsd-11-vbox


  * test-digitalocean-freebsd11-x64-2

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: https://github.com/nodejs/node/pull/32534


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

67d5c907

test: revise test-http-response-multi-content-length · c2637847

Rich Trott authored Mar 27, 2020

Isolate the two test cases here a bit more and refactor code.

PR-URL: https://github.com/nodejs/node/pull/32526


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

c2637847

src: replace handle dereference with ContainerOf · 768b0f54

Harshitha KP authored Mar 16, 2020

this was influenced by https://github.com/nodejs/node/pull/32269

PR-URL: https://github.com/nodejs/node/pull/32298


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

768b0f54

src: remove unused v8 namespace · effebf87

Juan José Arboleda authored Mar 19, 2020

PR-URL: https://github.com/nodejs/node/pull/32375


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

effebf87

doc: fix profile type of --heap-prof-name · 3822cae3

Syohei YOSHIDA authored Mar 21, 2020

V8 CPU profile -> V8 heap profile

PR-URL: https://github.com/nodejs/node/pull/32404


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

3822cae3

doc: use uppercase on windows path · cc8066e0

himself65 authored Mar 16, 2020

PR-URL: https://github.com/nodejs/node/pull/32294


Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

cc8066e0

deps: update acorn to v7.1.1 · 08c656bb

Ruben Bridgewater authored Mar 17, 2020

Also clean up the plugins package.json files.

PR-URL: https://github.com/nodejs/node/pull/32310


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

08c656bb