- Oct 14, 2018
-
-
Danu Widatama authored
Reverse the argument for assertion. The first argument should be the actual value and the second value should be the expected value. When there is an AssertionError, the expected and actual value will be labeled correctly. PR-URL: https://github.com/nodejs/node/pull/23451 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Jared Haines authored
Have actual first, expected second. PR-URL: https://github.com/nodejs/node/pull/23450 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Khalid Adil authored
PR-URL: https://github.com/nodejs/node/pull/23449 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
jungkumseok authored
When using `assert.strictEqual`, the first argument must be the actual value and the second argument must be the expected value. PR-URL: https://github.com/nodejs/node/pull/23448 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
- Oct 13, 2018
-
-
Ali Ijaz Sheikh authored
Minor cleanup in the lifetime for the platform worker initialization synchronization barrier. PR-URL: https://github.com/nodejs/node/pull/23419 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
garrik.leonardo@gmail.com authored
Covering the case when fs-read get invalid argument for file handle PR-URL: https://github.com/nodejs/node/pull/23601 Reviewed-By:
-
David Xue authored
PR-URL: https://github.com/nodejs/node/pull/23455 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Anna Henningsen authored
Original commit message: [api] Remove deprecated wasm methods These methods were deprecated in 7.0, now we can remove them. R=adamk@chromium.org Bug: v8:7868 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I60badb378a055152bdd27aed67d11ddf74fce174 Reviewed-on: https://chromium-review.googlesource.com/1209283 Reviewed-by:Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55695} Refs: https://github.com/v8/v8/commit/b0af30948505b68c843b538e109ab378d3750e37 PR-URL: https://github.com/nodejs/node/pull/23415 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Ben Noordhuis authored
Introduced in commit d3d6cd3e ("src: improve SSL version extraction logic".) PR-URL: https://github.com/nodejs/node/pull/23622 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Shannon authored
strictEqual() expects the first argument to be the actual value and the second argument to be the expected value. This fix will correctly label the AssertionError.: PR-URL: https://github.com/nodejs/node/pull/23577 Reviewed-By:
-
Kayla Altepeter authored
This checks that invalid option throws an error. PR-URL: https://github.com/nodejs/node/pull/23595 Reviewed-By:
-
Anna Henningsen authored
This paves way for making `bytesRead` consistent with all other Node.js streams that provide a property with this name. PR-URL: https://github.com/nodejs/node/pull/23308 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/23307 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/23351 Reviewed-By:
-
Sam Roberts authored
Ref: https://github.com/nodejs/node/pull/23329 PR-URL: https://github.com/nodejs/node/pull/23357 Refs: https://github.com/nodejs/node/pull/23329 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This makes it easier to implement the lookup in a way that targets error codes from a specific compression library, as a way towards supporting multiple ones (e.g. brotli). PR-URL: https://github.com/nodejs/node/pull/23413 Reviewed-By:
-
Anna Henningsen authored
These should no longer be flaky after the libuv update. Refs: https://github.com/nodejs/node/pull/23336 PR-URL: https://github.com/nodejs/node/pull/23356 Reviewed-By:
-
Denys Otrishko authored
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: https://github.com/nodejs/node/pull/23196 Reviewed-By:
-
Denys Otrishko authored
* refactor out usage of 'function' for scoping * wait till server is up to start firing requests PR-URL: https://github.com/nodejs/node/pull/23193 Reviewed-By:
-
Ali Ijaz Sheikh authored
Metadata trace-events should be held in secondary storage so that they can be periodically reemitted. This change establishes the secondary storage and ensures that events are reemitted on each flush. PR-URL: https://github.com/nodejs/node/pull/20900 Reviewed-By:
-
et4891 authored
PR-URL: https://github.com/nodejs/node/pull/23518 Reviewed-By:
-
Joe Sepi authored
PR-URL: https://github.com/nodejs/node/pull/23574 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Rich Trott authored
Change common.ddCommand() to common.createZeroFilledFile(). PR-URL: https://github.com/nodejs/node/pull/23411 Reviewed-By:
George Adams <george.adams@uk.ibm.com>
-
Rich Trott authored
* Remove different paths for Windows and POSIX. * Remove fixtures file. Simply run the command immediately/directly. * Since it is never called with more than one value for kilobytes, eliminate that argument. * Update/simplify tests that use this function. (They no longer need to use child_process to run the command.) * Update documentation. PR-URL: https://github.com/nodejs/node/pull/23411 Reviewed-By:
-
- Oct 12, 2018
-
-
Rich Trott authored
Simplify and clarify the security-reporting text in the README. Now is also probably a good time to ping the security triage folks to make sure the text is still accurate. PR-URL: https://github.com/nodejs/node/pull/23407 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Tobias Nießen authored
This should be a generic type even though we are currently only using `char` as `T`. PR-URL: https://github.com/nodejs/node/pull/23434 Reviewed-By:
-
Gireesh Punathil authored
The openssl version as defined in ssl libraries is complex. The current logic to extract the major.minor.patch format uses C semantics to loop through the text and search for specific patterns. Use C++ string to tidy it up. PR-URL: https://github.com/nodejs/node/pull/23050 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Sagi Tsofan authored
Improved error message description for the http server binding errors. Currently changed only in `setupListenHandle`, but needs to be change all over. Added new `uvExceptionWithHostPort` function (+export) in `lib/internal/error.js` that extracts the error message defined by libuv, using the error code, and returns an error object with the full error description. example: old error message: `listen EADDRINUSE` new error message: `listen EADDRINUSE: Address already in use` Removed exportable function `_exceptionWithHostPort` from `lib/util.js` - exported by accident Replaced `exceptionWithHostPort` to the new function `uvExceptionWithHostPort` for a more detailed error. Fixes: https://github.com/nodejs/node/issues/22936 PR-URL: https://github.com/nodejs/node/pull/22995 Reviewed-By:
-
Vitaly Dyatlov authored
This `_external` getter is essential for some libs to work: uWebSockets as an example. PR-URL: https://github.com/nodejs/node/pull/21711 Reviewed-By:
-
Ouyang Yadong authored
When an instance of StreamWrap is shutting down and a "drain" event is emitted, the instance will abort as its `this[kCurrentShutdownRequest]` is already set. The following test will fail before this commit. PR-URL: https://github.com/nodejs/node/pull/23294 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Daniel Bevenius authored
This commit removes the inclusion of limits.h which was introduced in commit e812be4a ("src: make CLI options programatically accesible"), but as far as I can see it was not used there either so it look like it can safely be removed. PR-URL: https://github.com/nodejs/node/pull/23353 Reviewed-By:
-
Refael Ackermann authored
* ATM on every ICU version bump we need to update these data. Reading it from a file makes it independant of `configre.py` changes. * Update guide. PR-URL: https://github.com/nodejs/node/pull/23269 Refs: https://github.com/nodejs/node/issues/23245 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
-
Rich Trott authored
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: https://github.com/nodejs/node/pull/23358 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23337 Reviewed-By:
-
Rich Trott authored
Rewrite the Consensus Seeking section of the Collaborators Guide for easier reading, more clarity, shorter sentences, less passive voice, etc. PR-URL: https://github.com/nodejs/node/pull/23349 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
- Oct 11, 2018
-
-
Rich Trott authored
To help troubleshoot CI failures, add some logging. Refs: https://github.com/nodejs/node/issues/23277#issuecomment-428819187 PR-URL: https://github.com/nodejs/node/pull/23418 Reviewed-By:
-
Dara Hayes authored
ContextifyContext::CompileFunction in src/node_contextify.cc was incorrectly passing the context variable to ScriptCompiler::CompileFunctionInContext This meant that the parsingContext option in vm.compileFunction was not being applied properly to the compiled function. fixes: https://github.com/nodejs/node/issues/23194 doc: clarify parsingContext option for vm.compileScript test: usage of parsingContext in vm.compileFunction PR-URL: https://github.com/nodejs/node/pull/23206 Fixes: https://github.com/nodejs/node/issues/23194 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/23288 Reviewed-By:
-
conectado authored
Adds a single test for a vm with an indexed property. PR-URL: https://github.com/nodejs/node/pull/23318 Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
This commit extracts the common code in the existing Http2Settings constructors into a private constructor, allowing the existing ones to delegate to the private constructor it and avoid code duplication. PR-URL: https://github.com/nodejs/node/pull/23326 Reviewed-By:
-
