- Jun 22, 2018
-
-
cjihrig authored
This commit validates the file descriptor passed to the TTY wrap's guessHandleType() function. Prior to this commit, a bad file descriptor would trigger an abort in the binding layer. PR-URL: https://github.com/nodejs/node/pull/21429 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Ben Noordhuis authored
Optimize three functions that pass on (part of) their JS arguments to the JS function they call by stack-allocating the storage in the common case. PR-URL: https://github.com/nodejs/node/pull/21409 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Gireesh Punathil authored
calling writeHead() into a Response object that has no headers already set causes getHeader() to return undefined, even if the header was set in the writeHead() function call. Explain this behavior as an optimiation as opposed to a bug. Fixes: https://github.com/nodejs/node/issues/10354 PR-URL: https://github.com/nodejs/node/pull/21289 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
This commit is a suggestion to add a new option to the node executable to allow for breaking in node's javascript bootstrapper code. Previously I've been able to set breakpoints in node bootstrapper code and then restart the debugging session and those breakpoints would be hit, but I don't seem to be able to do so anymore. Having this option would allow me to use this option and then step through or add more break points as needed. PR-URL: https://github.com/nodejs/node/pull/20819 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Christopher Hiller authored
Refs: https://github.com/nodejs/node/pull/18566 PR-URL: https://github.com/nodejs/node/pull/21449 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/21413 Refs: https://github.com/nodejs/node/issues/21219 Reviewed-By:
-
- Jun 21, 2018
-
-
Matheus Marchini authored
Original commit message: [log] improve --perf-basic-prof-only-functions Change --perf-basic-prof-only-functions to also log builtin code creation events, otherwise InterpretedFunctions generated by --interpreted-frames-native-stack will be filtered out. R=yangguo@google.com Change-Id: Ib0623fca88e25c514473a43de56ebbbdcb146f97 Reviewed-on: https://chromium-review.googlesource.com/1100014 Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53760} Refs: https://github.com/v8/v8/commit/5dd33955d5cb1d84dd2509363e11d3c2a PR-URL: https://github.com/nodejs/node/pull/21386 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Jamie Davis authored
If an application has a large RSS (GB), jorangreef observed that child_process.spawn will block the event loop for ms-s. This is surprising behavior and merits documentation. Refs: https://github.com/nodejs/node/issues/14917 PR-URL: https://github.com/nodejs/node/pull/21234 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Masashi Hirano authored
PR-URL: https://github.com/nodejs/node/pull/21286 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Masashi Hirano authored
Added tests to validate process.setgroups() arguments PR-URL: https://github.com/nodejs/node/pull/21286 Reviewed-By:
-
Daniel Bevenius authored
This commit adds examples of specifying filters when running cctest. This can be useful when debugging and limiting the test cases run to the test cases of interest and I think worth documenting. PR-URL: https://github.com/nodejs/node/pull/21401 Reviewed-By:
-
guybedford authored
PR-URL: https://github.com/nodejs/node/pull/21350 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/21430 Reviewed-By:
-
Anna Henningsen authored
When headers are not emitted to JS, e.g. because of an error before that could happen, we currently still have the vector of previously received headers lying around, each one holding a reference count of 1. To fix the resulting memory leak, release them in the `Http2Stream` destructor. Also, clear the vector of headers once they have been emitted – there’s not need to keep it around, wasting memory. PR-URL: https://github.com/nodejs/node/pull/21373 Reviewed-By:
-
Anna Henningsen authored
This was added in 3217e8e6 as a regression test for a security patch. We moved it to `sequential` to lower the risk of creating a flaky test, because an earlier version of it was failing one some platforms. There is no known reason why te test should be flaky in this form, though, and moving it to parallel would be good because it does take around 3 seconds that would otherwise fully count towards the test run time. PR-URL: https://github.com/nodejs/node/pull/21322 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Fix parsing of e.g. `NODE_DEBUG_NATIVE=worker,messaging`. PR-URL: https://github.com/nodejs/node/pull/21422 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/21399 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Notable changes: * **crypto**: * Support for `crypto.scrypt()` has been added. [#20816](https://github.com/nodejs/node/pull/20816) * **fs**: * BigInt support has been added to `fs.stat` and `fs.watchFile`. [#20220](https://github.com/nodejs/node/pull/20220) * APIs that take `mode` as arguments no longer throw on values larger than `0o777`. [#20636](https://github.com/nodejs/node/pull/20636) [#20975](https://github.com/nodejs/node/pull/20975) (Fixes: [#20498](https://github.com/nodejs/node/issues/20498)) * Fix crashes in closed event watchers. [#20985](https://github.com/nodejs/node/pull/20985) (Fixes: [#20297](https://github.com/nodejs/node/issues/20297)) * **Worker Threads**: * Support for multi-threading has been added behind the `--experimental-worker` flag in the `worker_threads` module. This feature is *experimental* and may receive breaking changes at any time. [#20876](https://github.com/nodejs/node/pull/20876) PR-URL: https://github.com/nodejs/node/pull/21400 -
cjihrig authored
Because reasons. PR-URL: https://github.com/nodejs/node/pull/21264 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/21264 Reviewed-By:
-
Kevin Thomas authored
Third string literal argument in assert.strictEqual() needs to be removed. Otherwise, on AssertionError it would not display the values that failed the check -- this hinders debugging. The string literals are added as comments above the check. PR-URL: https://github.com/nodejs/node/pull/21406 Reviewed-By:
-
Joyee Cheung authored
This patch split part of the bootstrappers into three files: - `lib/internal/process/main_thread_only.js`: contains bootstrappers that can only be run in the main thread, including - `setupStdio` for the main thread that sets up `process.stdin`, `process.stdout`, `process.error` that may interact with external resources, e.g. TTY/File/Pipe/TCP sockets - `setupProcessMethods` that setup methods changing process-global states, e.g. `process.chdir`, `process.umask`, `process.setuid` - `setupSignalHandlers` - `setupChildProcessIpcChannel` that setup `process.send` for child processes. - `lib/internal/process/worker_thread_only.js`: contains bootstrappers that can only be run in the worker threads, including - `setupStdio` for the worker thread that are streams to be manipulated or piped to the parent thread - `lib/internal/process/per_thread.js`: contains bootstrappers that can be run in all threads, including: - `setupAssert` for `process.assert` - `setupCpuUsage` for `process.cpuUsage` - `setupHrtime` for `process.hrtime` and `process.hrtime.bigint` - `setupMemoryUsage` for `process.memoryUsage` - `setupConfig` for `process.config` - `setupKillAndExit` for `process.kill` and `process.exit` - `setupRawDebug` for `process._rawDebug` - `setupUncaughtExceptionCapture` for `process.setUncaughtExceptionCaptureCallback` and `process.hasUncaughtExceptionCaptureCallback` Hopefully in the future we can sort more bootstrappers in `boostrap/node.js` into these three files and further group them into functions that can be run before creating the snapshot / after loading the snapshot. This patch also moves most of the `isMainThread` conditionals into the main bootstrapper instead of letting them scattered around special-casing different implementations. PR-URL: https://github.com/nodejs/node/pull/21378 Reviewed-By:Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
- Jun 20, 2018
-
-
cjihrig authored
This is likely the default that more Windows users are expecting. PR-URL: https://github.com/nodejs/node/pull/21316 Refs: https://github.com/libuv/libuv/pull/1878 Refs: https://github.com/nodejs/node/pull/21314 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
James M Snell authored
Set the thread name for workers in trace events. Also, use uint64_t for thread_id_ because there's really no reason for those to be doubles PR-URL: https://github.com/nodejs/node/pull/21246 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/21377 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Yang Guo authored
PR-URL: https://github.com/nodejs/node/pull/21330 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. PR-URL: https://github.com/nodejs/node/pull/21381 Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
-
Rich Trott authored
Check that benchmark tests are not running longer than necessary by confirming that they only produce one set of configs to report on per benchmark file. PR-URL: https://github.com/nodejs/node/pull/21046 Reviewed-By:
-
Rich Trott authored
Move C++ benchmark useful for NAPI to its own directory. This will isolate the benchmark so it can be excluded from testing that applies to all other benchmarks but not this one. PR-URL: https://github.com/nodejs/node/pull/21046 Reviewed-By:
-
Rich Trott authored
Prevent misc benchmark files from running more than one benchmark during tests. PR-URL: https://github.com/nodejs/node/pull/21046 Reviewed-By:
-
- Jun 19, 2018
-
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/18254 PR-URL: https://github.com/nodejs/node/pull/21393 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me>
-
Rich Trott authored
The STYLE_GUIDE indicates that personal pronouns like "you" should be avoided in reference documentation. Remove "you" from N-API doc. PR-URL: https://github.com/nodejs/node/pull/21382 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Jun 18, 2018
-
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/21354 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Brett Kiefer authored
Don't set `writable` to true when a socket connects if the socket is already in an ending state. In the existing code, afterConnect always set `writable` to true. This has been the case for a long time, but previous to commit 9b7a6914, the socket would still be destroyed by `destroySoon` and emit a `'close'` event. Since that commit removed this masking behavior, we have relied on maybeDestroy to destroy the socket when the readble state is ended, and that won't happen if `writable` is set to true. If the socket has `allowHalfOpen` set to true, then `destroy` will still not be called and `'close'` will not be emitted. PR-URL: https://github.com/nodejs/node/pull/21290 Fixes: https://github.com/nodejs/node/issues/21268 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Rich Trott authored
Re-enable `quotes` rule in .eslintrc.js and fix code to abide by the rule. As a bonus, this makes the code (IMO, anyway) more readable. (It certainly isn't *less* readable, at least not IMO.) PR-URL: https://github.com/nodejs/node/pull/21338 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Rich Trott authored
Instead of wording the paragraph about communicating deprecations with the ecosystem as if it were directed at the ecosystem, write it as in imperative directed at the collaborator, since that is the audience for the COLLABORATOR_GUIDE. Instead of assuring the reader that a best effort will be made, instruct the reader to make the effort to communicate with the ecosystem. PR-URL: https://github.com/nodejs/node/pull/21340 Reviewed-By:
-
Rich Trott authored
Remove obsolete wiki references from BUILDING.md. PR-URL: https://github.com/nodejs/node/pull/21369 Reviewed-By:
-
Jamie Davis authored
PR-URL: https://github.com/nodejs/node/pull/21273 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
- Jun 17, 2018
-
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/21256 Reviewed-By:
-
Daniel Bevenius authored
Currently the following compiler warning is reported: ../src/node_stat_watcher.cc:113:13: warning: unused variable 'argc' [-Wunused-variable] const int argc = args.Length(); ^ 1 warning generated. This commit removes the unused argc variable. PR-URL: https://github.com/nodejs/node/pull/21337 Reviewed-By:
-
