- Nov 09, 2018
-
-
mzucker authored
This change was initiated from the NodeConfEU session. PR-URL: https://github.com/nodejs/node/pull/24135 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Musa Hamwala authored
Swapped the actual and expected arguments in `assert.strictEqual()` calls. Arguments are now in correct order. Literal value is now the second argument and the value returned by the function is the first argument. PR-URL: https://github.com/nodejs/node/pull/24134 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
George Adams <george.adams@uk.ibm.com>
-
Petar Dodev authored
PR-URL: https://github.com/nodejs/node/pull/24133 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/24125 Refs: https://github.com/v8/v8/commit/0483e9a9abe77a73632fd85b9c0cd608efa9aa0d Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Joyee Cheung authored
Instead of calling into JS from C++ to push values into an array, use the new Array::New API that takes a pointer and a length directly. PR-URL: https://github.com/nodejs/node/pull/24125 Refs: https://github.com/v8/v8/commit/0483e9a9abe77a73632fd85b9c0cd608efa9aa0d Reviewed-By:
-
Joyee Cheung authored
Original commit message: [api] Allow embedder to construct an Array from Local<Value>* Currently to obtain a v8::Array out of a C array or a std::vector, one needs to loop through the elements and call array->Set() multiple times, and these calls go into v8::Object::Set() which can be slow. This patch adds a new Array::New overload that converts a Local<Value>* with known size into a Local<Array>. Change-Id: I0a768f0e18eec51e78d58be455482ec6425ca188 Reviewed-on: https://chromium-review.googlesource.com/c/1317049 Reviewed-by:Adam Klein <adamk@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#57261} Refs: https://github.com/v8/v8/commit/0483e9a9abe77a73632fd85b9c0cd608efa9aa0d PR-URL: https://github.com/nodejs/node/pull/24125 Reviewed-By:
-
Jimb Esser authored
Lazy load _http_common and HTTPParser so that the 'http_parser' binding can be monkey patched before any internal modules require it. This also probably improves startup performance minimally for programs that never require the HTTP stack. Fixes: https://github.com/nodejs/node/issues/23716 Fixes: https://github.com/creationix/http-parser-js/issues/57 PR-URL: https://github.com/nodejs/node/pull/24006 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
- Nov 08, 2018
-
-
Fran Herrero authored
PR-URL: https://github.com/nodejs/node/pull/24131 Reviewed-By:
-
Tadhg Creedon authored
PR-URL: https://github.com/nodejs/node/pull/24130 Reviewed-By:
-
Joyee Cheung authored
Right now `node -p process.versions.openssl` always gets run in the Makefile even when it's not needed by the target (e.g. `make clean`, `make test-only`). This patch makes it a run time call instead of part of the global expansion. PR-URL: https://github.com/nodejs/node/pull/24115 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Joyee Cheung authored
Instead of calling into C++ each time we need to check the value of a command line option, cache the option map in a new `internal/options` module for faster access to the values in JS land. PR-URL: https://github.com/nodejs/node/pull/24091 Reviewed-By:
-
Daniel Bevenius authored
This commit adds JavaScript modules that depend on crypto to the cannotUseCache array. This is to avoid having them compiled when node has been configured --without-ssl which currently fails. PR-URL: https://github.com/nodejs/node/pull/24100 Reviewed-By:
-
Joyee Cheung authored
Since no operation is requiring process to be an EventEmitter before setupProcessObject is called, it's safe to set up the prototype chain in setupProcessObject and make the main code path more readable. PR-URL: https://github.com/nodejs/node/pull/24089 Reviewed-By:
-
Joyee Cheung authored
Instead of setting the internalBinding white list in node.js and wrapping process.binding twice, put it directly in loaders.js where the user land process.binding is defined. PR-URL: https://github.com/nodejs/node/pull/24088 Reviewed-By:
-
mritunjaygoutam12 authored
PR-URL: https://github.com/nodejs/node/pull/24073 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/23835 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me>
-
Rich Trott authored
Increase the timeouts based on platform. This required adjusting common.platformTimeout() to deal with bigint. Fixes: https://github.com/nodejs/node/issues/24120 PR-URL: https://github.com/nodejs/node/pull/24238 Reviewed-By:
-
chux0519 authored
openSSL supports AEAD_CHACHA20_POLY1305(rfc7539) since 1.1. PR-URL: https://github.com/nodejs/node/pull/24081 Fixes: https://github.com/nodejs/node/issues/24080 Refs: https://tools.ietf.org/html/rfc7539 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24229 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24060 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24060 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24060 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24060 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/24094 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
This is in preparation for a markdown lint rule requiring lines to be wrapped at 80 characters. PR-URL: https://github.com/nodejs/node/pull/24094 Reviewed-By:
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/23975 PR-URL: https://github.com/nodejs/node/pull/24090 Reviewed-By:
-
Rich Trott authored
Simplify text. Add explanation that `code` is the most stable way to identify an error, in contrast with `message` which is subject to change between patch-level versions of Node.js. Synchronize list of properties with text. Order properties alphabetically. PR-URL: https://github.com/nodejs/node/pull/24090 Fixes: https://github.com/nodejs/node/issues/23975 Reviewed-By:
-
- Nov 07, 2018
-
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/24204 Fixes: https://github.com/nodejs/node/issues/24193 Refs: https://github.com/nodejs/node/pull/19723 Reviewed-By:
-
Peter Marshall authored
PR-URL: https://github.com/nodejs/node/pull/24170 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24198 Reviewed-By:
-
- Nov 06, 2018
-
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
Wyatt Preul <wpreul@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24079 Reviewed-By:
-
