- Nov 24, 2015
-
-
Michael Dawson authored
As part of the fix for logjam, node was upgraded to a level of openssl which rejects connections to servers that are using keys smaller than 768 bits. It is still possible, however, to create a server that uses a smaller key size and and older client may be able to connect to it. This PR moves us to a secure by default stance on the server side as well, preventing the creation of a server using a dhe key size less than 768. This can be overridden with the command line option which is also added. It is derived from https://github.com/nodejs/node/commit/9b35be58100237365c24ab394d3dc6462f9675e6 which was landed in later io.js/node versions but makes the limit 1024. This PR uses the smaller limit in order to meet the recomendations for logjam while matching was was done on the client side in openssl to minimize the potential impacton users. The command line option will only be documented in the release notes and will not be added to the tls documentation. The goal is that people who are upgrading are aware and can use the option if they run into issues, but otherwise the option is not visible/used. PR-URL: https://github.com/nodejs/node/pull/3890 Fixes: https://github.com/nodejs/LTS/issues/49 Reviewed-By:
Myles Borins <mborins@us.ibm.com> Reviewed-By:
James Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <r@va.gg> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
- Nov 15, 2015
-
-
Forrest L Norvell authored
This is a roll-up release that includes all changes to npm since 2.13.4. PR-URL: https://github.com/nodejs/node/pull/3684 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Ben Noordhuis authored
Fix the following build error by putting #if guards around the variables: ../src/node.cc: In function 'void node::ParseArgs(int*, const char**, int*, const char***, int*, const char***)': ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared in this scope SSL2_ENABLE = true; ^ ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared in this scope SSL3_ENABLE = true; Fixes: https://github.com/nodejs/node-v0.x-archive/issues/8645 PR-URL: https://github.com/nodejs/node/pull/3825 Reviewed-By:Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
-
- Oct 01, 2015
-
-
Jeremy Whitlock authored
caeb6773 Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes: #8877 Fixes: https://github.com/nodejs/node-v0.x-archive/issues/8877 PR-URL: https://github.com/nodejs/node-v0.x-archive/pull/25835 Reviewed-By:
misterdjules - Julien Gilli <jgilli@nodejs.org>
-
Jeremy Whitlock authored
fbff7054 Add v8::Isolate::SetAbortOnUncaughtException() so the user can be notified when an uncaught exception has bubbled. Fixes: https://github.com/nodejs/node-v0.x-archive/issues/8877 PR-URL: https://github.com/nodejs/node-v0.x-archive/pull/25835 Reviewed-By:
-
- Sep 16, 2015
-
-
João Reis authored
Try the next version of Microsoft Visual Studio when vcvarsall.bat fails to set VCINSTALLDIR. PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Lucien Greathouse authored
This is a port of b0dd3bf4 . Original commit message: Windows 10 wasn't listed in the executable manifest. This caused problems with trying to detect Windows 10 via `os.release()`. PR-URL: https://github.com/nodejs/io.js/pull/2332 Reviewed-By:
Roman Reiss <me@silverwind.io> PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
-
Rod Vagg authored
This is a port of 4208dc4f . Original commit message: PR-URL: https://github.com/nodejs/node/pull/2036 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in https://github.com/nodejs/node-v0.x-archive/pull/25857 PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
-
João Reis authored
To compile with VS2015, the == and != methods in zone-allocator.h need to be marked const. This change was introduced upstream in https://chromium.googlesource.com/v8/v8.git/+/f9e4527f32c2c268cb79428c74ea9703e9db3aec PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
-
Andy Polyakov authored
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429 from openssl upstream, to add support for Visual Studio 2015. This is already included in the newer openssl 1.0.2. Original commit message: e_os.h: limit _MSC_VER trickery to older compilers. PR: #3390 Original pull request: http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390 This was ported to v0.10 in https://github.com/joyent/node/pull/25857 PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
-
Shigeki Ohtsu authored
This is a port of eb459c81 , used as a floating patch over gyp. Original commit message: This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: https://github.com/iojs/io.js/pull/1325 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
-
João Reis authored
This is a port of a525c724 . Original commit message: Gyp update to be able to generate VS2015 projects. PR-URL: https://github.com/joyent/node/pull/25857 Reviewed-By:
-
João Reis authored
This is a port of e192f615 . Original commit message: Older WiX versions included a header with extern "C" declaration, hence the custom action source must be C++. Reviewed-By:
João Reis <reis@janeasystems.com> PR-URL: https://github.com/joyent/node/pull/25569 PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
-
Julien Gilli authored
This is a port of 16bcd68d . Original commit message: The original change that added support for running custom actions during the install process (e7c84f82 ) assumed that Visual Studio 2013 is used to generate the installer file. However, that is not always the case, and older versions of Visual Studio should allow users to generate Windows installer files. This change makes the custom actions visual studio project use the visual studio version that is found by vcbuild.bat. Reviewed-By:
-
- Sep 11, 2015
-
-
Ben Noordhuis authored
It was pointed out by Zhou Ran that the Windows XP implementation of uv_rwlock_rdlock() and friends may unlock the inner write mutex on a different thread than the one that locked it, resulting in undefined behavior. The only place that uses rwlocks is the crypto module. Make that use normal (simple) mutexes instead. OpenSSL's critical sections are generally very short, with exclusive access outnumbering shared access by a factor of three or more, so it's not as if using rwlocks gives a decisive performance advantage. PR-URL: https://github.com/nodejs/node/pull/2723 Reviewed-By:
-
- Aug 29, 2015
-
-
Tyler Anton authored
Changed child_process.exec documentation to reflect that the parameters stdout and stderr are instances of Buffer only if {encoding: null}. Otherwise, they are instances of String with the encoding. Fixes #9434 removed .DS_Store PR-URL: https://github.com/joyent/node/pull/14088 Reviewed-By:piscisaureus - Bert Belder <bertbelder@gmail.com>
-
- Aug 28, 2015
-
-
cjihrig authored
spawnSync() modifies the options argument. This commit makes a copy of options before any modifications occur. PR-URL: https://github.com/joyent/node/pull/9159 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com>
-
Devin Nakamura authored
PR-URL: https://github.com/joyent/node/pull/25642 Reviewed-By:
-
Samuel Mills (Henchman) authored
Updated documentation as per the issue below: https://github.com/joyent/node/issues/25466 Event listeners can alter parts of the passed object, in some circumstances the changes are passed to the next listeners due to pass by reference. This is documentation of that behavior. PR-URL: https://github.com/joyent/node/pull/25467 Reviewed-By:
-
Evan Lucas authored
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records` Fixes: https://github.com/joyent/node/issues/9285 PR-URL: https://github.com/joyent/node/pull/9300 Reviewed-By:
-
- Aug 25, 2015
-
-
João Reis authored
PR-URL: https://github.com/joyent/node/pull/25893 Reviewed-By:
-
Steven R. Loomis authored
This change is a backport of nodejs/node@4c06515a2f13c9b0890b374bb3ab3c0740c282e2. Original commit message: The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. Also, adds general mechanism for floating patches on top of ICU. Fixes: nodejs/node#2279 PR-URL: nodejs/node#2283 Reviewed-By:
-
- Aug 22, 2015
-
-
Kat Marchán authored
PR-URL: https://github.com/joyent/node/pull/25825 Reviewed-By:
-
Max Deepfield authored
libuv link fix PR-URL: https://github.com/joyent/node/pull/25885 Reviewed-By:
-
- Aug 20, 2015
-
-
George Kotchlamazashvili authored
Specifies origin and includes a list of possible values PR-URL: https://github.com/joyent/node/pull/25777 Reviewed-By:
-
- Aug 15, 2015
-
-
Steven R. Loomis authored
node was using ICU4C 54 ( released 2014-oct-06 ) * Bump to ICU4C 55 ( released 2015-apr-08) * Timezone fixes, translation fixes, bug/performance fixes. * Speed improvements in date formatting * ICU4C 55 changelog: http://site.icu-project.org/download/55 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27 * Retarget the file exclusions from ICU4C 54 to ICU4C 55 * (improves on-disk footprint on some platforms) Fixes: https://github.com/joyent/node/issues/25855 Backport from nodejs/node: > Originally-Fixes: https://github.com/nodejs/node/issues/2292 > Original-PR-URL: https://github.com/nodejs/node/pull/2293 PR-URL: https://github.com/joyent/node/pull/25856 Reviewed-By:
-
- Aug 14, 2015
-
-
Julien Valéry authored
PR-URL: https://github.com/joyent/node/pull/25811 Reviewed-By:
-
Chad Walker authored
No offense to @izs, but the doxygen he put up 3.5 years ago isn't accurate for node 0.12 nor io.js. I'm trying to keep up and have multiple sets of doxygen of v8 available at http://v8dox.com/ PR-URL: https://github.com/joyent/node/pull/25811 Reviewed-By:
-
Dyana Rose authored
PR-URL: https://github.com/joyent/node/pull/25811 Reviewed-By:
-
daveboivin authored
The current wording "This module is used for writing unit tests for your applications, you can access it with require('assert')." implies that this module should only be used in development while unit testing. The article "Error Handling in Node.js" by Joyent (https://www.joyent.com/developers/node/design/errors) uses the assert module in an efficient way to validate required function arguments. PR-URL: https://github.com/joyent/node/pull/25811 Reviewed-By: -
Andrew Murray authored
PR-URL: https://github.com/joyent/node/pull/25811 Reviewed-By:
-
- Aug 04, 2015
-
-
James M Snell authored
per https://github.com/joyent/node/pull/25591#discussion_r34824389 Reviewed-By:
-
James M Snell authored
Per https://github.com/joyent/node/pull/25635#discussion_r33973696 Additional refinement to the clarification on the `readable` event Reviewed-By:
-
James M Snell authored
per https://github.com/joyent/node/issues/14597 Indicate that `'readable'` indicates only that data can be read from the stream, not that there is actually data to be consumed. `readable.read([size])` can still return null. Includes an example that illustrates the point. Reviewed-By:
-
James M Snell authored
Per https://github.com/joyent/node/issues/14604 , Document that performing an `unshift` during a read can have unexpected results. Following the `unshift` with a `push('')` resets the reading state appropriately. Also indicate that doing an `unshift` during a read is not optimal and should be avoided. Reviewed-By:
-
Daniel Rentz authored
Fix for https://github.com/joyent/node/issues/25559 (Typo in example of util.deprecate() documentation) Reviewed-By:
-
fresheneesz authored
Minor clarifications around Readable._read and Readable.push to make their implementation/usage easier to understand. https://github.com/joyent/node/issues/14124#issuecomment-115392674 Reviewed-By:
-
James M Snell authored
per: https://github.com/joyent/node/issues/14596 1. document that a runtime error will occur if you attempt to unshift after the end event 2. document that calling read after the end event will return null and will not trigger a runtime error Reviewed-By:
-
Benjamin Steephenson authored
Clarifies that emitter.listener() returns a copy, not a reference Resolves issue #9022 Reviewed-By:
-
Philippe Laferriere authored
Made explicitely clear that when size bytes are not available, it will return null, unless we've ended, in which case the data remaining in the buffer will be returned. Fixes #7273 Reviewed-By:
-
