- Jan 13, 2021
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36869 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
James M Snell authored
The asan checks don't play well currently with persistent secure heap allocations. Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36900 Refs: https://github.com/nodejs/node/pull/36881 Reviewed-By:
Danielle Adams <adamzdanielle@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Filip Skokan <panva.ip@gmail.com>
-
Guy Bedford authored
Defines the above exports conditions by convention as well as some guidance for further conditions definitions in future PR-URL: https://github.com/nodejs/node/pull/36856 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
- Jan 12, 2021
-
-
ExE Boss authored
PR-URL: https://github.com/nodejs/node/pull/36866 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/36859 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Dimitris Halatsis authored
PR-URL: https://github.com/nodejs/node/pull/36633 Fixes: https://github.com/nodejs/node/issues/36620 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Danielle Adams <adamzdanielle@gmail.com>
-
Robert Nagy authored
Calling .end() a second time should be a noop and not leave the socket corked. Fixes: https://github.com/nodejs/node/issues/36620 PR-URL: https://github.com/nodejs/node/pull/36633 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Danielle Adams <adamzdanielle@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36827 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Robert Nagy authored
Don't invoke finished callback until OutgoingMessagehas emitted 'close'. PR-URL: https://github.com/nodejs/node/pull/36648 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Pooja D P authored
PR-URL: https://github.com/nodejs/node/pull/36766 Refs: https://github.com/nodejs/node/pull/34291 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Pooja D P authored
PR-URL: https://github.com/nodejs/node/pull/36769 Refs: https://github.com/nodejs/node/pull/34291 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
Adds two new command line arguments: * `--secure-heap=n`, which causes node.js to initialize an openssl secure heap of `n` bytes on openssl initialization. * `--secure-heap-min=n`, which specifies the minimum allocation from the secure heap. * A new method `crypto.secureHeapUsed()` that returns details about the total and used secure heap allocation. The secure heap is an openssl feature that allows certain kinds of potentially sensitive information (such as private key BigNums) to be allocated from a dedicated memory area that is protected against pointer over- and underruns. The secure heap is a fixed size, so it's important that users pick a large enough size to cover the crypto operations they intend to utilize. The secure heap is disabled by default. Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36779 Refs: https://github.com/nodejs/node/pull/36729 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36779 Refs: https://github.com/nodejs/node/pull/36729 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/36817 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
- Jan 11, 2021
-
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/36829 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36772 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/36843 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
ZiJian Liu authored
Co-authored-by:
Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36763 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
raisinten authored
* add character classes * replace echo -n with printf Co-authored-by:
Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36759 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Ouyang Yadong authored
Some cases use both `cluster` and `net`/`cluser` will throw ERR_INTERNAL_ASSERTION when `listen`/`bind` to the port of `0`. This PR maitains a separate map of the index to fix the issue. See the new tests added for the detail cases. PR-URL: https://github.com/nodejs/node/pull/36764 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Michaël Zasso authored
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.42.0 PR-URL: https://github.com/nodejs/node/pull/36842 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/36844 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/36746 PR-URL: https://github.com/nodejs/node/pull/36871 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Momtchil Momtchev authored
Using stream._construct would cause the Readable to incorrectly greedily start reading. Fixes: https://github.com/nodejs/node/issues/36251 PR-URL: https://github.com/nodejs/node/pull/36823 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
- Jan 10, 2021
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36753 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Yash Ladha authored
Cluster master message handler is basically doing the same thing for different message actions which can be avoided. Thus move to method mapping object and doing a single lookup to find the function to execute and it doesnot exists, skip the execution chain. PR-URL: https://github.com/nodejs/node/pull/36250 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Bruce A. MacNaughton authored
Fix failing code and add explanations of each assert. PR-URL: https://github.com/nodejs/node/pull/34284 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Rohan Chougule authored
PR-URL: https://github.com/nodejs/node/pull/36718 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com>
-
Ikko Ashimine authored
concatentated -> concatenated PR-URL: https://github.com/nodejs/node/pull/36717 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Nicholas Schamberg authored
Makes it clear that os.uptime() is unreliable in some virtualization cases. PR-URL: https://github.com/nodejs/node/pull/36503 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Danielle Adams authored
PR-URL: https://github.com/nodejs/node/pull/36793 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Pranshu Srivastava authored
Refs: https://github.com/nodejs/node/issues/33715 * link message.socket * deprecate * update doc/api/http.md PR-URL: https://github.com/nodejs/node/pull/33768 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
ZiJian Liu authored
PR-URL: https://github.com/nodejs/node/pull/36767 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
ZiJian Liu authored
Fixes: https://github.com/nodejs/node/issues/36731 PR-URL: https://github.com/nodejs/node/pull/36732 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
ugultopu authored
PR-URL: https://github.com/nodejs/node/pull/36809 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Yash Ladha <yash@yashladha.in> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
Introduces the `crypto.X509Certificate` object. ```js const { X509Certificate } = require('crypto'); const x509 = new X509Certificate('{pem encoded cert}'); console.log(x509.subject); ``` Fixes: https://github.com/nodejs/node/issues/29181 Signed-off-by:James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36804 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Filip Skokan <panva.ip@gmail.com>
-
James M Snell authored
Semver-major Support setting the `thisArg` for AsyncResource.bind and AsyncResource.prototype.bind. If `thisArg` is not set, then `this` will be set to the `AsyncResource` instance. Fixes: https://github.com/nodejs/node/issues/36051 Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36782 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Isaac Levy authored
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding. PR-URL: https://github.com/nodejs/node/pull/36761 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Yash Ladha <yash@yashladha.in> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Antoine du Hamel authored
Fixes: https://github.com/nodejs/node/issues/36669 PR-URL: https://github.com/nodejs/node/pull/36676 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/32750 Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36786 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-