- Jul 19, 2021
-
-
Gireesh Punathil authored
The module has been there for a while, evidence of usage in the field exists, and we have good test coverage for it. Last API change has been 18 months ago. Refs: https://github.com/nodejs/node/issues/37440#issuecomment-785763306 PR-URL: https://github.com/nodejs/node/pull/37748 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
We have a few cases in .mailmap where multiple entries are used where a single one would do. Consolidate those entries. PR-URL: https://github.com/nodejs/node/pull/39418 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39431 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39425 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
-
Rich Trott authored
The GitHub bot will leave a comment asking people to thumbs-up a fast track request so there is no need to manually leave such a comment. PR-URL: https://github.com/nodejs/node/pull/39410 Reviewed-By:
-
Rich Trott authored
Now that it's in the core repo, so ome of the TSC-centric text doesn't make as much sense as it did when it was in the TSC repo. PR-URL: https://github.com/nodejs/node/pull/39417 Reviewed-By:
-
Nikita Rykov authored
PR-URL: https://github.com/nodejs/node/pull/39414 Reviewed-By:
-
Rich Trott authored
Based on their GitHub and other social media profiles as well as the most recent of their authored commits, I suspect watson goes by "Thomas Watson" and not the name currently listed in the .mailmap and AUTHORS files. Update. I'm doing this because it helps avoid false positives in `find-inactive-collaborators.mjs` which uses `git shortlog` which uses `.mailmap`. PR-URL: https://github.com/nodejs/node/pull/39393 Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
-
Michaël Zasso authored
Add `ready_for_review` to the activity types for the pull_request event. PR-URL: https://github.com/nodejs/node/pull/39405 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
-
Rich Trott authored
The list of completed initiatives is longer and visually more noticeable than the list of current initiatives, but the current initiatives are likely the ones of interest. The completed initiatives list is only going to get longer and longer, so let's put it in a details tag. PR-URL: https://github.com/nodejs/node/pull/39416 Reviewed-By:
-
Robert Nagy authored
Refs: #32020 PR-URL: https://github.com/nodejs/node/pull/39029 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39357 Refs: https://github.com/nodejs/node-inspect/pull/93 Reviewed-By:
-
Chris Opperwall authored
This addresses a TODO to validate that the sec-websocket-accept header in the WebSocket handshake response is valid. To do this we need to append the WebSocket GUID to the original key sent in sec-websocket-key, sha1 hash it, and then compare the base64 encoding with the value sent in the sec-websocket-accept response header. If they don't match, an error is thrown. PR-URL: https://github.com/nodejs/node/pull/39357 Refs: https://github.com/nodejs/node-inspect/pull/93 Reviewed-By:
-
Rich Trott authored
This typo results in a non-functional link in the WebCrypto docs. This change fixes it. PR-URL: https://github.com/nodejs/node/pull/39426 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/node/pull/39384#issuecomment-881564491 PR-URL: https://github.com/nodejs/node/pull/39411 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39409 Reviewed-By:
-
- Jul 18, 2021
-
-
Richard Lau authored
Add a regression test for NumberFormat resolvedOptions. PR-URL: https://github.com/nodejs/node/pull/39401 Refs: https://github.com/nodejs/node/issues/39050 Reviewed-By:
-
Darshan Sen authored
This change prevents the pathname setter from erasing the path of path-only URLs as that would make them cannot-be-a-base URLs. The changes in all files except `src/node_url.cc` have been done by running: ```console git node wpt url ``` Fixes: https://github.com/nodejs/node/issues/39059 Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/39060 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/39402 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
- Jul 17, 2021
-
-
Rich Trott authored
This (along with a corresponding PR for the TSC repo) moves the strategic initiatives from the TSC repository to the main core repo. This will increase visibility for strategic initiatives. It will also facilitate the proposed reduced centrality of TSC champions to strategic plans. In the process, I made the text less wordy. I moved the Build Resources initiatve out of the active list, as discussed at the most recent TSC meeting. I alphabetized the table entries. (Chronological order isn't obvious to a reader if no dates are provided.) Refs: https://github.com/nodejs/TSC/issues/962#issuecomment-880233678 PR-URL: https://github.com/nodejs/node/pull/39394 Reviewed-By:
-
hemanth.hm authored
Unflags top-level await for the REPL by enabling --experimental-repl-await by default. Opt-out is supported via --no-experimental-repl-await. PR-URL: https://github.com/nodejs/node/pull/34733 Reviewed-By:
Guy Bedford <guybedford@gmail.com>
-
Rich Trott authored
Sometimes we capitalize _pull request_ and sometimes we don't. Standardize on lowercase based on Microsoft Style Guide, Chicago Manual of Style, and GitHub's own docs and UI. Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request Refs: https://docs.microsoft.com/en-us/style-guide/capitalization PR-URL: https://github.com/nodejs/node/pull/39384 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
- Jul 16, 2021
-
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/39386 Refs: https://github.com/nodejs/node/pull/39361 Reviewed-By:
-
Daniel Bevenius authored
This commit sets SSL_OP_ALLOW_CLIENT_RENEGOTIATION for OpenSSL 3.0 as this option is not set by default as it was in previous versions. Without this option set there are a few tests that fail when linked against OpenSSl 3.0.0-alpha-17, for example test-https-client-renegotiation-limit.js. I'm not sure we should be setting this for OpenSSL 3.0 or not, but I'll take a closer look at the implications but if nothing else this would allow for us to update to alpha-17 in the mean time. PR-URL: https://github.com/nodejs/node/pull/38753 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39383 Reviewed-By:
-
Daniel Bevenius authored
This commit add the contents that should go into the docker-node and build issues when doing a security release. PR-URL: https://github.com/nodejs/node/pull/39215 Reviewed-By:
-
Daniel Bevenius authored
This commit adds instructions for adding machine-readable json files to the security-wg repo in the security release guide. PR-URL: https://github.com/nodejs/node/pull/39220 Reviewed-By:
-
Rich Trott authored
Sometimes we capitalize _collaborator_ and sometimes not. After consulting the Microsoft Style Guide and The Chicago Manual of Style, I've concluded it is best to not capitalize it. For consistency, apply that to our various .md files. Refs: https://docs.microsoft.com/en-us/style-guide/capitalization PR-URL: https://github.com/nodejs/node/pull/39379 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Rich Trott authored
All other files in `lib/internal` do not start with `_`. For consistency, move `lib/internal/debugger/_inspect.js` to `lib/internal/debugger/inspect.js`. PR-URL: https://github.com/nodejs/node/pull/39378 Reviewed-By:
-
James M Snell authored
Makes the FileHandle::ClosePromise() idempotent, always returning the same Promise after it has already been successfully called once. Avoids the possibility of accidental double close events. Signed-off-by:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Adds an experimental `readableWebStream()` method to `FileHandle` that returns a web `ReadableStream` Signed-off-by:
-
- Jul 15, 2021
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/39175 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39391 Reviewed-By:
-
legendecas authored
Add `process.setSourceMapsEnabled` to enable source-maps programmatically. PR-URL: https://github.com/nodejs/node/pull/39085 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39367 Reviewed-By:
-
Rich Trott authored
commit-lint.yml uses setup-node@v1 but all our other GitHub Actions use v2. Update commit-lint.yml. PR-URL: https://github.com/nodejs/node/pull/39366 Reviewed-By:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Experimental as part of the web streams implementation Signed-off-by:
-
- Jul 14, 2021
-
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/38334 Reviewed-By:
-
