Commits · 8d29569368629bf6dfd549a69b80b678ab714e58 · github.com / v8-riscv / node

Oct 15, 2018

Сковорода Никита Андреевич authored Sep 02, 2018

This fixes links that were broken due to inclusion of the trailing dot.
Also simplifies a pair of occurances of []().

PR-URL: https://github.com/nodejs/node/pull/23359


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8d295693

crypto: move field initialization to class · 98afca92

Diana Holland authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23610


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

98afca92

tools: update ESLint to 5.7.0 · ea9df8b4

cjihrig authored Oct 12, 2018

Update ESLint to 5.7.0.

PR-URL: https://github.com/nodejs/node/pull/23629


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

ea9df8b4

test: change to arrow functions in send-bad-arguments · 6783eedc

Anna Zhao authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23483


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

6783eedc

src: move default assignment of async_id_ in async_wrap.h · 8ce99faa

David Corona authored Oct 12, 2018

Moving the default assignment of async_id from the constructor in
async_wrap.cc to class definition in async_wrap.h

PR-URL: https://github.com/nodejs/node/pull/23495


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

8ce99faa

test: removed unused variable · fd230c13

Michal Hynek authored Oct 12, 2018

Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.

PR-URL: https://github.com/nodejs/node/pull/23481


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

fd230c13

lib: remove an unused variable · 5799f41c

Claire Liu authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23482


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

5799f41c

tls: update try catch syntax · 7b3f14a6

Matt Jiles authored Oct 12, 2018

try catch syntax allows elimination of function arguments
so removed unused err argument

PR-URL: https://github.com/nodejs/node/pull/23484


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

7b3f14a6

test: fix argument order for assert.strictEqual · 446aadd2

Stacey authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23485


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

446aadd2

test: fix assert.strictEqual params order · cb6c33e3

Rock Hu authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23480


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

cb6c33e3

src: change constructor behavior in stream_base-inl.h · c19ab565

Ian Sutherland authored Oct 12, 2018



Change ConstructorBehavior from kAllow to kThrow.

Co-authored-by: Bruce A. MacNaughton <bmacnaughton@gmail.com>
Refs: https://github.com/nodejs/node/pull/23453
PR-URL: https://github.com/nodejs/node/pull/23447


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

c19ab565

src: throw if functions used as constructors in node_crypto.cc · 20b3698a

Bruce A. MacNaughton authored Oct 12, 2018

Throw an error if verify_error_getter_templ or
verify_error_getter_templ2 are used as constructors.

PR-URL: https://github.com/nodejs/node/pull/23582


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

20b3698a

test: removed mustCallAsync from common and added inside testcase · 541367ac

Quinn Langille authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23467


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

541367ac

benchmark: added a test benchmark for worker · 8059ff2f

Muzafar Umarov authored Oct 12, 2018

Wrote a sequential benchmark test for worker.
This is to make sure the benchmark for work runs properly.

PR-URL: https://github.com/nodejs/node/pull/23475


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

8059ff2f

test: remove unused "e" from catch in http2 test · ff3c56c7

Stephen Heitman authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23476


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

ff3c56c7

test: remove unused variable from catch · 20fb64c3

Paige Kato authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23477


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

20fb64c3

test: inline common module boolean · 190d146b

ashleysimpson authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23479


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

190d146b

benchmark: add common.binding() · ff8db70b

cjihrig authored Oct 12, 2018

Recently, process.binding() was replaced with internalBinding().
However, internalBinding() is not available on older builds of
Node, which are often used for benchmarking purposes. This commit
adds a common.binding() to the benchmarks to work around the
issue. Hopefully, this can be removed in the not too distant
future.

PR-URL: https://github.com/nodejs/node/pull/23460
Fixes: https://github.com/nodejs/node/issues/23436


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

ff8db70b

doc: edit BUILDING.md · eeb2c8fc

Rich Trott authored Oct 11, 2018

I should have done this a few days ago so it could land in time for Code
& Learn, but oh well. Here are some revisions to BUILDING.md to try to
make it easier to read.

PR-URL: https://github.com/nodejs/node/pull/23435


Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>

eeb2c8fc

Oct 14, 2018

test: swap the order arguments are passed to assert · ede79c4c

Dylson Valente Neto authored Oct 12, 2018

Documentation for assertions rule actual values should be passed first
followed by the expected value. This commit update the assertions the
changed file contains to comply to that rule. Changes also label the
assertions.

PR-URL: https://github.com/nodejs/node/pull/23580


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

ede79c4c

readline: assert without the use of event listener · f569ecf7

Lian Li authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23472


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

f569ecf7

test: flip assertion arguments for make-callback/test.js · 7f74515c

Tim Cheung authored Oct 12, 2018

Assertion arguments should have the first value be the actual value,
while the second value be the expected value.

PR-URL: https://github.com/nodejs/node/pull/23470


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

7f74515c

test: replace function with arrow function · e48d9aa8

Yitong authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23474


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

e48d9aa8

test: swap actual and expected in assertions · a9e6e68c

Yitong authored Oct 12, 2018

'test/parallel/test-fs-write.js' contains assertions where the first
argument provided is the expected value and the second value is the
actual value. This is backward from the documentation for assertions
like 'assert.strictEqual()' where the first value should be the actual
value being tested and the second value is the expected value.

PR-URL: https://github.com/nodejs/node/pull/23474


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

a9e6e68c

test: correctly order assertion arguments · cf7b5a8d

Emily Kolar authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23473


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

cf7b5a8d

worker: remove delete MessagePort.prototype.hasRef · b22903ea

James Traver authored Oct 12, 2018

Node Code+Learn: remove delete MessagePort.prototype.hasRef;

PR-URL: https://github.com/nodejs/node/pull/23471


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

b22903ea

doc,meta: assign PR semantics · fc0da7f6

Refael Ackermann authored Oct 06, 2018

PR-URL: https://github.com/nodejs/node/pull/23292
Refs: https://github.com/nodejs/node/pull/23249


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

fc0da7f6

doc,meta: refresh wording in colab guide · 39ae0004

Refael Ackermann authored Oct 06, 2018

PR-URL: https://github.com/nodejs/node/pull/23292
Refs: https://github.com/nodejs/node/pull/23249


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

39ae0004

doc,meta: add references to outside C++ guides · 0f8eaa47

Refael Ackermann authored Oct 07, 2018

with explicit priorities

PR-URL: https://github.com/nodejs/node/pull/23317


Reviewed-By: Anna Henningsen <anna@addaleax.net>

0f8eaa47

lib: migrate from process.binding to internalBinding · 9d1c9d7e

Andres Monge authored Oct 12, 2018

We are migrating towards using internalBinding(\'options\').getOptions()
instead of process.binding(\'config\') to access the value of the
--experimental-vm-modules command line option.

PR-URL: https://github.com/nodejs/node/pull/23586


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

9d1c9d7e

test: fix errors in test-buffer-alloc.js · 401dac32

Rich Trott authored Oct 13, 2018

This fixes test code that was mistaken landed by me this morning. (Code
& Learn rush gone bad.) Sorry. Please fast track.

PR-URL: https://github.com/nodejs/node/pull/23645


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

401dac32

test: mark `test-http2-session-timeout` as flake on ARM · 882e0225

Refael Ackermann authored Oct 13, 2018

PR-URL: https://github.com/nodejs/node/pull/23639
Refs: https://github.com/nodejs/node/issues/20628


Reviewed-By: Rich Trott <rtrott@gmail.com>

882e0225

test: update test-cluster-worker-events to use arrow functions · 39897850

S. Everett Abbott authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23469


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

39897850

test: correct order for assert.strictEqual for inspector-helper test · ffa2710c

Maggie Nolan authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23468


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

ffa2710c

test: fix incorrect expectation order · c23d2505

Amie authored Oct 12, 2018

test-http-expect-handling.js has an instance of the test value and the
expected value being reversed.

Refs: https://nodejs.org/api/assert.html

PR-URL: https://github.com/nodejs/node/pull/23466


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

c23d2505

test: remove unused e variable in catch statement · 8691d8f5

Denny Scott authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23465


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

8691d8f5

test: correct assert test · 1c73990a

Richard Markins authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23463


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

1c73990a

test: fix incorrect ordering of args in assert.strictEqual() · 657ee7b0

mdaum authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23461


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

657ee7b0

test: swap assert.strictEqual args to actual, expected · 767d4dae

epeden authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23459


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

767d4dae

lib: remove unused 'e' from catch · 68b46372

Matt Holmes authored Oct 12, 2018

PR-URL: https://github.com/nodejs/node/pull/23458


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

68b46372