- Oct 09, 2018
-
-
Gus Caplan authored
Closes: https://github.com/nodejs/node/issues/23041 - Rewrite `ReadableAsyncIterator` class into `ReadableStreamAsyncIteratorPrototype` which contains no constructor and inherits from `%AsyncIteratorPrototype%`. - Rewrite `AsyncIteratorRecord` into dumb function. PR-URL: https://github.com/nodejs/node/pull/23042 Fixes: https://github.com/nodejs/node/issues/23041 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Anna Henningsen authored
Previously, flushing on zlib streams was implemented through stream 'drain' handlers. This has a number of downsides; in particular, it is complex, and could lead to unpredictable behaviour, since it meant that in a sequence like ```js compressor.write('abc'); compressor.flush(); waitForMoreDataAsynchronously(() => { compressor.write('def'); }); ``` it was not fully deterministic whether the flush happens after the second chunk is written or the first one. This commit replaces this mechanism by one that piggy-backs along the stream’s write queue, using a “special” `Buffer` instance that signals that a flush is currently due. PR-URL: https://github.com/nodejs/node/pull/23186 Reviewed-By: -
Rich Trott authored
Fixture files are not linted. Remove `eslint-disable` comments from fixture files. PR-URL: https://github.com/nodejs/node/pull/23345 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23298 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
An upcoming change in libuv will remove the artificial EISDIR error. Update the test to reflect that. Refs: https://github.com/libuv/libuv/pull/2025 PR-URL: https://github.com/nodejs/node/pull/23330 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
siddhant authored
PR-URL: https://github.com/nodejs/node/pull/23216 Fixes: https://github.com/nodejs/node/issues/23205 Reviewed-By:
-
Rich Trott authored
Simplifying some BUILDING.md and related text since a lot of people will be reading it soon for Code & Learn. I'd prefer to delete much of this text, but that risks controversy. These simplifications should be (I hope) uncontroversial. PR-URL: https://github.com/nodejs/node/pull/23335 Reviewed-By:
-
- Oct 08, 2018
-
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/23284 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
James M Snell authored
Key new feature: RFC 8441 `:protocol` support PR-URL: https://github.com/nodejs/node/pull/23284 Reviewed-By:
-
Yang Guo authored
This serves as mitigation for the so-called HashWick vulnerability. Original commit messages: commit 3833fef57368c53c6170559ffa524c8c69f16ee5 Author: Yang Guo <yangguo@chromium.org> Date: Thu Sep 20 11:43:13 2018 Refactor integer hashing function names We now clearly differentiate between: - unseeded hash for 32-bit integers - unseeded hash for 64-bit integers - seeded hash for 32-bit integers - seeded hash for strings R=bmeurer@chromium.org Bug: chromium:680662 Change-Id: I7459958c4158ee3501c962943dff8f33258bb5ce Reviewed-on: https://chromium-review.googlesource.com/1235973 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56068} commit 95a979e02d7154e45b293261a6998c99d71fc238 Author: Yang Guo <yangguo@chromium.org> Date: Thu Sep 20 14:34:48 2018 Call into C++ to compute seeded integer hash R=bmeurer@chromium.org Bug: chromium:680662 Change-Id: I8dace89d576dfcc5833fd539ce698a9ade1cb5a0 Reviewed-on: https://chromium-review.googlesource.com/1235928 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56271} Refs: https://github.com/nodejs/node/issues/23259 PR-URL: https://github.com/nodejs/node/pull/23264 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Beni von Cheni authored
In tls module, accept ArrayBuffer/DataView in place of isUint8Array in the source code & related test code in "test-tls-basic-validations.js", per the "tls" item in the checklist of the comment in #1826. PR-URL: https://github.com/nodejs/node/pull/23210 Refs: https://github.com/nodejs/node/issues/1826 Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/23225 Reviewed-By:
-
Daniel Bevenius authored
This commit removes the goto statements in SSL_CTX_use_certificate_chain by using a unique_ptr. PR-URL: https://github.com/nodejs/node/pull/23113 Reviewed-By:
-
Tom White authored
test for unusual error cases: verify that module require() falls back to index if package.json names a missing file and throws an error if package.json is unparseable. PR-URL: https://github.com/nodejs/node/pull/23285 Reviewed-By:
-
Rich Trott authored
Remove two eslint-disable comments by replacing string concatenation with template literals. These changes are in catch blocks that are not part of the actual code being benchmarked. PR-URL: https://github.com/nodejs/node/pull/23305 Reviewed-By:
-
Rich Trott authored
vsemozhetbyt noted that there were two mentions of the now-defunct 72-hour-rule in pull-requests.md. This change updates the text to reflect current wait-time rules. PR-URL: https://github.com/nodejs/node/pull/23309 Reviewed-By:
-
Anna Henningsen authored
Use the same symbol that other `AsyncWrap` instances also use for accessing the JS wrapper. PR-URL: https://github.com/nodejs/node/pull/23189 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Aleksey Chemakin authored
Correct parameter name for `napi_is_error` description. PR-URL: https://github.com/nodejs/node/pull/23310 Reviewed-By:
-
Gabriel Schulhof authored
Move it to the nodejs.org repo. PR-URL: https://github.com/nodejs/node/pull/23303 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
- Oct 07, 2018
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/23249 Refs: https://github.com/nodejs/node/pull/22255 Reviewed-By:
-
Rich Trott authored
Use fast-tracking on PRs where new Collaborators are adding themselves to the README. PR-URL: https://github.com/nodejs/node/pull/23300 Reviewed-By:
-
Rich Trott authored
Use backticks around `SHASUM256.txt` etc. in README.md. PR-URL: https://github.com/nodejs/node/pull/23299 Reviewed-By:
-
Rich Trott authored
Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: https://github.com/nodejs/node/pull/22812 Ref: https://github.com/nodejs/node/issues/21038#issuecomment-421199960 PR-URL: https://github.com/nodejs/node/pull/22856 Refs: https://github.com/nodejs/node/pull/22812 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
-
Rich Trott authored
Clarify and implify the API Documentation download information in the README. This also fixes a spelling error. PR-URL: https://github.com/nodejs/node/pull/23268 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/22381 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Rich Trott authored
Currently, we have a 72 rule for how many hours a pull request should be left open at a minimum. Reduce that time to 48 hours. PR-URL: https://github.com/nodejs/node/pull/23082 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Rich Trott authored
Simplify and clarify the text in README.md for verifying binaries. PR-URL: https://github.com/nodejs/node/pull/23248 Reviewed-By:
-
Rich Trott authored
There are many things I might want to know about if I'm reading the introduction of the README file for Node.js: Where to get help, what the latest release is, how to compile from source, where to report bugs, how to contribute... One thing I cannot imagine wondering about is, "I wonder if there is a foundation that supports Node.js." Move that sentence to the end of the paragraph as it is designed to serve the project and not the end user. Bonus: This removes a usage of passive voice. The Linux kernel README does not mention the Linux Foundation. https://github.com/torvalds/linux/blob/master/README The jQuery README does not mention the JS Foundation. https://github.com/jquery/jquery/blob/master/README.md (It does mention the no-longer-extant jQuery Foundation but only because the Foundation itself apparently had coding standards.) The Python README only mentions the Python Software Foundation as the copyright owner. The Apache httpd README does mention the Apache Software Foundation although it does not link to it and it is mentioned in passing rather than being the topic of a declarative sentence. PR-URL: https://github.com/nodejs/node/pull/23073 Reviewed-By:
-
- Oct 06, 2018
-
-
Ali Ijaz Sheikh authored
For safer shutdown, we should destroy the platform – and background threads - before the tracing infrastructure is destroyed. This change fixes the relative order of NodePlatform disposition and the tracing agent shutting down. This matches the nesting order for startup. Make the tracing agent own the tracing controller instead of platform to match the above. Fixes: https://github.com/nodejs/node/issues/22865 PR-URL: https://github.com/nodejs/node/pull/22938 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Duarte David authored
Swap arguments in strictEqual() for parallel/test-buffer-copy. PR-URL: https://github.com/nodejs/node/pull/23204 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Matheus Marchini authored
Original commit message: [postmortem] add postmortem metadata for symbols As discussed in https://github.com/nodejs/llnode/issues/156, we need postmortem metadata for Symbols to properly print Symbol property names in postmortem debugging tools. Patch suggested by Ben Noordhuis (https://github.com/nodejs/llnode/issues/156#issuecomment-350467852). R=bmeurer@google.com, yangguo@google.com Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118 Reviewed-on: https://chromium-review.googlesource.com/1205052 Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55632} Refs: https://github.com/v8/v8/commit/958b761d3392495c3bf635e97fb9bd0e45 PR-URL: https://github.com/nodejs/node/pull/22914 Reviewed-By:
-
Gabriel Schulhof authored
Re: https://github.com/nodejs/abi-stable-node/issues/332#issuecomment-418379903 PR-URL: https://github.com/nodejs/node/pull/23229 Reviewed-By:
-
Ali Ijaz Sheikh authored
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: https://github.com/nodejs/node/issues/23065 PR-URL: https://github.com/nodejs/node/pull/23233 Reviewed-By:
-
Anna Henningsen authored
- Document `defaultEncoding`. This was previously undocumented. - Clarify `decodeStrings`. In particular, the previous description was talking about decoding, which matches the unfortunate option name, but what actually happens is usually refererred to as encoding a string into a binary form. PR-URL: https://github.com/nodejs/node/pull/23246 Reviewed-By:
-
Anna Henningsen authored
Add back a number deprecated APIs, using shims that should work well enough at least for the duration of Node 11 and do not come with significant maintenance overhead. Refs: https://github.com/nodejs/node/issues/23122 PR-URL: https://github.com/nodejs/node/pull/23158 Reviewed-By:
-
Anna Henningsen authored
Reverting this enables us to provide slower, but longer-lasting replacements for the deprecated APIs. Original commit message: Put back deleted V8_DEPRECATE_SOON methods This partially reverts https://chromium-review.googlesource.com/c/v8/v8/+/1177861, which deleted many V8_DEPRECATE_SOON methods rather than moving them to V8_DEPRECATED first. This puts them back and marks them V8_DEPRECATED. Note V8_DEPRECATED that were deleted in the same CL stay deleted. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: v8:7786, v8:8240 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I00330036d957f98dab403465b25e30d8382aac22 Reviewed-on: https://chromium-review.googlesource.com/1251422 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/7.0@{#49} Cr-Branched-From: 6e2adae6f7f8e891cfd01f3280482b20590427a6-refs/heads/7.0.276@{#1} Cr-Branched-From: bc08a8624cbbea7a2d30071472bc73ad9544eadf-refs/heads/master@{#55424} Refs: https://github.com/v8/v8/commit/9136dd8088a95484b059a0301b25235510fc2882 Refs: https://github.com/nodejs/node/issues/23122 PR-URL: https://github.com/nodejs/node/pull/23158 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/7.0.276.22...7.0.276.24 PR-URL: https://github.com/nodejs/node/pull/23158 Refs: https://github.com/nodejs/node/issues/23122 Reviewed-By:
-
Umang Raghuvanshi authored
Adds documentation for the following `WriteStream` instance methods: - `WriteStream.clearLine()` - `WriteStream.clearScreenDown()` - `WriteStream.cursorTo()` - `WriteStream.getWindowSize()` - `WriteStream.moveCursor()` PR-URL: https://github.com/nodejs/node/pull/22893 Fixes: https://github.com/nodejs/node/issues/9853 Reviewed-By:
-
Ouyang Yadong authored
Replace `server.close()` which don't exist in code snippets. PR-URL: https://github.com/nodejs/node/pull/23239 Reviewed-By:
-
Julien Gilli authored
test-microtask-queue-run-immediate-domain.js tests that the behavior of another test, test-microtask-queue-run-immediate.js, is still consistent when the core domain module is loaded. This was needed because before the changes in https://github.com/nodejs/node/pull/1622 were merged, the core domain module would replace the function that would call nextTick callbacks with a different implementation. This is no longer the case, and as such that test is no longer needed. R-URL: https://github.com/nodejs/node/pull/23252 Refs: https://github.com/nodejs/node/pull/16222 Reviewed-By:
-
