- Feb 24, 2021
-
-
Rich Trott authored
As far as I know, this test hasn't failed since around the time it was first reported in 2019. Closes: https://github.com/nodejs/node/issues/30847 PR-URL: https://github.com/nodejs/node/pull/37462 Fixes: https://github.com/nodejs/node/issues/30847 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
The time assertion was inaccurate. Just remove it as it's not strictly necessary PR-URL: https://github.com/nodejs/node/pull/37493 Reviewed-By:
-
Michael Dawson authored
Refs: https://github.com/nodejs/node/issues/31763 This test would have helped us catch the noisy output from http2 earlier. Currently none of the tests fail if there is unexpected debug output. Signed-off-by:
Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/37447 Reviewed-By:
Beth Griggs <bgriggs@redhat.com>
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37478 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37479 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
-
- Feb 23, 2021
-
-
Richard Lau authored
This is a security release. Notable changes Vulnerabilities fixed: - **CVE-2021-22883**: HTTP2 'unknownProtocol' cause Denial of Service by resource exhaustion - **CVE-2021-22884**: DNS rebinding in --inspect - **CVE-2021-23840**: OpenSSL - Integer overflow in CipherUpdate PR-URL: https://github.com/nodejs-private/node-private/pull/255 -
Richard Lau authored
This is a security release. Notable changes Vulnerabilities fixed: - **CVE-2021-22883**: HTTP2 'unknownProtocol' cause Denial of Service by resource exhaustion - **CVE-2021-22884**: DNS rebinding in --inspect - **CVE-2021-23840**: OpenSSL - Integer overflow in CipherUpdate PR-URL: https://github.com/nodejs-private/node-private/pull/256 -
Beth Griggs authored
This is a security release. Notable changes: Vulnerabilities fixed: - **CVE-2021-22883**: HTTP2 'unknownProtocol' cause Denial of Service by resource exhaustion - **CVE-2021-22884**: DNS rebinding in --inspect - **CVE-2021-23840**: OpenSSL - Integer overflow in CipherUpdate PR-URL: https://github.com/nodejs-private/node-private/pull/254 -
Beth Griggs authored
This is a security release. Notable changes: Vulnerabilities fixed: - **CVE-2021-22883**: HTTP2 'unknownProtocol' cause Denial of Service by resource exhaustion - **CVE-2021-22884**: DNS rebinding in --inspect - **CVE-2021-23840**: OpenSSL - Integer overflow in CipherUpdate PR-URL: https://github.com/nodejs-private/node-private/pull/253 -
Daniel Bevenius authored
This commit add a configuration options named unknownProtocolTimeout which can be specified to set a value for the timeout in milliseconds that a server should wait when an unknowProtocol is sent to it. When this happens a timer will be started and the if the socket has not been destroyed during that time the timer callback will destoy it. Refs: https://hackerone.com/reports/1043360 CVE-ID: CVE-2021-22883 PR-URL: https://github.com/nodejs-private/node-private/pull/246 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Matteo Collina authored
CVE-ID: CVE-2021-22884 Refs: https://hackerone.com/bugs?report_id=1069487 PR-URL: https://github.com/nodejs-private/node-private/pull/244 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
-
Darshan Sen authored
Fixes: https://github.com/nodejs/node/issues/37442 PR-URL: https://github.com/nodejs/node/pull/37443 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Rich Trott authored
The test hasn't failed in a long time as far as I can tell. The issue may have been fixed by various event updates/changes to http2 and related systems. PR-URL: https://github.com/nodejs/node/pull/37461 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/37458 Reviewed-By:
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/37362 Reviewed-By:
Ian Sutherland <ian@iansutherland.ca> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
James M Snell authored
* Update the user timing implementation to conform to User Timing Level 3. * Reimplement user timing and timerify with pure JavaScript implementations * Simplify the C++ implementation for gc and http2 perf * Runtime deprecate additional perf entry properties in favor of the standard detail argument * Disable the `buffered` option on PerformanceObserver, all entries are queued and dispatched on setImmediate. Only entries with active observers are buffered. * This does remove the user timing and timerify trace events. Because the trace_events are still considered experimental, those can be removed without a deprecation cycle. They are removed to improve performance and reduce complexity. Old: `perf_hooks/usertiming.js n=100000: 92,378.01249733355` New: perf_hooks/usertiming.js n=100000: 270,393.5280638482` PR-URL: https://github.com/nodejs/node/pull/37136 Refs: https://github.com/nodejs/diagnostics/issues/464 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/37451 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/37450 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
- Feb 22, 2021
-
-
Michael Dawson authored
Change links in api docs to use HEAD when they refer to the primary branch. Signed-off-by:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Michael Dawson authored
fix alignment of parameters in napi_fatal_error Signed-off-by:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37400 Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37398 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/37388 Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
Darshan Sen authored
This emphasizes that `tmpdir.refresh()` must be called only once in each test file when needed. PR-URL: https://github.com/nodejs/node/pull/37383 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37344 Reviewed-By:
-
Dan Čermák authored
Signed-off-by:
Dan Čermák <dcermak@suse.com> Co-authored-by:
-
dr-js authored
Note: this only add checks for async spawn, as the sync spawn do not return a `subProcess`. PR-URL: https://github.com/nodejs/node/pull/37014 Reviewed-By:
-
dr-js authored
From the code `nodejs@8` and up should behave the same: github.com/nodejs/node/blame/v8.17.0/lib/internal/child_process.js#L290 And a short test snippet: ```js const { spawn } = require('child_process') const subProcess = spawn('non-exist-command') subProcess.on('error', (error) => console.warn('mute Unhandled "error" event:', error)) console.log('- pid:', subProcess.pid) process.nextTick(() => console.log('- after error emit')) console.log('== end of test ==') ``` Note: the sync spawn result `pid` currently do not follow this pattern. Co-authored-by: -
Greg Ziskind authored
PR-URL: https://github.com/nodejs/node/pull/37294 Reviewed-By:
-
- Feb 21, 2021
-
-
Jay Tailor authored
I presume "The can..." should be "They can...". PR-URL: https://github.com/nodejs/node/pull/37417 Reviewed-By:
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/26401 Co-authored-by:
-
- Feb 20, 2021
-
-
Michaël Zasso authored
A comment was written before the last line, hiding a check. PR-URL: https://github.com/nodejs/node/pull/37334 Reviewed-By:
-
Michaël Zasso authored
The following warnings are disabled: - C4065 in node_revert.h: there are no security reversions on the master branch. - C4003 in base64-inl.h: a macro is used four times, only once without parameters. PR-URL: https://github.com/nodejs/node/pull/37334 Reviewed-By:
-
Michaël Zasso authored
This fixes more C4244 MSVC warnings in the code base. Refs: https://github.com/nodejs/node/pull/37149 PR-URL: https://github.com/nodejs/node/pull/37334 Reviewed-By:
-
Michael Dawson authored
Where possible used HEAD in links Signed-off-by:
-
Daniel Bevenius authored
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/37412 Reviewed-By: -
Daniel Bevenius authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1j.tar.gz $ mv openssl-1.1.1j openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/37412 Reviewed-By: -
Rich Trott authored
We've been having a lot of nits lately asking people to add trailing commas, so it's probably time to incrementally make the comma-dangle rule more stringent. PR-URL: https://github.com/nodejs/node/pull/37088 Reviewed-By:
-
Rich Trott authored
We're about to turn on a requirement for dangling commas. PR-URL: https://github.com/nodejs/node/pull/37088 Reviewed-By:
-
- Feb 19, 2021
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37364 Reviewed-By:
-
