- Mar 19, 2020
-
-
Matheus Marchini authored
GitHub Actions doesn't have enough memory to complete an ASAN+Debug with V8 8.1. Don't take ASAN into account on CI results until we find a workaround, or until we upgrade to V8 8.2. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Clemens Backes authored
PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
V8 is removing support for serializing wasm modules via the value serializer. Once this is complete (https://crrev.com/c/2013110), we can re-add this test. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Clemens Backes authored
This removes uses of the "IsWebAssemblyCompiledModule" method, which is deprecated in V8 v8.1 and will be removed in v8.2. We could replace it by "IsWasmModuleObject", but since it's unused in node anyway, I just remove the definition. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Clemens Backes authored
The {SetExpectInlineWasm} method is deprecated and non-functional since V8 v8.1. Thus node should stop calling it, so that it can be fully removed in a future v8 version. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: -
cjihrig authored
This commit replaces Symbol::Name() with Symbol::Description(). Fixes: https://github.com/nodejs/node/issues/30916 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Clemens Backes authored
These methods will be removed in V8 8.1, hence we need to stop overriding them. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Refael Ackermann <refack@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
Original commit message: [torque] fix build on VS2017 Node.js build fails on VS2017 without these headers, see the downstream issue (https://github.com/nodejs/node-v8/issues/128 ). Co-authored-by:Ben Noordhuis <info@bnoordhuis.nl> Co-authored-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66661} Refs: https://github.com/v8/v8/commit/931bdbd76f5b5416447bf02c8c41fbf64573e537 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
Original commit message: Remove unnecessary export, which happens to break MSVC DLL builds. Change-Id: I47c9211274cefd26bde6bd93aa7503e022df4357 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2042874 Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Bill Ticehurst <billti@microsoft.com> Cr-Commit-Position: refs/heads/master@{#66179} Refs: https://github.com/v8/v8/commit/1e36e21acc4016b066ea4d20f3957665b7fdbce6 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Michaël Zasso authored
Bump minimum version of ICU needed to build node to 65. Refs: https://github.com/v8/v8/commit/74bf96e508e3cb8f9991c48b421d48eb0bf4dbff PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Michaël Zasso authored
This reverts commit 5981fb7f. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Joao Reis authored
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Ujjwal Sharma authored
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
Co-authored-by:
Richard Lau <riclau@uk.ibm.com> Co-authored-by:
Ujjwal Sharma <ryzokuken@igalia.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Jonathan MERCIER authored
PR-URL: https://github.com/nodejs/node/pull/31659 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/32200 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Gabriel Schulhof authored
We have received feedback indicating that the N-API support matrix as present now can be misinterpreted to mean that old versions of N-API are no longer supported on newer versions of Node.js. Filling out the bottom of the matrix should hopefully make it clear that support for such old versions continues. PR-URL: https://github.com/nodejs/node/pull/32304 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Gus Caplan authored
Adds `--disable-proto` CLI option which can be set to `delete` or `throw`. Fixes #31951 PR-URL: https://github.com/nodejs/node/pull/32279 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com>
-
- Mar 18, 2020
-
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32276 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By:
-
Rich Trott authored
We have several tests where a number of asynchronous processes need to finish before some checks happen. These are done in a number of ways, including (as here) using our Countdown testing module. I think Promise.all() may be the idiomatic and ergonomic way to go for a lot of these tests. Using this one to get feedback on the idea. PR-URL: https://github.com/nodejs/node/pull/32273 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32230 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me>
-
cjihrig authored
This commit drops pronouns from the ERR_WORKER_PATH message, and also shortens the text a bit. PR-URL: https://github.com/nodejs/node/pull/32285 Refs: https://github.com/nodejs/node/pull/31664 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Sam Roberts authored
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so move the OpenSSL one there, too. PR-URL: https://github.com/nodejs/node/pull/32209 Reviewed-By:
-
- Mar 17, 2020
-
-
Sam Roberts authored
Multi-line JSON is more human readable, but harder for log aggregators to consume, they usually require a log message per line, particularly for JSON. Compact output will be consumable by aggregators such as EFK (Elastic Search-Fluentd-Kibana), LogDNA, DataDog, etc. PR-URL: https://github.com/nodejs/node/pull/32254 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32275 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By:
-
Rich Trott authored
Update minimist used by lint-md.js to 1.2.5. Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764 Signed-off-by:
-
Michael Dawson authored
Remove the comment about the expected version so that it does not get out of sync. The code shows the expected version anyway. Signed-off-by:
-
- Mar 16, 2020
-
-
Gabriel Schulhof authored
Use `dl_iterate_phdr(3)` to find the mapping containing `__node_text_start` instead of parsing `/proc/self/maps`. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Co-Authored-By:
-
Matheus Marchini authored
`test-inspector-multisession-ws` and `test-inspector-break-when-eval` will be affected by an upstream bug when we upgrade V8 to 8.1. The bug is caused when the Inspector sets a pause at the start of a function compiled with `CompileFunctionInContext`, but that function hasn't been executed yet. On both tests, this issue is triggered by pausing while in C++ executing LookupAndCompile, which is called by requiring internal modules while running `console.log`. To eliminate this issue in both tests, we add an extra `console.log` to ensure we only pause we required all internal modules we need. On `test-inspector-break-when-eval`, we also need to start the child process with `--inspect-brk` instead of `--inspect` to ensure the test is predictable (this test would occasianlly fail on slower machines, when console.log doesn't run fast enough to finish after emitting `Runtime.consoleAPICalled` and before the parent process sending `Runtime.evaluate` message. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10287 PR-URL: https://github.com/nodejs/node/pull/32234 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10287 Reviewed-By:
-
cjihrig authored
This commit updates the stability documentation for the report feature. All diagnostic report APIs are now listed as stable, with the exception of report-on-fatalerror, which still has a few bugs to work out. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By:
-
