- Jan 19, 2018
-
-
This is a follow-up of https://github.com/nodejs/node/pull/17914. When Access and Close functions are called in Sync mode, the number of items in args is validated. These are the only two places in this file where this validation doesn't take place. PR-URL: https://github.com/nodejs/node/pull/18203 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/18205 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/18205 Reviewed-By:
-
Anna Henningsen authored
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7e. Fixes: https://github.com/nodejs/node/issues/18189 Refs: https://github.com/nodejs/node/pull/18019 PR-URL: https://github.com/nodejs/node/pull/18214 Fixes: https://github.com/nodejs/node/issues/18189 Refs: https://github.com/nodejs/node/pull/18019 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/18206 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/18226 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Jon Moss authored
Use common's mustCall (for some reason was implementing its own?), and other small fixes. PR-URL: https://github.com/nodejs/node/pull/18219 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Sho Miyamoto authored
PR-URL: https://github.com/nodejs/node/pull/18119 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17803 Refs: https://github.com/nodejs/code-and-learn/issues/72 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
James M Snell authored
In further preparation for the Promises enabled fs API, further encapsulate FSReqWrap details. The intent here is to isolate, as much as possible, the functionality of the various fs functions from the details of how the results are notified. The promises implementation will use a `FSReqPromise` alternative to `FSReqWrap` that will use the same API so that both models can be used without changing any of the actual implementation details for the various methods. PR-URL: https://github.com/nodejs/node/pull/18112 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Anna Henningsen authored
Instead of providing a separate class for keeping the parser alive during its own call back, just delay a possible `.close()` call until the stack has cleared completely. PR-URL: https://github.com/nodejs/node/pull/18135 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
- Jan 13, 2018
-
-
Anna Henningsen authored
Use template helpers instead of `#define`s to generate the raw C callbacks that are passed to the HTTP parser library. A nice effect of this is that it is more obvious what parameters the `Parser` methods take. PR-URL: https://github.com/nodejs/node/pull/18133 Reviewed-By:
-
- Jan 19, 2018
-
-
Sho Miyamoto authored
PR-URL: https://github.com/nodejs/node/pull/18132 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Refactor the read mechanism to completely avoid copying. Instead of copying individual `DATA` frame contents into buffers, create `ArrayBuffer` instances for all socket reads and emit slices of those `ArrayBuffer`s to JS. PR-URL: https://github.com/nodejs/node/pull/18030 Reviewed-By:
-
Anna Henningsen authored
Add a C++ variant of `Buffer.from(arrayBuffer, offset, length)`. PR-URL: https://github.com/nodejs/node/pull/18030 Reviewed-By:
-
Franziska Hinkelmann authored
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: https://github.com/nodejs/node/pull/18155 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Stephen Belanger authored
Add meta information to async_hooks documentation informing that executionAsyncId was renamed from currentId at Node.js 8.2.0. PR-URL: https://github.com/nodejs/node/pull/17813 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Anatoli Papirovski authored
Refactor Immediates handling to allow for them to be unrefed, similar to setTimeout, but without extra handles. Document the new `immediate.ref()` and `immediate.unref()` methods. Add SetImmediateUnref on the C++ side. PR-URL: https://github.com/nodejs/node/pull/18139 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/17708 Reviewed-By:
-
wandalen authored
This imports a standard test from w3c/web-platform-tests (console-is-a-namespace). PR-URL: https://github.com/nodejs/node/pull/17708 Reviewed-By:
-
Ruben Bridgewater authored
According to the standard the property descriptor of console should be writable and non-enumerable. PR-URL: https://github.com/nodejs/node/pull/17708 Fixes: https://github.com/nodejs/node/issues/11805 Reviewed-By:
-
- Jan 18, 2018
-
-
Michael Dawson authored
This was the only instance were we said a parameter was required. It is assumed parameters are required unless the doc says they are option. Remove `Required` to make consistent with the rest of the doc PR-URL: https://github.com/nodejs/node/pull/18184 Reviewed-By:
-
Suixinlei authored
Fixes: https://github.com/nodejs/node/issues/12516 Refs: https://github.com/nodejs/node/pull/2497 PR-URL: https://github.com/nodejs/node/pull/17705 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Matheus Marchini authored
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: https://github.com/nodejs/node/pull/16735 Refs: https://github.com/nodejs/node/issues/16278 Refs: https://github.com/nodejs/node/issues/14336 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
This reverts this behaviour introduced in a recent PR, and updates the test. Without this change, CitGM and other packages are broken. PR-URL: https://github.com/nodejs/node/pull/18210 Fixes: https://github.com/nodejs/citgm/issues/536 Reviewed-By:
-
Rich Trott authored
Change `run time` to `runtime` for both correctness and consistency with every other instance of the expression in the docs. PR-URL: https://github.com/nodejs/node/pull/18142 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/18222 Reviewed-By:
-
Rich Trott authored
Change many instances of "x is considered to be y" to "x is y". PR-URL: https://github.com/nodejs/node/pull/18095 Reviewed-By:
-
Steven R. Loomis authored
- Update to Maintainance ICU 60.2 - CLDR 32.0.1 - http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes - Subsumes https://github.com/nodejs/node/pull/16931 PR-URL: https://github.com/nodejs/node/pull/17687 Reviewed-By:
-
Vse Mozhet Byt authored
Replace some repeated full links with concise ones and bottom references. PR-URL: https://github.com/nodejs/node/pull/18213 Reviewed-By:
-
陈刚 authored
Fixes: https://github.com/nodejs/node/issues/18116 PR-URL: https://github.com/nodejs/node/pull/18121 Reviewed-By:
Weijia Wang <starkwang@126.com>
-
Michael Dawson authored
Update so that it includes some of the more recent additions. PR-URL: https://github.com/nodejs/node/pull/18167 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Yosuke Furukawa authored
PR-URL: https://github.com/nodejs/node/pull/18201 Reviewed-By:
-
sreepurnajasti authored
Refs: #13836 PR-URL: https://github.com/nodejs/node/pull/18034 Refs: https://github.com/nodejs/node/issues/13836 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/18161 Fixes: https://github.com/nodejs/node/issues/18160 Reviewed-By:
-
- Jan 17, 2018
-
-
cjihrig authored
This commit reorders the function level changelogs of Buffer.prototype.fill() and Buffer.alloc() to reflect the order in which the entries were added. PR-URL: https://github.com/nodejs/node/pull/18129 Fixes: https://github.com/nodejs/node/issues/18128 Reviewed-By:
-
cjihrig authored
Prior to this commit, Node would enter an infinite loop when attempting to fill a non-zero length buffer with a zero length buffer. This commit introduces a thrown exception in this scenario. PR-URL: https://github.com/nodejs/node/pull/18129 Fixes: https://github.com/nodejs/node/issues/18128 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/18105 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/18103 Reviewed-By:
-
laino authored
Relative unix sockets paths were previously interpreted relative to the master's CWD, which was inconsistent with non-cluster behavior. A test case has been added as well. PR-URL: https://github.com/nodejs/node/pull/16749 Fixes: https://github.com/nodejs/node/issues/16387 Reviewed-By:
-
