- Jan 31, 2016
-
-
Myles Borins authored
This replaces all sources of openssl-1.0.2f.tar.gz into deps/openssl/openssl Fix: https://github.com/nodejs/node/issues/4857 PR-URL: https://github.com/nodejs/node/pull/4961 Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> deps: copy openssl header files to include dir All symlink files in deps/openssl/openssl/include/openssl/ are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. Fix: https://github.com/nodejs/node/issues/4857 PR-URL: https://github.com/nodejs/node/pull/4961 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Myles Borins <mborins@us.ibm.com>
-
Evan Lucas authored
isLegalPort can be used in more places than just net.js. This change moves it to a new internal net module in preparation for using it in the dns module. PR-URL: https://github.com/nodejs/node/pull/4882 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Timothy Gu authored
- Maintain alphabetical order - Add documentation for `offset` and `value` where absent - Add return value documentation where absent - Remove redundant "Optional" - Move defaults to parameter enumerations PR-URL: https://github.com/nodejs/node/pull/4873 Reviewed-By:
-
Timothy Gu authored
Currently assert/assert.ok currently has the following signature: "signatures": [ { "params": [ { "name": "value" }, { "name": "message])" }, { "name": "assert.ok(value" }, { "name": "message", "optional": true } ] } ] The heading reads assert(value[, message]), assert.ok(value[, message]) Split them into two sections to make it working. PR-URL: https://github.com/nodejs/node/pull/4871 Reviewed-By:Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/4884 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
- Jan 30, 2016
-
-
Evan Lucas authored
process.env has a few quirks that deserve documenting. The commit documents: - How assigning to process.env will implicitly call `toString()` - How to remove an environment variable from process.env PR-URL: https://github.com/nodejs/node/pull/4924 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
ChALkeR authored
In readline.markdown, don't use strict mode reserved keyword "interface" as a variable name. This commit changes the name of one `readline.Interface` instance from "interface" to "rl", as it is named in other places of the doc. PR-URL: https://github.com/nodejs/node/pull/4900 Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
-
Peter Lyons authored
Docs have 108 instances of "writable" and only 1 "writeable" so fix this one. PR-URL: https://github.com/nodejs/node/pull/4954 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Fedor Indutny authored
Do not blindly take data from underlying `ArrayBuffer`, use `ByteOffset`/`ByteLength` of `Uint8Array` itself. Additionally, fix tests that weren't actually properly running because of V8's internal code cache. The code should be different, otherwise the cached data won't be used at all. Fix: #4939 PR-URL: https://github.com/nodejs/node/pull/4947 Reviewed-By:
-
Matteo Collina authored
Added ability to dgram.send to send multiple buffers, _writev style. The offset and length parameters in dgram.send are now optional. Refactored the dgram benchmarks, and seperated them from net. Added docs for the new signature. Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com> Fixes: https://github.com/nodejs/node/issues/4302 PR-URL: https://github.com/nodejs/node/pull/4374
-
- Jan 29, 2016
-
-
Minwoo Jung authored
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: https://github.com/nodejs/node/pull/3950 Reviewed-By:
-
Rich Trott authored
Many variables in the buffer tests are redeclared. Change them so that they are scoped appropriately. PR-URL: https://github.com/nodejs/node/pull/4893 Reviewed-By:
-
Rich Trott authored
A handful of variable declarations in `lib/buffer.js` redeclare the same variable in the same scope. This change removes each redeclaration by switching to `const`, switching to `let`, or explicitly hoisting the `var` declaration. PR-URL: https://github.com/nodejs/node/pull/4886 Reviewed-By:
Roman Klauke <romaaan.git@gmail.com>
-
Santiago Gimeno authored
It can happen that the server-side socket is destroyed before the client-side socket has gracefully closed, thus causing a 'ECONNRESET' error in this socket. To solve this, also close gracefully in the server side too. PR-URL: https://github.com/nodejs/node/pull/4888 Reviewed-By:
-
cjihrig authored
This commit applies new arrow function linting rules across the codebase. As it turns out, the only offenders were in the test directory. PR-URL: https://github.com/nodejs/node/pull/4813 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
cjihrig authored
This commit enables the following rules: * arrow-parens - requires parens around arrow function arguments * arrow-spacing - ensures a space on each side of the => * no-arrow-condition - prevents accidental use of => in cases where the user really intends to use <= PR-URL: https://github.com/nodejs/node/pull/4813 Reviewed-By:
-
- Jan 28, 2016
-
-
Kári Tristan Helgason authored
This commit explicitly calls out the end of line sequences used to generate line events in the readline module. Fixes: https://github.com/nodejs/node/issues/4916 PR-URL: https://github.com/nodejs/node/pull/4927 Reviewed-By:
-
Adam Langley authored
node_crypto.cc attempts to handle the case where OCSP stapling APIs aren't provided by using NODE__HAVE_TLSEXT_STATUS_CB. But the build would actually fail in this case because of a couple of places that were missing #ifdefs. With this change the build works although, as expected, test-tls-ocsp-callback.js will fail. PR-URL: https://github.com/nodejs/node/pull/4914 Reviewed-By:
-
Kári Tristan Helgason authored
Also changes some `var`s to `const` as they never change. PR-URL: https://github.com/nodejs/node/pull/4867 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Adam Langley authored
SSL_CIPHER objects are conceptually const in any case and this allows STACK_OF(SSL_CIPHER) to return a const pointer, as is done in BoringSSL and, perhaps, OpenSSL in the future. PR-URL: https://github.com/nodejs/node/pull/4913 Reviewed-By:
-
Fedor Indutny authored
Do not swallow error details when reporting UV_EPROTO asynchronously, and when creating artificial errors. Fix: #3692 PR-URL: https://github.com/nodejs/node/pull/4885 Reviewed-By:
-
Vladimir Kurchatkin authored
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: https://github.com/nodejs/node/pull/4769 Reviewed-By:
-
Benjamin Gruenbaum authored
This commit replaces multiple usages of `function(){}` with ES2015 arrow functions in places it was forgotten earlier. The goal is to make the docs more consistent since other functions were already replaced with ES2015 arrows. In addition, it fixes invalid syntax in modules.markdown to valid syntax as well as remove `var self = this` pattern usages in the code where they are now possible to avoid through arrow functions. PR-URL: https://github.com/nodejs/node/pull/4832 Reviewed-By:Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Sakthipriyan Vairamani authored
PR-URL: https://github.com/nodejs/node/pull/4907 Reviewed-By:
-
Bryan English authored
PR-URL: https://github.com/nodejs/node/pull/4244 Reviewed-By:
-
Rich Trott authored
`test-child-process-fork-net2.js` has a switch statement with 6 cases. Each case uses `child.send()`, passing an object for the callback. `child.send()` ignores the callback because it is not a function. Removing the unused argument. PR-URL: https://github.com/nodejs/node/pull/4870 Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Rich Trott authored
Timer race results in some flakiness on slower devices in CI. Remove unneeded setTimeout() and replace booleans with common.mustCall(). PR-URL: https://github.com/nodejs/node/pull/4793 Reviewed-By:
-
- Jan 27, 2016
-
-
cjihrig authored
This commit adds a shell option, to spawn() and spawnSync(). This option allows child processes to be spawned with or without a shell. The option also allows a custom shell to be defined, for compatibility with exec()'s shell option. Fixes: https://github.com/nodejs/node/issues/1009 PR-URL: https://github.com/nodejs/node/pull/4598 Reviewed-By:
-
Rich Trott authored
`test-assert.js` redeclares a variable with `var`. This change converts it to a `const` declaration and wraps it in a standalone block to scope it to just the test that uses it. PR-URL: https://github.com/nodejs/node/pull/4854 Reviewed-By:
-
Rich Trott authored
`lib/_tls_common.js` had instances of `for` loops that defined variables with `var` such that they were re-declared in the same scope. This change scopes those variables with `let` so that they are not re-declared. PR-URL: https://github.com/nodejs/node/pull/4853 Reviewed-By:
-
Dmitriy Lazarev authored
PR-URL: https://github.com/nodejs/node/pull/4797 Reviewed-By:
Chris Dickinson <chris@neversaw.us> Reviewed-By:
-
Sakthipriyan Vairamani authored
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: https://github.com/nodejs/node/pull/4876 Reviewed-By:
-
Jimb Esser authored
PR-URL: https://github.com/nodejs/node/pull/4863 Reviewed-By:
-
Myles Borins authored
Replace grep with awk to add support for subkeys PR-URL: https://github.com/nodejs/node/pull/4807 Reviewed-By:
-
cjihrig authored
The vm module's displayErrors option attaches error arrow messages as a hidden property. Later, core JavaScript code can optionally decorate the error stack with the arrow message. However, when user code catches an error, it has no way to access the arrow message. This commit changes the behavior of displayErrors to mean "decorate the error stack if an error occurs." Fixes: https://github.com/nodejs/node/issues/4835 PR-URL: https://github.com/nodejs/node/pull/4874 Reviewed-By:
-
Roman Reiss authored
PR-URL: https://github.com/nodejs/node/pull/4864 Reviewed-By:
-
Roman Reiss authored
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline PR-URL: https://github.com/nodejs/node/pull/4864 Reviewed-By:
-
- Jan 26, 2016
-
-
Drew Folta authored
When running the tests if `NODE_TEST_DIR` is set to a device different than the location of the test files (where this repo is checked out), then the parallel/test-fs-link.js test will fail with `EXDEV: cross-device link not permitted`. The code works fine (and is in fact throwing an error as desired) but the test fails. This commit first creates the "source" file in the same directory as the "destination" (where the hardlink will be created). PR-URL: https://github.com/nodejs/node/pull/4861 Reviewed-By:
-
Rich Trott authored
test-net-settimeout is unnecessarily complex. This change simplifies it. PR-URL: https://github.com/nodejs/node/pull/4799 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Evan Lucas authored
Previously, port was assumed to be a number and would cause an abort in cares_wrap. This change throws a TypeError if port is not a number before we actually hit C++. Fixes: https://github.com/nodejs/node/issues/4837 PR-URL: https://github.com/nodejs/node/pull/4839 Reviewed-By:
-
