- Oct 13, 2020
-
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139 PR-URL: https://github.com/nodejs/node/pull/35575 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35589 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35590 Reviewed-By:
-
Shelley Vohr authored
This is the certdata.txt[0] from NSS 3.56, released on 2020-08-21. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_56_RTM/lib/ckfw/builtins/certdata.txt crypto: update root certificates Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: - Microsoft ECC Root Certificate Authority 2017 - Microsoft RSA Root Certificate Authority 2017 - e-Szigno Root CA 2017 - certSIGN Root CA G2 Certificates removed: - Verisign Class 3 Public Primary Certification Authority - G3 - AddTrust External Root - Staat der Nederlanden Root CA - G2 - LuxTrust Global Root 2 PR-URL: https://github.com/nodejs/node/pull/35546 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Dmitry Gozman authored
Debugger.CallFrameId is defined as an opaque string [1]. Some tests currently hardcode the value, relying on undocumented internal details of V8. This makes it hard for V8 to change the internal representation. We should instead use the reported call frame id from the Debugger.paused event directly. This is how every inspector client does it. [1] https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#type-CallFrameId PR-URL: https://github.com/nodejs/node/pull/35570 Reviewed-By:
Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By:
-
Pooja D.P authored
I would like to apply for a triager in this project. My motivation to become a triager is to help with the issues in this repo and the help repo, as well as learn deeper internals of node.js, and to eventually become a collaborator! I hear by declare that I read and understood the project’s Code of Conduct, and will adhere to that. PR-URL: https://github.com/nodejs/node/pull/35153 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Luigi Pinca authored
Prevent multiple listeners for the `'error'` event to be added to the same `EventEmitter` instance. PR-URL: https://github.com/nodejs/node/pull/35560 Refs: https://github.com/nodejs/node/pull/35557#issuecomment-705476640 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
bcoe authored
Document deprecation of rmdir/recursive permissive functionality PR-URL: https://github.com/nodejs/node/pull/35579 Refs: https://github.com/nodejs/node/pull/35562 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
- Oct 12, 2020
-
-
Daijiro Wachi authored
Refs: https://github.com/whatwg/url/pull/544 Refs: https://github.com/web-platform-tests/wpt/pull/25716 PR-URL: https://github.com/nodejs/node/pull/35477 Fixes: https://github.com/nodejs/node/issues/35429 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
Rich Trott authored
Prefer present tense and use "might" for possibility. PR-URL: https://github.com/nodejs/node/pull/35505 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Myles Borins authored
License is out of date PR-URL: https://github.com/nodejs/node/pull/35577 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/35584 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35583 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
cjihrig authored
Update ESLint to 7.11.0 PR-URL: https://github.com/nodejs/node/pull/35578 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Yash Ladha authored
Reduced the number of substring calls by 1 as it is a linear time complexity function. Thus having a larger path might lead to decrease in performance. Also removed unnecessary string allocation happening in the block. PR-URL: https://github.com/nodejs/node/pull/34808 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
cjihrig authored
The validation code for the rm/rmdir functions treated the options as distinct parameters instead of the options properties that they are. This commit updates the validation to treat them like properties. PR-URL: https://github.com/nodejs/node/pull/35565 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/35565 Reviewed-By:
-
- Oct 11, 2020
-
-
Anna Henningsen authored
Add - Event - EventTarget - MessagePort - MessageChannel - MessageEvent to the set of global objects, since they are available now and behave like they do in the browser. Fixes: https://github.com/nodejs/node/issues/35495 PR-URL: https://github.com/nodejs/node/pull/35496 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/35496 Fixes: https://github.com/nodejs/node/issues/35495 Reviewed-By:
-
Rich Trott authored
Cherry-pick 12c8b4d1 Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: https://github.com/nodejs/node/pull/17373 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Refs: https://github.com/nodejs/node/commit/12c8b4d15471cb6211b39c3a2ca5b10fa4b9f12b Cherry-pick fc81e801 Original commit message: Update cpplint.py to check for inline headers when the corresponding header is already included. PR-URL: https://github.com/nodejs/node/pull/21521 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Refs: https://github.com/nodejs/node/commit/0a25ace9c35b62ece4d32fd90b326d8063265109 Cherry-pick afa9a720 Original commit message: tools: refloat update link to google styleguide for cpplint This commit updates two old links to Google's C++ styleguide which currently result in a 404 when accessed. PR-URL: https://github.com/nodejs/node/pull/30876 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> PR-URL: https://github.com/nodejs/node/pull/35569 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/cpplint/cpplint/releases/tag/1.4.6 PR-URL: https://github.com/nodejs/node/pull/35569 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/35527 Reviewed-By:
-
cjihrig authored
validateRmOptions() doesn't return a value, so this commit removes the assignment. The options passed to validateRmdirOptions() are not used again after validation, so this commit removes the assignment. PR-URL: https://github.com/nodejs/node/pull/35567 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/35567 Reviewed-By:
-
Anna Henningsen authored
This addresses a TODO comment, and removes invalid `.ToLocalChecked()` calls from our code base. PR-URL: https://github.com/nodejs/node/pull/35486 Reviewed-By:
-
cjihrig authored
This commit updates rm() to use the EISDIR constant with ERR_FS_EISDIR instead of hard coding -21. PR-URL: https://github.com/nodejs/node/pull/35563 Reviewed-By:
-
cjihrig authored
fsPromises.rm() is not synchronous. PR-URL: https://github.com/nodejs/node/pull/35561 Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
cjihrig authored
This commit updates the documentation for the force option to fs.rm(). Prior to this commit, the documentation was inconsistent with the surrounding documentation. PR-URL: https://github.com/nodejs/node/pull/35561 Reviewed-By:
-
- Oct 10, 2020
-
-
James M Snell authored
Following the crypto subsystem refactor, this is now unused. Begone!! Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35556 Reviewed-By:
-
Rich Trott authored
* add kbd elements * correct period/parenthesis order * make fragment a full sentence PR-URL: https://github.com/nodejs/node/pull/35558 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/35576 Reviewed-By:
-
Robert Nagy authored
Enables an optimization when the user already has the headers in an array form, e.g. when proxying. PR-URL: https://github.com/nodejs/node/pull/35274 Reviewed-By:
-
Myles Borins authored
This is currently at the end of the doc, it likely should be found right after the documentation about `package.exports`. Refactored the docs while duplicating content as little as possible. Co-authored-by:
Myles Borins <mylesborins@github.com> PR-URL: https://github.com/nodejs/node/pull/35535 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139 PR-URL: https://github.com/nodejs/node/pull/35454 Reviewed-By:
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139 PR-URL: https://github.com/nodejs/node/pull/35454 Reviewed-By:
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139 PR-URL: https://github.com/nodejs/node/pull/35454 Reviewed-By:
-
