Commit 87da7a6d authored by Dmitry Gozman's avatar Dmitry Gozman Committed by Node.js GitHub Bot
Browse files

inspector: do not hardcode Debugger.CallFrameId in tests

Debugger.CallFrameId is defined as an opaque string [1].

Some tests currently hardcode the value, relying on
undocumented internal details of V8. This makes it hard
for V8 to change the internal representation.

We should instead use the reported call frame id from
the Debugger.paused event directly. This is how every
inspector client does it.

[1] https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#type-CallFrameId

PR-URL: https://github.com/nodejs/node/pull/35570


Reviewed-By: default avatarAleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: default avatarAnna Henningsen <anna@addaleax.net>
Reviewed-By: default avatarRich Trott <rtrott@gmail.com>
parent 18ff3c8d
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment