- May 06, 2022
-
-
River Riddle authored
This was changed in 16dcbb53
-
Jason Molenda authored
When picking the UnwindPlan row to use to backtrace, off of the zeroth frame, decrement the return pc so we're in the address range of the call instruction. If this is a noretrun function call, the instruction at the "return address" is likely an entirely different basic block with possibly very different unwind rules, and this can cause the backtrace to be incorrect. Differential Revision: https://reviews.llvm.org/D124957 rdar://84651805
-
Amara Emerson authored
-
Lang Hames authored
Clients don't care about linkage, and ExecutorAddr is much more ergonomic.
-
H.J. Lu authored
Since x32 pointer size is 4 bytes, the self pointer offset in TCB: struct { void *tcb; dtv_t *dtv; void *self; ... should be 8, not 16. Fixes https://github.com/llvm/llvm-project/issues/55288 Differential Revision: https://reviews.llvm.org/D125025 -
Stella Stamenova authored
The names of the functions that are supposed to be exported do not match the implementations. This is due in part to https://github.com/llvm/llvm-project/commit/cac7aabbd8236bef2909bfc0dbba17644f7aaade. This change makes the implementations and declarations match and adds a couple missing declarations. The new names follow the pattern of the existing `verify` functions where the prefix is maintained as `_mlir_ciface_` but the suffix follows the new naming convention. Reviewed By: rriddle Differential Revision: https://reviews.llvm.org/D124891
-
Eric Li authored
A follow-up to 62b2a47a to centralize the logic that skips expressions that the CFG does not emit. This allows client code to avoid sprinkling this logic everywhere. Add redirects in the transfer function to similarly skip such expressions by forwarding the visit to the sub-expression. Differential Revision: https://reviews.llvm.org/D124965
-
Martin Storsjö authored
This test only fails on x86_64 clang-cl, not for i386. (The root cause is still not explored, thus the FIXME is still relevant.) Differential Revision: https://reviews.llvm.org/D124994
-
Martin Storsjö authored
[libcxx] [test] Extend the UNSUPPORTED lines in strong_order_long_double.verify.cpp for non-x86_64 Windows Differential Revision: https://reviews.llvm.org/D124992
-
Martin Storsjö authored
On Windows on i386, C++ member functions use a different calling convention (`__thiscall`) than the default one for regular functions (`__cdecl`). (On Windows on architectures other than i386, both calling convention attributes are no-ops.) This matches how libstdc++ declares these types. This fixes the std/thread/futures/futures.{shared,unique}_future/dtor.pass.cpp tests on i386 mingw. Differential Revision: https://reviews.llvm.org/D124990 -
Martin Storsjö authored
All current Windows architectures (i386, x86_64, arm, arm64) get the full_size() behaviour here. x86_64 (the only one tested in CI currently) is handled by the first ifdef at the top, but handle Windows in general on all other architectures later. Differential Revision: https://reviews.llvm.org/D124989
-
Craig Topper authored
This comment used to exist, but was lost in a refactor over 10 years ago, but still seems relevant and improves readability.
-
Lang Hames authored
In the common case of converting an ExecutorAddr to a function pointer type, this eliminates the need for the '(*)' boilerplate to explicitly specify a function pointer. E.g.: auto *F = A.toPtr<int(*)()>(); can now be written as auto *F = A.toPtr<int()>();
-
Simon Pilgrim authored
We needed something that would delay the creation of the undef until after the rem-by-constant expansion, so I used a SSE shift of undef by zero which will expand to undef.
-
phyBrackets authored
Reviewed By: martong Differential Revision: https://reviews.llvm.org/D124774
-
Rahman Lavaee authored
This patch adds a new feature to bolt heatmap to print the hotness of each section in terms of the percentage of samples within that section. Sample output generated for the clang binary: Section Name, Begin Address, End Address, Percentage Hotness .text, 0x1a7b9b0, 0x20a2cc0, 1.4709 .init, 0x20a2cc0, 0x20a2ce1, 0.0001 .fini, 0x20a2ce4, 0x20a2cf2, 0.0000 .text.unlikely, 0x20a2d00, 0x431990c, 0.3061 .text.hot, 0x4319910, 0x4bc6927, 97.2197 .text.startup, 0x4bc6930, 0x4c10c89, 0.0058 .plt, 0x4c10c90, 0x4c12010, 0.9974 Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D124412
-
Aaron Ballman authored
GCC warns with a pedantic warning when -std=gnu89, but Clang would only diagnose in -std=c89 mode. Clang now matches the GCC behavior in both modes. Fixes #18427
-
Alexandre Perez authored
Currently, debugserver has a test to check if it was launched in translation. The intent was to cover the case where an x86_64 debugserver attempts to control an arm64/arm64e process, returning an error. However, this check also covers the case where users are attaching to an x86_64 process, exiting out before attempting to hand off control to the translated debugserver at `/Library/Apple/usr/libexec/oah/debugserver`. This diff delays the debugserver translation check until after determining whether to hand off control to `/Library/Apple/usr/libexec/oah/debugserver`. Only when the process is not translated and thus has not been handed off do we check if the debugserver is translated, erroring out in that case. Reviewed By: jasonmolenda Differential Revision: https://reviews.llvm.org/D124814
-
Florian Hahn authored
After introducing VPWidenPointerInductionRecipe, VPWidenPHIRecipes should not be created at this point. Turn check into an assert.
-
David Blaikie authored
Discovered in a large object that would need a 64 bit index (but the cu/tu index format doesn't include a 64 bit offset/length mode in DWARF64 - a spec bug) but instead binutils dwp overflowed the offsets causing overlapping regions.
-
Nick Desaulniers authored
To match the cost of other scheduling models. This is expected to schedule mov instructions around INLINEASM less frequently for the default machineschedule (pre-RA scheduling). Suggested by Craig Topper. Link: https://github.com/llvm/llvm-project/issues/41914 Reviewed By: RKSimon Differential Revision: https://reviews.llvm.org/D122350
-
Serge Pavlov authored
This reverts commit 83914ee9. The change caused discussion: https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20220502/1034841.html
-
Peter Kasting authored
Bug: https://github.com/llvm/llvm-project/issues/55195 Reviewed By: #libc, Mordante Differential Revision: https://reviews.llvm.org/D124695
-
Nick Desaulniers authored
Generated via: $ clang -fno-omit-frame-pointer -m32 -mregparm=3 -O2 crash.c -emit-llvm -S $ llc -print-before=machine-scheduler -mcpu=sandybridge crash.mir Reviewed By: pengfei Differential Revision: https://reviews.llvm.org/D122348 -
Andrzej Warzynski authored
The assert in https://reviews.llvm.org/D124665 was missing parentheses, which triggered a warning in GCC (verified with GCC 11). As `-Werror` is on by default in FLang, that triggered build errors, see e.g. [1]. The fix is rather straightforward, so I am sending this without a review. [1] https://lab.llvm.org/buildbot/#/builders/160/builds/7016 Differential Revision: https://reviews.llvm.org/D125027
-
Aaron Ballman authored
We had a think-o that would allow a user to declare a scoped enumeration in C language modes "as a C++11 extension". This is a think-o because there's no way for the user to spell the name of the enumerators; C does not have '::' for a fully-qualified name. See commit d0d87b59 for details on why this is unintentional for C. Fixes #42372
-
Joe Nash authored
FeatureAtomicFaddInsts is replaced with three more granular features. Contributors: Petar Avramovic <Petar.Avramovic@amd.com> Patch 3/N for upstreaming of AMDGPU gfx11 architecture Depends on D124537 Reviewed By: foad, #amdgpu, arsenm Differential Revision: https://reviews.llvm.org/D124538
-
Amir Ayupov authored
Account for cross-compilation build scenarios (X86 to ARM, Linux to Windows, etc). Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D124712
-
Christopher Bate authored
The NVVM dialect test coverage for all possible type/shape combinations in the `nvvm.mma.sync` op is mostly complete. However, there were tests missing for TF32 datatype support. This change adds tests for the one relevant shape/type combination. This uncovered a small bug in the op verifier, which this change also fixes. Differential Revision: https://reviews.llvm.org/D124975
-
Sam McCall authored
Fixes https://github.com/clangd/clangd/issues/1140
-
Sanjay Patel authored
-
Sanjay Patel authored
D124997 shows that the code is not ready to handle scalable vectors, so add some more coverage for a potential crashing case.
-
Craig Topper authored
The result of sign_extend_inreg needs to have as many sign bits as requested by the VT argument. The easiest way to guarantee this is to fold it to 0. SystemZ test was modified to avoid using undef. Fixes https://github.com/llvm/llvm-project/issues/55178 Reviewed By: RKSimon Differential Revision: https://reviews.llvm.org/D124696
-
Andrzej Warzynski authored
In https://reviews.llvm.org/D124667, I added tests that check the generated assembly. I verified the assembly on AArch64 and X86_64, but the PPC Flang buildbot [1] started failing (i.e. the assembly was not generic enough). In order to fix this, I'm changing these tests to be only run on AAarch64 - that's the architecture that most of public Flang buildbots use. I'm hoping that this is straightforward enough and am merging it without a review. [1] https://lab.llvm.org/buildbot/#/builders/21/builds/40256
-
Craig Topper authored
Differential Revision: https://reviews.llvm.org/D124988
-
Craig Topper authored
Differential Revision: https://reviews.llvm.org/D124951
-
Craig Topper authored
Add basic tests and some tests for same operands and all undef operands inspired by PR55271. i32 is umin/umax is using signext to match RISC-V ABI. i8/i16 are using signext/zeroext to match the operation. Differential Revision: https://reviews.llvm.org/D124948
-
AndreyChurbanov authored
Intel Inspector uses itt notifications to analyze code execution, and it reports race conditions in dependent tasks. This patch fixes the issue notifying Inspector on tasks dependency synchronizations. Differential Revision: https://reviews.llvm.org/D123042
-
Amara Emerson authored
-
Aaron Ballman authored
If the operand to `sizeof` is an expression of VLA type, the operand is still evaluated, so we should not issue a diagnostic about ignoring the side effects in this case, as they're not actually ignored. Fixes #48010
-