- Dec 21, 2017
-
-
Jeremiah Senkpiel authored
Reduces duplicated logic. PR-URL: https://github.com/nodejs/node/pull/17704 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Jeremiah Senkpiel authored
This makes `Http2Stream`s and `Http2Session`s use actual Timeout objects in a [kTimeout] symbol property, rather than making the stream/session itself a timer and appending properties to it directly. PR-URL: https://github.com/nodejs/node/pull/17704 Reviewed-By:
-
Jeremiah Senkpiel authored
This should help keep everything consistent. PR-URL: https://github.com/nodejs/node/pull/17704 Reviewed-By:
-
Jeremiah Senkpiel authored
This makes `net.Sockets` use actual Timeout objects in a `[kTimeout]` symbol property, rather than making the socket itself a timer and appending properties to it directly. This should make the code generally easier to understand, and might also prevent some deopts from properties being changes on the socket itself. Also moves the Timeout constructor into an internal module. PR-URL: https://github.com/nodejs/node/pull/17704 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17782 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17735 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Dec 20, 2017
-
-
Ulmanb authored
Add `off` as an alias for `removeListener` PR-URL: https://github.com/nodejs/node/pull/17156 Refs: https://github.com/nodejs/node/issues/17102 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17757 Reviewed-By:
vdeturckheim <vlad2t@hotmail.com>
-
Ruben Bridgewater authored
This should not be important anymore in newer docs. The change is also documented in the "changed" part of the function. PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Ruben Bridgewater authored
This lists all function aliases directly below the declared function. PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Ruben Bridgewater authored
Fix and refactor the console benchmark. It did not test console so it got renamed and mainly tests the different ways of passing arguments through. PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Ruben Bridgewater authored
Calling write could throw a maximum call stack size error. To make sure this is not specific to a single engine (version), lazily populate the correct error message by producing such a error on demand. PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Anna Henningsen authored
`OnCallbackPadding` on the native side already clamps the return value into the right range, so there’s not need to also do that on the JS side. Also, use `>>> 0` instead of `| 0` to get an uint32, since the communication with C++ land happens through an Uint32Array. PR-URL: https://github.com/nodejs/node/pull/17717 Reviewed-By:
-
Anna Henningsen authored
- Only finish outgoing `WriteWrap`s once data has actually been passed to the underlying socket. - This makes HTTP2 streams respect backpressure - Use `DoTryWrite` as a shortcut for sending out as much of the data synchronously without blocking as possible - Use `NGHTTP2_DATA_FLAG_NO_COPY` to avoid copying DATA frame contents into nghttp2’s buffers before sending them out. PR-URL: https://github.com/nodejs/node/pull/17718 Reviewed-By:
-
Anna Henningsen authored
`nghttp2_stream_write_t` was not a necessary redirection layer and came with the cost of one additional allocation per stream write. Also, having both `nghttp2_stream_write` and `nghttp2_stream_write_t` as identifiers did not help with readability. PR-URL: https://github.com/nodejs/node/pull/17718 Reviewed-By:
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/17556 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Andreas Madsen authored
Previously the getter would mutate the kDefaultTriggerAsncId value. This refactor changes the setter to bind the current kDefaultTriggerAsncId to a scope, such that the getter doesn't have to mutate its own value. PR-URL: https://github.com/nodejs/node/pull/17273 Reviewed-By:
-
Andreas Madsen authored
When context is missing the executionAsyncId will be zero. For the default triggerAsyncId the zero value was used to default to the executionAsyncId. While this was not technically wrong because the functions are different themself, it poorly separated the two concepts. PR-URL: https://github.com/nodejs/node/pull/17273 Reviewed-By:
-
Andreas Madsen authored
rename initTriggerId to defaultTriggerAsyncId such it matches the rest of our naming. PR-URL: https://github.com/nodejs/node/pull/17273 Reviewed-By:
-
Ruben Bridgewater authored
It was not clear why the error name is actually also tested for when using a regular expression. This is now clarified. PR-URL: https://github.com/nodejs/node/pull/17585 Reviewed-By:
-
Ruben Bridgewater authored
Throw a TypeError in case a error message is provided in the second argument and a third argument is present as well. This is clearly a mistake and should not be done. PR-URL: https://github.com/nodejs/node/pull/17585 Reviewed-By:
-
Ruben Bridgewater authored
A combination of try catch and common.expectsError is not necessary as the latter already does everything on its own. PR-URL: https://github.com/nodejs/node/pull/17703 Reviewed-By:
-
Ruben Bridgewater authored
The stack frames from .throws and .doesNotThrow got included even though that was not intended. PR-URL: https://github.com/nodejs/node/pull/17703 Reviewed-By:
-
- Dec 19, 2017
-
-
Daniel Bevenius authored
This commit removes stdlib.h header as it does not seem to be used any more. PR-URL: https://github.com/nodejs/node/pull/17752 Reviewed-By:
-
rt33 authored
PR-URL: https://github.com/nodejs/node/pull/17734 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17748 Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17733 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/17729 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17727 Reviewed-By:
-
Jon Moss authored
Causing the linter job to fail on CI right now. PR-URL: https://github.com/nodejs/node/pull/17741 Reviewed-By:
-
Rich Trott authored
Make the preamble to CONTRIBUTING.md more concise and focused. PR-URL: https://github.com/nodejs/node/pull/17700 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Evan Lucas authored
Specify that $VERSION should include the `v` when replacing REPLACEME in documentation. PR-URL: https://github.com/nodejs/node/pull/17677 Reviewed-By:
-
alnyan authored
PR-URL: https://github.com/nodejs/node/pull/17714 Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17692 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17689 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17689 Reviewed-By:
-
James M Snell authored
Separate FSReqWrap definition into a new node_file.h. Add Reject and Resolve methods to encapsulate the callbacks and make the constructor, destructor protected instead of private in preparation to make FSReqWrap subclassable for the Promises implementation. Rework and simplify the After function slightly in preparation for a refactor. Introduce the node::fs namespace instead of using an anonymous namespace for fs methods. PR-URL: https://github.com/nodejs/node/pull/17689 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By:
-
