- Nov 17, 2017
-
-
Franziska Hinkelmann authored
Use an std::unique_ptr for variables that are deleted right after creation. Since the destructor of InspectorTimer is private but needed by the unique_ptr, define deleter_type as friend. PR-URL: https://github.com/nodejs/node/pull/17020 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com>
-
Daniel Bevenius authored
Currently the cctest target will fail on linux when configured --with-dtrace: /node-v9.2.0/out/Release/obj.target/node/src/node_dtrace.o: In function `node::DTRACE_NET_SERVER_CONNECTION( v8::FunctionCallbackInfo<v8::Value> const&)': node_dtrace.cc:(.text+0x103): undefined reference to `node_net__server__connection_semaphore' /node-v9.2.0/out/Release/obj.target/node/src/node_dtrace.o: In function `node::DTRACE_NET_STREAM_END( v8::FunctionCallbackInfo<v8::Value> const&)': ... This is because node_dtrace_provider.o is not linked by the cctest target. This commit tries to fix and simplify the conditions in cctest target so that node_dtrace.o is included for all operating systems that support dtrace, include node_dtrace_ustack.o for all operating systems except mac and linux, and include node_dtrace_provider.o for all operating systems except mac. PR-URL: https://github.com/nodejs/node/pull/17039 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
Change documentation-only deprecation for custom inspection using `object.inspect` property to a runtime deprecation. This is a breaking change. Custom inspection via `object.inspect` is deprecated because there is a more robust Symbol-based alternative to `.inspect` and the custom inspection via `object.inspect` feature means that people can accidentally break `console.log()` simply by attaching a `.inspect` property to their objects. Note that since this is a deprecation, the custom inspection will still work. The breaking change is simply the printing of a warning which could alarm users, break tests or other things that might be dependent on specific output, etc. PR-URL: https://github.com/nodejs/node/pull/16393 Ref: https://github.com/nodejs/node/issues/15549 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Rich Trott authored
If another function has already emitted the deprecation warning with the same code as the warning that is about to be emitted, do not emit the warning. This is a breaking change. Previously, different functions could emit the same deprecation warning multiple times. This was a known bug rather than a feature, but this change is being treated as a breaking change out of caution. Identical deprecation warnings should not be emitted. PR-URL: https://github.com/nodejs/node/pull/16393 Reviewed-By:
-
Rich Trott authored
Improve documentation for `util.deprecate()`. In particular, provide complete function signature, document arguments, and document return value. PR-URL: https://github.com/nodejs/node/pull/16393 Reviewed-By:
-
Rich Trott authored
In test-util-inspect, apply ESLint exception for accessor-pairs rule narrowly. It had been applied to nearly the whole file, but is only needed for two lines. PR-URL: https://github.com/nodejs/node/pull/16393 Reviewed-By:
-
Ben Noordhuis authored
Commit d217b285 ("async_hooks: add trace events to async_hooks") used `NODE_MODULE_CONTEXT_AWARE_BUILTIN()` instead. After commit 8680bb9f ("src: explicitly register built-in modules") it no longer works for static library builds so remove it. PR-URL: https://github.com/nodejs/node/pull/17071 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Ali Ijaz Sheikh authored
Depending on the allocator, existing code leaks memory. PR-URL: https://github.com/nodejs/node/pull/16898 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Timothy Gu authored
Much of the AST visitor code was ported from Chrome DevTools code written by Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>. PR-URL: https://github.com/nodejs/node/pull/15566 Fixes: https://github.com/nodejs/node/issues/13209 Refs: https://chromium.googlesource.com/chromium/src/+/e8111c396fef38da6654093433b4be93bed01dce Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/15566 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/15566 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/15566 Reviewed-By:
-
Timothy Gu authored
Imported from the tarball published on npm (https://registry.npmjs.org/acorn/-/acorn-5.2.1.tgz). PR-URL: https://github.com/nodejs/node/pull/15566 Reviewed-By:
-
Anna Henningsen authored
Make a REPL tab completion test pass in coverage mode by using `Uin` as the common prefix of all `Uint*Array` globals instead of `co` which could be a prefix for `console` and `coverage`, so it doesn't expand the way it's expected to in coverage mode. PR-URL: https://github.com/nodejs/node/pull/17082 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Rich Trott authored
Remove commented-out code that is leftover from a refactoring. PR-URL: https://github.com/nodejs/node/pull/17023 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Lance Ball <lball@redhat.com>
-
Gaara authored
PR-URL: https://github.com/nodejs/node/pull/17072 Fixes: https://github.com/nodejs/node/issues/17026 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Sebastian Mayr authored
In cases where libraries create AsyncResources which may be emitting more events depending on usage, the only way to ensure that destroy is called properly is by calling it when the resource gets garbage collected. Fixes: https://github.com/nodejs/node/issues/16153 PR-URL: https://github.com/nodejs/node/pull/16998 Fixes: https://github.com/nodejs/node/issues/16153 Reviewed-By:
Andreas Madsen <amwebdk@gmail.com> Reviewed-By:
-
- Nov 16, 2017
-
-
Franziska Hinkelmann authored
Use smart pointers instead of raw pointers for StdioPipes. Also, use a smart pointer for the array holding them. PR-URL: https://github.com/nodejs/node/pull/17030 Reviewed-By:
-
Ben Noordhuis authored
Mea culpa, somehow I managed to drop the documentation commit while merging the pull request. This should have been included in commit 74023c07 ("fs: expose realpath(3) bindings") from this month. PR-URL: https://github.com/nodejs/node/pull/17059 Refs: https://github.com/nodejs/node/pull/15776 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Andreas Madsen authored
This will allow trace event to record timing information for all asynchronous operations that are observed by async_hooks. PR-URL: https://github.com/nodejs/node/pull/15538 Reviewed-By:
-
Franziska Hinkelmann authored
The Cpp style guide is growing. IMHO, a Table of Contents makes it easier to navigate. PR-URL: https://github.com/nodejs/node/pull/17052 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Franziska Hinkelmann authored
Use std::unique_ptr instead of raw pointers for the tracing_agent_ in node.cc. This makes ownership clearer and we don't risk a memory leak. PR-URL: https://github.com/nodejs/node/pull/17012 Reviewed-By:
-
Daniel Bevenius authored
This reverts commit a36b5405. PR-URL: https://github.com/nodejs/node/pull/14986 Refs: https://github.com/nodejs/node/issues/14158 Refs: https://github.com/nodejs/node/pull/14892 Reviewed-By:
-
Daniel Bevenius authored
The motivation for this commit is to enable projects embedding Node.js and building with --enable-static to be able to run the test suite and linter. Currently when building with --enable-static no node executable will be created which means that the tests (apart from the cctest) and linter cannot be run. This is currently a work in progress and works on MacOS but I need to run the CI, and manually on different environments to verify that it works as expected. PR-URL: https://github.com/nodejs/node/pull/14986 Refs: https://github.com/nodejs/node/issues/14158 Refs: https://github.com/nodejs/node/pull/14892 Reviewed-By:
-
Daniel Bevenius authored
Currenlty the test target will echo additional information that might not be that useful, for example: make doc-only make[1]: Nothing to be done for `doc-only'. make lint Running JS linter... Running C++ linter... Total errors found: 0 make[2]: Nothing to be done for `lint-md'. Running C++ linter on addon docs... Total errors found: 0 make cctest This commit suggests reducing this to: make -s doc-only make -s lint Running JS linter... Running C++ linter... Running C++ linter on addon docs... Total errors found: 0 make -s cctest PR-URL: https://github.com/nodejs/node/pull/17010 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Franziska Hinkelmann authored
Instead of raw pointerns, use std::unique_ptr for PBKDF2Request and RandomBytesRequest. This makes ownership more clear. PR-URL: https://github.com/nodejs/node/pull/17000 Reviewed-By:
-
Steve Kinney authored
Tests a basic WebAssembly module that adds two numbers. wasm example from the WebAssembly/wabt repo licensed Apache 2.0. Refs: https://github.com/WebAssembly/wabt/blob/49b7984544ddaf14d5e2f1ad9115dad7e9a2b299/demo/wat2wasm/examples.js#L27-L32 PR-URL: https://github.com/nodejs/node/pull/16760 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/16951 Reviewed-By:
-
Matteo Collina authored
See: https://github.com/nodejs/node/pull/12860#pullrequestreview-76800871 PR-URL: https://github.com/nodejs/node/pull/17050 Reviewed-By:
Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By:
-
- Nov 15, 2017
-
-
Calvin Metcalf authored
Replaced _readableState.highWaterMark with a .readableHighWaterMark getter and _writableState.highWaterMark with a .writableHighWaterMark getter. The getters are non-enumerable because they break some prototype manipulation that happen in the ecosystem. Ref: https://github.com/nodejs/node/issues/445. PR-URL: https://github.com/nodejs/node/pull/12860 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Ben Noordhuis authored
It's not wholly clear what commit introduced the regression but between v8.4.0 and v8.5.0 the 'resize' event stopped getting emitted when the tty was resized. The SIGWINCH event listener apparently was being installed before the support code for `process.on('SIGWINCH', ...)` was. Fix that by moving said support code to real early in the bootstrap process. This commit also seems to fix a Windows-only "write EINVAL" error for reasons even less well-understood... Fixes: https://github.com/nodejs/node/issues/16141 Fixes: https://github.com/nodejs/node/issues/16194 PR-URL: https://github.com/nodejs/node/pull/16225 Reviewed-By:Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Ben Noordhuis authored
Introduced in commit 6ee985f3 ("tls: implement clientCertEngine option") which was merged November 11. PR-URL: https://github.com/nodejs/node/pull/16965 Reviewed-By:
-
Ben Noordhuis authored
It was computing the size of the pointer, not the size of the pointed-to object. Introduced in commit 727b2911 ("src,dns: refactor cares_wrap to avoid global state".) PR-URL: https://github.com/nodejs/node/pull/17014 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Ben Noordhuis authored
Move the logic from the previous commit to C++ land in order to avoid creating a new string when we know we won't parse it anyway. PR-URL: https://github.com/nodejs/node/pull/15767 Reviewed-By:
-
Ben Noordhuis authored
If the package.json does not contain the string '"main"', skip parsing it to JSON. Note that this changes the behavior of the module loader in the presence of package.json files that don't contain legal JSON. Such files used to throw an exception but now they are simply ignored unless they contain a "main" property. To me, that seems like a good trade-off: I observe a 25% reduction in start-up time on a medium-sized application[0]. [0] https://github.com/strongloop/sls-sample-app PR-URL: https://github.com/nodejs/node/pull/15767 Reviewed-By:
-
Evan Lucas authored
Notable changes: * **crypto**: - Support building with both 1.1.0 and 1.0.2 (David Benjamin) https://github.com/nodejs/node/pull/16130 * **fs**: - fs.realpathSync.native and fs.realpath.native are now exposed (Ben Noordhuis) https://github.com/nodejs/node/pull/15776 * **process**: - expose process.ppid (cjihrig) https://github.com/nodejs/node/pull/16839 PR-URL: https://github.com/nodejs/node/pull/16992
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/16959 Reviewed-By:
-
cjihrig authored
This commit moves the tty module's exports to a single object, which is more aligned with other core modules. PR-URL: https://github.com/nodejs/node/pull/16959 Reviewed-By:
-
Refael Ackermann authored
by using package-lock.json PR-URL: https://github.com/nodejs/node/pull/16945 Fixes: https://github.com/nodejs/node/issues/16628 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
With improvements in V8, using separate emit functions is no longer necessary and can instead be replaced by the spread operator. improvement confidence p.value events/ee-emit.js n=2000000 2.98 % 0.09852489 events/ee-emit-2-args.js n=2000000 4.19 % *** 0.0001914216 events/ee-emit-6-args.js n=2000000 61.69 % *** 6.611964e-35 events/ee-emit-diff-args.js n=2000000 -0.36 % 0.305069 events/ee-once.js n=20000000 6.42 % *** 1.27831e-06 PR-URL: https://github.com/nodejs/node/pull/16869 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
