- Dec 06, 2016
-
-
Daryl Thayil authored
PR-URL: https://github.com/nodejs/node/pull/10031 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Daryl Thayil authored
* var => const * assert test fixtures PR-URL: https://github.com/nodejs/node/pull/9912 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
k3kathy authored
refactor all var to either const/let change all assert.equal to assert.strictEqual change all assert.ok(...===...) to assert.strictEqual PR-URL: https://github.com/nodejs/node/pull/9970 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Matt Phillips authored
Changes assert.equal to assert.strictEqual in two places and adds a second argument of 0 to setTimeout PR-URL: https://github.com/nodejs/node/pull/9957 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Danny Guo authored
PR-URL: https://github.com/nodejs/node/pull/9940 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
scalkpdev authored
* changed vars to const * changed assert.equal to assert.strictEqual * added a common.mustCall in the childProcess.exec callback * replaced 2 console.log strings with template strings for readability * had to break up line 9 because it was causing a line max length (80) listing err PR-URL: https://github.com/nodejs/node/pull/9939 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Paul Chin authored
test-dgram-send-callback-recursive.js PR-URL: https://github.com/nodejs/node/pull/9973 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Wes Tyler authored
Replace assert.equal() with assert.strictEqual(). PR-URL: https://github.com/nodejs/node/pull/9963 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Teddy Katz authored
This improves the heuristic used in multiline-prompt mode to determine whether a given slash character is at the beginning of a regular expression. PR-URL: https://github.com/nodejs/node/pull/10103 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
James M Snell <jasnell@keybase.io> Fixes: https://github.com/nodejs/node/issues/9300
-
hirabhullar authored
Changed var to const and equal to strictEqual PR-URL: https://github.com/nodejs/node/pull/9982 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
hirabhullar authored
Changed equal to strictEqual PR-URL: https://github.com/nodejs/node/pull/9982 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Nigel Kibodeaux authored
PR-URL: https://github.com/nodejs/node/pull/9919 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Russell Sherman authored
refactor var -> const/let refactor process.on('exit') into common.mustCall PR-URL: https://github.com/nodejs/node/pull/9934 Reviewed-By:Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
mark hughes authored
* var -> const * assert.equal() -> assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/9920 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Punit Buch authored
* var -> const * assert.equal() -> assert.strictEqual() * assert.ok(false) -> common.fail() PR-URL: https://github.com/nodejs/node/pull/9932 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
blugavere authored
* var => const * assert.equal() => assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/10120 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Walter Beller-Morales authored
* var -> const * assert.equal() -> assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/9928 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Matt Webb authored
Update vars to const/let & equal to strictEqual. PR-URL: https://github.com/nodejs/node/pull/9927 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Tracy Hinds authored
PR-URL: https://github.com/nodejs/node/pull/10011 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Uttam Pawar authored
PR-URL: https://github.com/nodejs/node/pull/9921 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Fabrice Tatieze authored
PR-URL: https://github.com/nodejs/node/pull/9926 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jonathan Darling authored
converts an instance of assert.equal in a file already mostly updated to use assert.strictEqual PR-URL: https://github.com/nodejs/node/pull/9925 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Scott Smereka authored
PR-URL: https://github.com/nodejs/node/pull/9936 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Anna Henningsen authored
Fix `buffer.transcode()` for transcoding from single-byte character encodings to UCS2. These would previously perform out-of-bounds reads due to an incorrect `sizeof()` expression. Fixes: https://github.com/nodejs/node/issues/9834 PR-URL: https://github.com/nodejs/node/pull/9838 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Richard Karmazin authored
PR-URL: https://github.com/nodejs/node/pull/10035 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Erez Weiss authored
implemented arrow functions and changed var to const where appropriate. PR-URL: https://github.com/nodejs/node/pull/9669 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
J Scott Chapman authored
Used assert.strictEqual() instead of assert.equal() Passed a RegExp to assert.throws() Broke lines to satisfy linting PR-URL: https://github.com/nodejs/node/pull/9895 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Fix a few instances where `it's` was being used where the possessive `its` was called for. Some additional minor copy-editing of nearby text (adding a comma and fixing a comma splice) was also performed. PR-URL: https://github.com/nodejs/node/pull/10098 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Sam Roberts authored
Also, remove my key, since I never did a release. PR-URL: https://github.com/nodejs/node/pull/9862 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Anna Henningsen authored
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: https://github.com/nodejs/node/pull/9467#issuecomment-258541560 PR-URL: https://github.com/nodejs/node/pull/9471 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Josh Gavant <josh.gavant@outlook.com>
-
Ilya Potuzhnov authored
Modernize `test/parallel/test-tls-peer-certificate.js` according to the following rules: * `var` --> `const`/`let` * `assert.equal` --> `assert.strictEqual` * `assert.ok(a === b)` --> `assert.strictEqual(a, b)` PR-URL: https://github.com/nodejs/node/pull/10014 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-by:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Jackson Tian authored
make the `case 'latin1':` near by `case 'binary':`. PR-URL: https://github.com/nodejs/node/pull/9646 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Michael Alexander authored
* change implicit string equal() compares to strictEqual compares of buffer output (the slice output default) * explicitly create buffers from utf8 inputs for the compare PR-URL: https://github.com/nodejs/node/pull/10048 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jonathan Darling authored
adds a basic test for process.stdin.setRawMode to ensure that the isRaw property is properly changed PR-URL: https://github.com/nodejs/node/pull/10037 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Julian Duque authored
Replace var to const/let, use common.mustCall on callbacks and move process.on('exit') to the .on('error') handler PR-URL: https://github.com/nodejs/node/pull/10025 Reviewed-By:Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Peter Diaz authored
PR-URL: https://github.com/nodejs/node/pull/10024 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Christopher Rokita authored
PR-URL: https://github.com/nodejs/node/pull/10001 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
levsoroka authored
Replaced assert.equal to assert.strictEqual. Fixed assert.throws syntax and added second argument PR-URL: https://github.com/nodejs/node/pull/9998 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Paul Lucas authored
* Added more strict validations to properly test setEncoding * Changed all var usage to const or let * Changed assert.equal to assert.strictEqual PR-URL: https://github.com/nodejs/node/pull/9997 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cdnadmin authored
did this at nina 2016 na code and learn event PR-URL: https://github.com/nodejs/node/pull/9996 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-