- Oct 14, 2018
-
-
Lian Li authored
PR-URL: https://github.com/nodejs/node/pull/23472 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Tim Cheung authored
Assertion arguments should have the first value be the actual value, while the second value be the expected value. PR-URL: https://github.com/nodejs/node/pull/23470 Reviewed-By:
-
Yitong authored
PR-URL: https://github.com/nodejs/node/pull/23474 Reviewed-By:
-
Yitong authored
'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value. PR-URL: https://github.com/nodejs/node/pull/23474 Reviewed-By:
-
Emily Kolar authored
PR-URL: https://github.com/nodejs/node/pull/23473 Reviewed-By:
-
James Traver authored
Node Code+Learn: remove delete MessagePort.prototype.hasRef; PR-URL: https://github.com/nodejs/node/pull/23471 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23292 Refs: https://github.com/nodejs/node/pull/23249 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23292 Refs: https://github.com/nodejs/node/pull/23249 Reviewed-By:
-
Refael Ackermann authored
with explicit priorities PR-URL: https://github.com/nodejs/node/pull/23317 Reviewed-By:
-
Andres Monge authored
We are migrating towards using internalBinding(\'options\').getOptions() instead of process.binding(\'config\') to access the value of the --experimental-vm-modules command line option. PR-URL: https://github.com/nodejs/node/pull/23586 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Rich Trott authored
This fixes test code that was mistaken landed by me this morning. (Code & Learn rush gone bad.) Sorry. Please fast track. PR-URL: https://github.com/nodejs/node/pull/23645 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23639 Refs: https://github.com/nodejs/node/issues/20628 Reviewed-By:
-
S. Everett Abbott authored
PR-URL: https://github.com/nodejs/node/pull/23469 Reviewed-By:
-
Maggie Nolan authored
PR-URL: https://github.com/nodejs/node/pull/23468 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Amie authored
test-http-expect-handling.js has an instance of the test value and the expected value being reversed. Refs: https://nodejs.org/api/assert.html PR-URL: https://github.com/nodejs/node/pull/23466 Reviewed-By:
-
Denny Scott authored
PR-URL: https://github.com/nodejs/node/pull/23465 Reviewed-By:
-
Richard Markins authored
PR-URL: https://github.com/nodejs/node/pull/23463 Reviewed-By:
-
mdaum authored
PR-URL: https://github.com/nodejs/node/pull/23461 Reviewed-By:
-
epeden authored
PR-URL: https://github.com/nodejs/node/pull/23459 Reviewed-By:
-
Matt Holmes authored
PR-URL: https://github.com/nodejs/node/pull/23458 Reviewed-By:
Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By:
-
andy addington authored
PR-URL: https://github.com/nodejs/node/pull/23457 Reviewed-By:
-
Ivan Sieder authored
PR-URL: https://github.com/nodejs/node/pull/23456 Reviewed-By:
-
Andrew Eisenberg authored
Converts RangeError assertions to use common.expectsError and includes an assertion for the error code. PR-URL: https://github.com/nodejs/node/pull/23454 Reviewed-By:
-
mmisiarek authored
Catch statement defines err variable that is never used, so it is safe to remove that. PR-URL: https://github.com/nodejs/node/pull/23452 Reviewed-By:
-
Danu Widatama authored
Reverse the argument for assertion. The first argument should be the actual value and the second value should be the expected value. When there is an AssertionError, the expected and actual value will be labeled correctly. PR-URL: https://github.com/nodejs/node/pull/23451 Reviewed-By:
-
Jared Haines authored
Have actual first, expected second. PR-URL: https://github.com/nodejs/node/pull/23450 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Khalid Adil authored
PR-URL: https://github.com/nodejs/node/pull/23449 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
jungkumseok authored
When using `assert.strictEqual`, the first argument must be the actual value and the second argument must be the expected value. PR-URL: https://github.com/nodejs/node/pull/23448 Reviewed-By:
-
- Oct 13, 2018
-
-
Ali Ijaz Sheikh authored
Minor cleanup in the lifetime for the platform worker initialization synchronization barrier. PR-URL: https://github.com/nodejs/node/pull/23419 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
garrik.leonardo@gmail.com authored
Covering the case when fs-read get invalid argument for file handle PR-URL: https://github.com/nodejs/node/pull/23601 Reviewed-By:
-
David Xue authored
PR-URL: https://github.com/nodejs/node/pull/23455 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Anna Henningsen authored
Original commit message: [api] Remove deprecated wasm methods These methods were deprecated in 7.0, now we can remove them. R=adamk@chromium.org Bug: v8:7868 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I60badb378a055152bdd27aed67d11ddf74fce174 Reviewed-on: https://chromium-review.googlesource.com/1209283 Reviewed-by:Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55695} Refs: https://github.com/v8/v8/commit/b0af30948505b68c843b538e109ab378d3750e37 PR-URL: https://github.com/nodejs/node/pull/23415 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Introduced in commit d3d6cd3e ("src: improve SSL version extraction logic".) PR-URL: https://github.com/nodejs/node/pull/23622 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Shannon authored
strictEqual() expects the first argument to be the actual value and the second argument to be the expected value. This fix will correctly label the AssertionError.: PR-URL: https://github.com/nodejs/node/pull/23577 Reviewed-By:
-
Kayla Altepeter authored
This checks that invalid option throws an error. PR-URL: https://github.com/nodejs/node/pull/23595 Reviewed-By:
-
Anna Henningsen authored
This paves way for making `bytesRead` consistent with all other Node.js streams that provide a property with this name. PR-URL: https://github.com/nodejs/node/pull/23308 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/23307 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/23351 Reviewed-By:
-
Sam Roberts authored
Ref: https://github.com/nodejs/node/pull/23329 PR-URL: https://github.com/nodejs/node/pull/23357 Refs: https://github.com/nodejs/node/pull/23329 Reviewed-By:
-
Anna Henningsen authored
This makes it easier to implement the lookup in a way that targets error codes from a specific compression library, as a way towards supporting multiple ones (e.g. brotli). PR-URL: https://github.com/nodejs/node/pull/23413 Reviewed-By:
-
