- Aug 25, 2018
-
-
Michaël Zasso authored
`npm ci` fails where there is no package-lock.json. Also add the `node_modules` directory to .gitignore. PR-URL: https://github.com/nodejs/node/pull/22500 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/22466 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Christopher Hiller authored
`process.allowedNodeEnvironmentFlags` provides an API to validate and list flags as specified in `NODE_OPTIONS` from user code. Refs: https://github.com/nodejs/node/issues/17740 Signed-off-by:
Christopher Hiller <boneskull@boneskull.com> PR-URL: https://github.com/nodejs/node/pull/19335 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
Sam Ruby <rubys@intertwingly.net> Reviewed-By:
-
Joyee Cheung authored
To enable automatic update of WPT, move all our custom WHATWG URL tests that are not present in the upstream into files starting with `test-whatwg-url-custom-`, so it's easier to identify test cases that can be upstreamed and test cases that should be rolled into our repo (possibly with automation). PR-URL: https://github.com/nodejs/node/pull/22442 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Ujjwal Sharma authored
Muffle xcodebuild warnings by introducing an alternative quieter alternative to GetStdout, called GetStdoutQuiet, and call it selectively in particularly noisy xcodebuild commands. Co-authored-by:
-
Neeraj Laad authored
test: remove third argument from assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/22451 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Sarat Addepalli authored
PR-URL: https://github.com/nodejs/node/pull/22150 Reviewed-By:
-
James M Snell authored
`common.isCPPSymbolsNotMapped` is used only by the tests in the `test/tick-processor` folder. Move it local to those to get it out of `common`. PR-URL: https://github.com/nodejs/node/pull/22459 Reviewed-By:
-
Benjamin Chen authored
PR-URL: https://github.com/nodejs/node/pull/22306 Reviewed-By:
-
Denys Otrishko authored
Refs: https://github.com/nodejs/node/issues/12068 PR-URL: https://github.com/nodejs/node/pull/22335 Reviewed-By:
-
Denys Otrishko authored
Refs: https://github.com/nodejs/node/issues/12068 PR-URL: https://github.com/nodejs/node/pull/22335 Reviewed-By:
-
Denys Otrishko authored
Refs: https://github.com/nodejs/node/issues/12068 PR-URL: https://github.com/nodejs/node/pull/22335 Reviewed-By:
-
James M Snell authored
Incrementally making `require('../common')` less of a monolith. Move the `common.onGC()` utility to a separate standalone module that is only imported when it's actually needed. PR-URL: https://github.com/nodejs/node/pull/22446 Reviewed-By:Weijia Wang <starkwang@126.com> Reviewed-By:
-
Refael Ackermann authored
Refs: https://github.com/nodejs/node/issues/21038 PR-URL: https://github.com/nodejs/node/pull/22483 Reviewed-By:
-
James M Snell authored
Move the hijackstdio functions out of common so that they are imported only into the tests that actually need them PR-URL: https://github.com/nodejs/node/pull/22462 Reviewed-By:
-
- Aug 24, 2018
-
-
Ruben Bridgewater authored
The former implementation lacked symbols on the iterator objects without prototype. This is now fixed. The special handling for overriding `Symbol.iterator` was removed as it's very difficult to deal with this properly. Manipulating the symbols is just not supported. PR-URL: https://github.com/nodejs/node/pull/22437 Reviewed-By:
-
Masashi Hirano authored
Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to increase coverage. PR-URL: https://github.com/nodejs/node/pull/22368 Reviewed-By:
-
Masashi Hirano authored
Added tests for dnsPromises.lookup to increase coverage and test `onlookup()` and `onlookupall()` methods. PR-URL: https://github.com/nodejs/node/pull/21559 Reviewed-By:
-
Daniel Bevenius authored
This commit makes the tls_wrap builtin an internal builtin, and changes usage of the builtin from using process.binding('tls_wrap') to use internalBinding instead. Refs: https://github.com/nodejs/node/issues/22160 PR-URL: https://github.com/nodejs/node/pull/22429 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By: -
Matteo Collina authored
This test is ported automatically in readable-stream, and it fails there on Windows and older Node.js versions because of some bad interactions between the code and the event loop on Windows. See: https://github.com/nodejs/readable-stream/issues/353 PR-URL: https://github.com/nodejs/node/pull/22456 Reviewed-By:
Mathias Buus <mathiasbuus@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
This commit makes the tcp_wrap builtin an internal builtin, and changes usage of the builtin from using process.binding('tcp_wrap') to use internalBinding instead. Refs: https://github.com/nodejs/node/issues/22160 PR-URL: https://github.com/nodejs/node/pull/22432 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By: -
ZYSzys authored
Move the macOS-firewall note to the end of "Building Node.js" and above "Running Tests". I think it's more reasonable when user prepare to build node step by step. Just read and build from top to end in case ignore the note. PR-URL: https://github.com/nodejs/node/pull/22440 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Rich Trott authored
Update ESLint from 5.3.0 to 5.4.0. PR-URL: https://github.com/nodejs/node/pull/22454 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Timothy Gu authored
This allows using a Proxy object as the sandbox for a VM context. PR-URL: https://github.com/nodejs/node/pull/22390 Fixes: https://github.com/nodejs/node/issues/17480 Fixes: https://github.com/nodejs/node/issues/17481 Reviewed-By:
-
Camillo Bruni authored
Original commit message: [api][runtime] Support all-in ctors of {Named,Indexed}PropertyHandlerConfiguration - Explicitly allows construction of {Named,Indexed}PropertyHandlerConfiguration with all the members filled. Bug: v8:7612 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I426ea33846b5dbf2b3482c722c963a6e4b0abded Reviewed-on: https://chromium-review.googlesource.com/1163882 Reviewed-by:Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55142} PR-URL: https://github.com/nodejs/node/pull/22390 Fixes: https://github.com/nodejs/node/issues/17480 Fixes: https://github.com/nodejs/node/issues/17481 Refs: https://github.com/v8/v8/commit/e1a76995ef311eb3ca66e12ef1941ed596034d59 Reviewed-By:
-
Timothy Gu authored
Original commit message: [api] Avoid needlessly calling descriptor interceptors Reland part of https://chromium-review.googlesource.com/c/v8/v8/+/816515. Change-Id: I72ad85ffd162fc0563fc25cdf35189e894f9dc82 Reviewed-on: https://chromium-review.googlesource.com/1138808 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54492} PR-URL: https://github.com/nodejs/node/pull/22390 Fixes: https://github.com/nodejs/node/issues/17480 Fixes: https://github.com/nodejs/node/issues/17481 Refs: https://github.com/v8/v8/commit/9eb96bb431a52568c4964dee03569eef431a4dfa Reviewed-By:
-
James M Snell authored
In a continuing effort to de-monolithize `require('../common')`, move `common.ArrayStream` out to a separate module that is imported only when it is needed. PR-URL: https://github.com/nodejs/node/pull/22447 Reviewed-By: -
James M Snell authored
The `common.isGlibc()` function is called exactly once from only one test. There's no reason for it to be in `require('../common')` at the current time. If it ends up needing to be used by multiple tests, it can easily be moved into it's own common sub-module (e.g. `require('../common/isglibc')` ... for now tho, just move it into the one test that uses it and simplify the implementation a bit to remove unnecessary caching. PR-URL: https://github.com/nodejs/node/pull/22443 Reviewed-By: -
Kyle Fuller authored
This flag is not set on other platforms so it can produce inconsistent behaviour across platforms. For example, if you build an async node add-on which uses statics you can get race conditions due to static not supporting threads if the node add-on inherits from the Node common.gypi config. It is not disabled on other platforms such as Linux, it is not disabled by default in Xcode or clang. This setting has been there since the initial commit that introduces `common.gypi` and thus has been there since the start, it doesn't seem to be have added for any particular reason other than to potentially match the Xcode defaults at the time. PR-URL: https://github.com/nodejs/node/pull/22198 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/22419 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
Ouyang Yadong authored
There is no need to call `setupPortReferencing` in `setupChild` as which has been called with the same arguments in the `oninit` prototype method of `MessagePort`. PR-URL: https://github.com/nodejs/node/pull/22298 Reviewed-By:
-
Daniel Bevenius authored
This commit makes the crypto builtin an internal builtin, and changes usage of the builtin from using process.binding('crypto') to use internalBinding instead. Refs: https://github.com/nodejs/node/issues/22160 PR-URL: https://github.com/nodejs/node/pull/22426 Reviewed-By: -
Jennifer Bland authored
PR-URL: https://github.com/nodejs/node/pull/22424 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/22491 Reviewed-By:
-
Ian McKellar authored
ProcessArgv referenced fields on PerProcessOptions that aren't there when the build is configured --without-ssl. PR-URL: https://github.com/nodejs/node/pull/22484 Reviewed-By:
-
- Aug 23, 2018
-
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/22417 Reviewed-By:
George Adams <george.adams@uk.ibm.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
-
Ruben Verborgh authored
PR-URL: https://github.com/nodejs/node/pull/22461 Reviewed-By:
-
Anto Aravinth authored
The actual bug was fixed by a V8 update in Node v10.4.0. See: https://github.com/nodejs/node/pull/19989 PR-URL: https://github.com/nodejs/node/pull/22374 Reviewed-By:
-
MaleDong authored
We don't know what will return when successful or failure for the callback of the function. So this commit makes it more detailled. PR-URL: https://github.com/nodejs/node/pull/22366 Refs: https://github.com/nodejs/node/issues/22322 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/22422 Reviewed-By:
-
