- Dec 22, 2017
-
-
Rich Trott authored
common.getTTYfd() is used in one test only. Move it's definition to that test and out of the common module. PR-URL: https://github.com/nodejs/node/pull/17781 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Rich Trott authored
common.projectDir is used in one test, so it's not so common. Remove from common module to the one test file that needs it. PR-URL: https://github.com/nodejs/node/pull/17781 Reviewed-By:
-
- Dec 21, 2017
-
-
James M Snell authored
Because of the potential performance bottlenecks that may be introduced by `util.inspect()` and `util.format()` in production hot path code. Based on real user feedback, it is not obvious that these are intended to be debugging tools. PR-URL: https://github.com/nodejs/node/pull/17791 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Michael Dawson authored
PR-URL: https://github.com/nodejs/node/pull/17688 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Evan Lucas authored
This improves the api descriptions for fs.chown, fs.chmod, and fs.mkdir along with their *Sync counterparts. PR-URL: https://github.com/nodejs/node/pull/17679 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Anna Henningsen authored
- Use arrow functions, `common.mustCall()` - Remove redundant `console.log()`s/turn them into assertions - Use `common.expectsError()` PR-URL: https://github.com/nodejs/node/pull/17710 Reviewed-By:
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/17728 Reviewed-By:
-
Michaël Zasso authored
Use the V8 inspector protocol, if available, to query the list of lexically scoped variables (defined with `let`, `const` or `class`). PR-URL: https://github.com/nodejs/node/pull/16591 Fixes: https://github.com/nodejs/node/issues/983 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [inspector] added Runtime.globalLexicalScopeNames method The method returns names for all available top-level scope variables in giving context. R=dgozman@chromium.org,jgruber@chromium.org Bug: chromium:681333 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2d0b600e1afbfef9087f53ea9c26abe1e112047c Reviewed-on: https://chromium-review.googlesource.com/719409 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#48618} Refs: https://github.com/v8/v8/commit/50f7455cd973864fe70cc04f97146f725b7c3e54 PR-URL: https://github.com/nodejs/node/pull/16591 Reviewed-By:
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/17730 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Bartosz Sosnowski authored
On Windows setting ADDRCONFIG causes localhost resolution to fail if there are no network connections. This removes that flag on Windows. Fixes: https://github.com/nodejs/node/issues/17641 PR-URL: https://github.com/nodejs/node/pull/17662 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Ruben Bridgewater authored
Using a custom inspect function on the inspected object is deprecated. Remove the reference from the option description to make sure the user will read about the deprecation in the more detailed description. PR-URL: https://github.com/nodejs/node/pull/17576 Reviewed-By:
-
Ruben Bridgewater authored
util.inspect can actually receive any property and the description was wrong so far. This fixes it by renaming the argument to value and also updating the description. PR-URL: https://github.com/nodejs/node/pull/17576 Reviewed-By:
-
Ruben Bridgewater authored
The current default formatting is not ideal and this improves the situation by formatting the output more intuitiv. 1) All object keys are now indented by 2 characters instead of sometimes 2 and sometimes 3 characters. 2) Each object key will now use an individual line instead of sharing a line potentially with multiple object keys. 3) Long strings will now be split into multiple lines in case they exceed the "lineBreak" option length (including the current indentation). 4) Opening braces are now directly behind a object property instead of using a new line. 5) Switch inspect "base" order. In case the compact option is set to `false`, inspect will now print "[Function: foo] {\n property: 'data'\n}" instead of "{ [Function: foo]\n property: 'data'\n}". PR-URL: https://github.com/nodejs/node/pull/17576 Reviewed-By: -
Ruben Bridgewater authored
From now on it is possible to use a validation object in throws instead of the other possibilites. PR-URL: https://github.com/nodejs/node/pull/17584 Refs: https://github.com/nodejs/node/pull/17557 Reviewed-By:
Ron Korving <ron@ronkorving.nl> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
Jeremiah Senkpiel authored
Reduces duplicated logic. PR-URL: https://github.com/nodejs/node/pull/17704 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Jeremiah Senkpiel authored
This makes `Http2Stream`s and `Http2Session`s use actual Timeout objects in a [kTimeout] symbol property, rather than making the stream/session itself a timer and appending properties to it directly. PR-URL: https://github.com/nodejs/node/pull/17704 Reviewed-By:
-
Jeremiah Senkpiel authored
This should help keep everything consistent. PR-URL: https://github.com/nodejs/node/pull/17704 Reviewed-By:
-
Jeremiah Senkpiel authored
This makes `net.Sockets` use actual Timeout objects in a `[kTimeout]` symbol property, rather than making the socket itself a timer and appending properties to it directly. This should make the code generally easier to understand, and might also prevent some deopts from properties being changes on the socket itself. Also moves the Timeout constructor into an internal module. PR-URL: https://github.com/nodejs/node/pull/17704 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17782 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17735 Reviewed-By:
-
- Dec 20, 2017
-
-
Ulmanb authored
Add `off` as an alias for `removeListener` PR-URL: https://github.com/nodejs/node/pull/17156 Refs: https://github.com/nodejs/node/issues/17102 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17757 Reviewed-By:
vdeturckheim <vlad2t@hotmail.com>
-
Ruben Bridgewater authored
This should not be important anymore in newer docs. The change is also documented in the "changed" part of the function. PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Ruben Bridgewater authored
This lists all function aliases directly below the declared function. PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Ruben Bridgewater authored
Fix and refactor the console benchmark. It did not test console so it got renamed and mainly tests the different ways of passing arguments through. PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Ruben Bridgewater authored
Calling write could throw a maximum call stack size error. To make sure this is not specific to a single engine (version), lazily populate the correct error message by producing such a error on demand. PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By:
-
Anna Henningsen authored
`OnCallbackPadding` on the native side already clamps the return value into the right range, so there’s not need to also do that on the JS side. Also, use `>>> 0` instead of `| 0` to get an uint32, since the communication with C++ land happens through an Uint32Array. PR-URL: https://github.com/nodejs/node/pull/17717 Reviewed-By:
-
Anna Henningsen authored
- Only finish outgoing `WriteWrap`s once data has actually been passed to the underlying socket. - This makes HTTP2 streams respect backpressure - Use `DoTryWrite` as a shortcut for sending out as much of the data synchronously without blocking as possible - Use `NGHTTP2_DATA_FLAG_NO_COPY` to avoid copying DATA frame contents into nghttp2’s buffers before sending them out. PR-URL: https://github.com/nodejs/node/pull/17718 Reviewed-By:
-
Anna Henningsen authored
`nghttp2_stream_write_t` was not a necessary redirection layer and came with the cost of one additional allocation per stream write. Also, having both `nghttp2_stream_write` and `nghttp2_stream_write_t` as identifiers did not help with readability. PR-URL: https://github.com/nodejs/node/pull/17718 Reviewed-By:
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/17556 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Andreas Madsen authored
Previously the getter would mutate the kDefaultTriggerAsncId value. This refactor changes the setter to bind the current kDefaultTriggerAsncId to a scope, such that the getter doesn't have to mutate its own value. PR-URL: https://github.com/nodejs/node/pull/17273 Reviewed-By:
-
Andreas Madsen authored
When context is missing the executionAsyncId will be zero. For the default triggerAsyncId the zero value was used to default to the executionAsyncId. While this was not technically wrong because the functions are different themself, it poorly separated the two concepts. PR-URL: https://github.com/nodejs/node/pull/17273 Reviewed-By:
-
Andreas Madsen authored
rename initTriggerId to defaultTriggerAsyncId such it matches the rest of our naming. PR-URL: https://github.com/nodejs/node/pull/17273 Reviewed-By:
-
Ruben Bridgewater authored
It was not clear why the error name is actually also tested for when using a regular expression. This is now clarified. PR-URL: https://github.com/nodejs/node/pull/17585 Reviewed-By:
-
Ruben Bridgewater authored
Throw a TypeError in case a error message is provided in the second argument and a third argument is present as well. This is clearly a mistake and should not be done. PR-URL: https://github.com/nodejs/node/pull/17585 Reviewed-By:
-
Ruben Bridgewater authored
A combination of try catch and common.expectsError is not necessary as the latter already does everything on its own. PR-URL: https://github.com/nodejs/node/pull/17703 Reviewed-By:
-
Ruben Bridgewater authored
The stack frames from .throws and .doesNotThrow got included even though that was not intended. PR-URL: https://github.com/nodejs/node/pull/17703 Reviewed-By:
-
- Dec 19, 2017
-
-
Daniel Bevenius authored
This commit removes stdlib.h header as it does not seem to be used any more. PR-URL: https://github.com/nodejs/node/pull/17752 Reviewed-By:
-
