- Nov 02, 2021
-
-
Tobias Nießen authored
Comparing any value to any non-RegExp literal or undefined using strictEqual (or notStrictEqual) passes if and only if deepStrictEqual (or notDeepStrictEqual, respectively) passes. Unnecessarily using deep comparisons adds confusion. This patch adds an ESLint rule that forbids the use of deepStrictEqual and notDeepStrictEqual when the expected value (i.e., the second argument) is a non-RegExp literal or undefined. For reference, an ESTree literal is defined as follows. extend interface Literal <: Expression { type: "Literal"; value: string | boolean | null | number | RegExp | bigint; } The value `undefined` is an `Identifier` with `name: 'undefined'`. PR-URL: https://github.com/nodejs/node/pull/40634 Reviewed-By:Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Voltrex <mohammadkeyvanzade94@gmail.com>
-
npm team authored
PR-URL: https://github.com/nodejs/node/pull/40643 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Richard Lau authored
Updated as described in doc/guides/maintaining-c-ares.md. PR-URL: https://github.com/nodejs/node/pull/40660 Reviewed-By:
-
Richard Lau authored
Add a script to automate updating of the c-ares dependency and accompanying maintenance guide. PR-URL: https://github.com/nodejs/node/pull/40660 Reviewed-By:
-
Rich Trott authored
If there is not a blank line before it, the comment does not re-enable the rule. PR-URL: https://github.com/nodejs/node/pull/40647 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
-
Rich Trott authored
This will help enforce formatting of markdown files. PR-URL: https://github.com/nodejs/node/pull/40647 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40647 Reviewed-By:
-
Node.js GitHub Bot authored
PR-URL: https://github.com/nodejs/node/pull/40668 Reviewed-By:
-
Rich Trott authored
The function only takes two arguments. PR-URL: https://github.com/nodejs/node/pull/40683 Reviewed-By:
-
Antoine du Hamel authored
Most PRs are meant to be squashed in one commit when landing. If the collaborator hasn't been using `fixup!` commits, the CQ lands the PR as several commits. This change makes the CQ abort by default when attempting to land several commits, unless there's another label added to the PR to force squashing or landing as several commits. Fixes: https://github.com/nodejs/node/issues/40436 Refs: https://github.com/nodejs/node-core-utils/pull/572 PR-URL: https://github.com/nodejs/node/pull/40577 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/40673 Reviewed-By:
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/39283 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Rich Trott authored
Ref: https://github.com/nodejs/node/issues/40694 PR-URL: https://github.com/nodejs/node/pull/40684 Reviewed-By:
-
Rich Trott authored
The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on certain tests in pummel and (previously) benchmark. Increase timeout from 4x to 6x. PR-URL: https://github.com/nodejs/node/pull/40684 Reviewed-By:
-
Rich Trott authored
test-benchmark-buffer is consistently timing out on a single Windows host in CI. Rather than try to figure out if we need to scale the timeout up for a certain memory limit or chip speed or something else, let's increase the timeout for benchmark tests in general. PR-URL: https://github.com/nodejs/node/pull/40684 Reviewed-By:
-
Piotr Rybak authored
Add standard timezone name for Dublin without daylight saving PR-URL: https://github.com/nodejs/node/pull/40684 Reviewed-By:
-
- Nov 01, 2021
-
-
Rich Trott authored
Update mdast-util-to-markdown to 1.2.4 which reduces unnecessary escaping of `_` and some other characters. Re-run markdown formatter. PR-URL: https://github.com/nodejs/node/pull/40645 Reviewed-By:
-
Rich Trott authored
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, https://github.com/nodejs/node-core-utils/pull/578 will need to land and be included in a node-core-utils release. PR-URL: https://github.com/nodejs/node/pull/40645 Reviewed-By:
-
- Oct 31, 2021
-
-
Rich Trott authored
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: https://github.com/nodejs/node/pull/232#discussion-diff-22412788 Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions. PR-URL: https://github.com/nodejs/node/pull/40648 Reviewed-By:
-
Mestery authored
PR-URL: https://github.com/nodejs/node/pull/40415 Reviewed-By:
-
FrankQiu authored
PR-URL: https://github.com/nodejs/node/pull/38974 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By:
-
Voltrex authored
Added JSDoc typings for the `inspector` lib module. PR-URL: https://github.com/nodejs/node/pull/38390 Reviewed-By:
Adrian Estrada <edsadr@gmail.com> Reviewed-By:
-
- Oct 30, 2021
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/39128 Reviewed-By:
Mary Marchini <oss@mmarchini.me>
-
Darshan Sen authored
Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/40584 Reviewed-By:
-
Darshan Sen authored
Signed-off-by:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40599 Reviewed-By:
-
- Oct 29, 2021
-
-
Joyee Cheung authored
The issues listed in the doc have been closed, and a new one is currently being used to track snapshot integration. PR-URL: https://github.com/nodejs/node/pull/40629 Reviewed-By:
-
ryan authored
PR-URL: https://github.com/nodejs/node/pull/40608 Reviewed-By:
-
- Oct 28, 2021
-
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/40639 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/40591 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40620 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40619 Reviewed-By:
-
Mestery authored
PR-URL: https://github.com/nodejs/node/pull/40411 Reviewed-By:
-
Mestery authored
PR-URL: https://github.com/nodejs/node/pull/40586 Reviewed-By:
-
Tobias Nießen authored
This adds a link to the --openssl-legacy-provider flag to the "Support for weak or compromised algorithms" section. PR-URL: https://github.com/nodejs/node/pull/40593 Refs: https://github.com/nodejs/node/pull/40478 Reviewed-By:
Beth Griggs <bgriggs@redhat.com>
-
- Oct 27, 2021
-
-
Daniel Nalborczyk authored
PR-URL: https://github.com/nodejs/node/pull/40573 Reviewed-By:
-
Daniel Nalborczyk authored
PR-URL: https://github.com/nodejs/node/pull/40573 Reviewed-By:
-
Daniel Nalborczyk authored
PR-URL: https://github.com/nodejs/node/pull/40573 Reviewed-By:
-
Rich Trott authored
Remove unnecessary `<sup>` usage and lint-disabling comment. PR-URL: https://github.com/nodejs/node/pull/40475 Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/40592 Fixes: https://github.com/nodejs/node/issues/40578 Reviewed-By:
-
