- Mar 11, 2020
-
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/31809 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
forfun414 authored
change scripts and sources for android build, don't need standalone toolchain after ndk 19, and use clang as default android target compiler. PR-URL: https://github.com/nodejs/node/pull/31521 Reviewed-By:
Christian Clauss <cclauss@me.com>
-
Lucas Holmquist authored
This makes all the parameters of the `fs.read` function, except for `fd` and the callback(when not using as a promise) optional. They will default to sensible defaults. Fixes: https://github.com/nodejs/node/issues/31237 PR-URL: https://github.com/nodejs/node/pull/31402 Reviewed-By:
Robert Nagy <ronagy@icloud.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
-
cjihrig authored
Update ESLint to 7.0.0-alpha.2 PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
-
cjihrig authored
Update ESLint to 7.0.0-alpha.1 PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
-
cjihrig authored
Update ESLint to 7.0.0-alpha.0 PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
-
Anna Henningsen authored
This reverts commit e460f8cf. It is no longer necessary after the previous commit, and restores consistency of the call order between the main thread code, the other call sites, and the documentation. Refs: https://github.com/nodejs/node/pull/31795 PR-URL: https://github.com/nodejs/node/pull/31853 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Anna Henningsen authored
Discard tasks silently that are posted when the Isolate is being disposed. It is not possible to avoid a race condition window between unregistering the Isolate with the platform and disposing it in which background tasks and the Isolate deinit steps themselves may lead to new tasks being posted. The only sensible action in that case is discarding the tasks. Fixes: https://github.com/nodejs/node/issues/31752 Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548 Refs: https://github.com/nodejs/node/pull/31795 Refs: https://github.com/nodejs/node/pull/30909 PR-URL: https://github.com/nodejs/node/pull/31853 Reviewed-By:
-
Matteo Collina authored
Before this patch, pipeline() could swallow errors by pre-emptively producing a ERR_STREAM_PREMATURE_CLOSE that was not really helpful to the user. Co-Authored-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Myles Borins authored
This is only for 10.15 but this test is periodically failing across many CI runs. Would like to mark this as flaky so we can avoid lots of red CI. Refs: https://github.com/nodejs/node/issues/21781 PR-URL: https://github.com/nodejs/node/pull/32189 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
RamanandPatil authored
PR-URL: https://github.com/nodejs/node/pull/32041 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Robert Nagy authored
If the socket is not detached then a future call to res.destroy (through e.g. pipeline) would unecessarily kill the socket while its in the agent free list. PR-URL: https://github.com/nodejs/node/pull/32153 Reviewed-By:
-
Denys Otrishko authored
This issue is unfixable with the current implementations of V8 and Node.js. Changes to make this fixable are unlikely to happen in the foreseeable future. The test itself is flaky and skipped. It serves as a demonstration of the issue only. PR-URL: https://github.com/nodejs/node/pull/31980 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Gerhard Stoebich authored
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: https://github.com/nodejs/node/pull/32061 Refs: https://github.com/nodejs/node/pull/31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Robert Nagy authored
Added .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. PR-URL: https://github.com/nodejs/node/pull/32148 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Matheus Marchini authored
gclient doesn't support Python 3 yet. To workaround that problem, add an enviroment variable to override the Python version used by ./configure. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32140 Reviewed-By:
-
- Mar 10, 2020
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ash Cripps <ashley.cripps@ibm.com> Signed-off-by:
Rod Vagg <rod@vagg.org>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Refs: https://github.com/sindresorhus/macos-term-size/pull/3 Reviewed-By:
-
Rod Vagg authored
Includes hardened-runtime patch from gdams from https://github.com/nodejs/node/issues/29216#issuecomment-546932966 PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By:
-
Sam Roberts authored
Fixes warning on clang 11: In file included from ../../src/node_http2.cc:6: ../../src/node_http2.h:508:15: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage] typedef struct { ^ SessionJSFields ../../src/node_http2.h:512:33: note: type is not C-compatible due to this default member initializer uint32_t max_invalid_frames = 1000; ^~~~ ../../src/node_http2.h:514:3: note: type is given name 'SessionJSFields' for linkage purposes by this typedef declaration } SessionJSFields; ^ PR-URL: https://github.com/nodejs/node/pull/32134 Reviewed-By:Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Rich Trott authored
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By:
-
Rich Trott authored
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By:
-
Rich Trott authored
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By:
-
Rich Trott authored
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By:
-
Rich Trott authored
test-debug-usage fails if run with `--trace-warnings` because the regular expression checking does not allow for the resulting stack trace from the deprecation warning. The test also only tests two parts of the three-part usage message. Improve the test so that it passes with `--trace-warnings` and verifies all three parts of the usage message. Signed-off-by:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Joyee Cheung authored
This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Joyee Cheung authored
Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment. PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Joyee Cheung authored
aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Ruben Bridgewater authored
This reverts commit 7cfbc9f9. PR-URL: https://github.com/nodejs/node/pull/31755 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This reverts commit aa0a01bd. PR-URL: https://github.com/nodejs/node/pull/31755 Reviewed-By:
-
Ruben Bridgewater authored
This reverts commit 4671d551 and contains a fix to the issue raised for the revert. PR-URL: https://github.com/nodejs/node/pull/31755 Reviewed-By:
-
Ruben Bridgewater authored
This reverts commit 5b0308cd. PR-URL: https://github.com/nodejs/node/pull/31755 Reviewed-By:
-
Andrew Neitsch authored
This work is modeled on #30094 which allowed `--disallow-code-generation-from-strings` in `NODE_OPTIONS`. The `--jitless` v8 option has been supported since 12.0.0. As a v8 option, node automatically picks it up, but there have been a few issues that were resolved by simply telling users about the option: #26758, This PR: - allows `--jitless` in `NODE_OPTIONS` - documents `--jitless` - moves `--experimental-loader=module` to locally restore alphabetical order in option documentation Refs: https://github.com/nodejs/node/pull/30094 Refs: https://github.com/nodejs/node/issues/26758 Refs: https://github.com/nodejs/node/issues/28800 PR-URL: https://github.com/nodejs/node/pull/32100 Reviewed-By:Gus Caplan <me@gus.host> Reviewed-By:
-
Matheus Marchini authored
If the subprocess being inspected hard crashes, there will be no information on the log, and the parent process will just wait until timeout. Logging the error signal when it happens can help developers understand failures faster. Signed-off-by:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
Mark all N-APIs that have been added since version 5 as stable. PR-URL: https://github.com/nodejs/node/pull/32058 Fixes: https://github.com/nodejs/abi-stable-node/issues/393 Co-Authored-By:
legendecas <legendecas@gmail.com> Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Stephen Belanger authored
This allows transitioning the entire following sync and async execution sub-tree to the given async storage context. With this one can be sure the context binding will remain for any following sync activity and all descending async execution whereas the `run*(...)` methods must wrap everything that is intended to exist within the context. This is helpful for scenarios such as prepending a `'connection'` event to an http server which binds everything that occurs within each request to the given context. This is helpful for APMs to minimize the need for patching and especially adding closures. PR-URL: https://github.com/nodejs/node/pull/31945 Reviewed-By:
-
- Mar 09, 2020
-
-
Rich Trott authored
* Simplify introductory sentence. * Remove some passive voice. * Make style in bulleted list a little more consistent. * Remove superfluous list entry. PR-URL: https://github.com/nodejs/node/pull/32136 Reviewed-By:
-
