- Jan 21, 2018
-
-
Ben Noordhuis authored
* Get rid of recursive `make` when building the node binary. An earlier commit makes GYP write out rules that we can use for proper dependency tracking. * Use module name 'binding' in addons.md and addons-napi/*/binding.gyp. This massively simplifies the logic for generating the build rules. * Check in auto-generated add-on tests from `doc/api/addons.md`. The files change rarely and generating them dynamically causes no end of race conditions and special-casing during the build. PR-URL: https://github.com/nodejs/node/pull/17407 Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Ben Noordhuis authored
Make the script synchronous and clean it up. This is preparatory work for follow-ups commits. PR-URL: https://github.com/nodejs/node/pull/17407 Reviewed-By:
-
Ben Noordhuis authored
Make GYP write a .deps file in the top-level directory that we can use in the Makefile to get a proper dependency chain for the `node` target. Preparatory work for getting rid of recursive make invocations. PR-URL: https://github.com/nodejs/node/pull/17407 Reviewed-By:
-
Ben Noordhuis authored
Fix a bug where a connection upgrade response with a Transfer-Encoding header and a body whose first byte is > 127 causes said byte to be dropped on the floor when passing the remainder of the message to the 'upgrade' event listeners. Fixes: https://github.com/nodejs/node/issues/17789 PR-URL: https://github.com/nodejs/node/pull/17806 Fixes: https://github.com/nodejs/node/issues/17789 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
- Jan 20, 2018
-
-
Joyee Cheung authored
- Cache `args.Length()` - Use `value.As<T>()` to cast the arguments PR-URL: https://github.com/nodejs/node/pull/18192 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Joyee Cheung authored
Reimplement uv.errname() as internal/util.getSystemErrorName() to avoid the memory leaks caused by unknown error codes and avoid calling into C++ for the error names. Also expose it as a public API for external use. PR-URL: https://github.com/nodejs/node/pull/18186 Refs: http://docs.libuv.org/en/v1.x/errors.html#c.uv_err_name Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Myles Borins authored
Currently npm explicitly doesn't support 10.x and will fail on master. This patch manually adds support for 10.x so that we can keep an up to date version of npm on master. refs: https://github.com/nodejs/node/pull/17535 PR-URL: https://github.com/nodejs/node/pull/17777 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/17777 Reviewed-By:
-
- Jan 19, 2018
-
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18245 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Mars Wong authored
PR-URL: https://github.com/nodejs/node/pull/18057 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/18165 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
James M Snell authored
Verify that server close callbacks are being called PR-URL: https://github.com/nodejs/node/pull/18182 Refs: https://github.com/nodejs/node/issues/18176 Reviewed-By:
-
This is a follow-up of https://github.com/nodejs/node/pull/17914. When Access and Close functions are called in Sync mode, the number of items in args is validated. These are the only two places in this file where this validation doesn't take place. PR-URL: https://github.com/nodejs/node/pull/18203 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/18205 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/18205 Reviewed-By:
-
Anna Henningsen authored
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7e. Fixes: https://github.com/nodejs/node/issues/18189 Refs: https://github.com/nodejs/node/pull/18019 PR-URL: https://github.com/nodejs/node/pull/18214 Fixes: https://github.com/nodejs/node/issues/18189 Refs: https://github.com/nodejs/node/pull/18019 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/18206 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/18226 Reviewed-By:
-
Jon Moss authored
Use common's mustCall (for some reason was implementing its own?), and other small fixes. PR-URL: https://github.com/nodejs/node/pull/18219 Reviewed-By:
-
Sho Miyamoto authored
PR-URL: https://github.com/nodejs/node/pull/18119 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17803 Refs: https://github.com/nodejs/code-and-learn/issues/72 Reviewed-By:
-
James M Snell authored
In further preparation for the Promises enabled fs API, further encapsulate FSReqWrap details. The intent here is to isolate, as much as possible, the functionality of the various fs functions from the details of how the results are notified. The promises implementation will use a `FSReqPromise` alternative to `FSReqWrap` that will use the same API so that both models can be used without changing any of the actual implementation details for the various methods. PR-URL: https://github.com/nodejs/node/pull/18112 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Instead of providing a separate class for keeping the parser alive during its own call back, just delay a possible `.close()` call until the stack has cleared completely. PR-URL: https://github.com/nodejs/node/pull/18135 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
- Jan 13, 2018
-
-
Anna Henningsen authored
Use template helpers instead of `#define`s to generate the raw C callbacks that are passed to the HTTP parser library. A nice effect of this is that it is more obvious what parameters the `Parser` methods take. PR-URL: https://github.com/nodejs/node/pull/18133 Reviewed-By:
-
- Jan 19, 2018
-
-
Sho Miyamoto authored
PR-URL: https://github.com/nodejs/node/pull/18132 Reviewed-By:
-
Anna Henningsen authored
Refactor the read mechanism to completely avoid copying. Instead of copying individual `DATA` frame contents into buffers, create `ArrayBuffer` instances for all socket reads and emit slices of those `ArrayBuffer`s to JS. PR-URL: https://github.com/nodejs/node/pull/18030 Reviewed-By:
-
Anna Henningsen authored
Add a C++ variant of `Buffer.from(arrayBuffer, offset, length)`. PR-URL: https://github.com/nodejs/node/pull/18030 Reviewed-By:
-
Franziska Hinkelmann authored
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: https://github.com/nodejs/node/pull/18155 Reviewed-By:
-
Stephen Belanger authored
Add meta information to async_hooks documentation informing that executionAsyncId was renamed from currentId at Node.js 8.2.0. PR-URL: https://github.com/nodejs/node/pull/17813 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Anatoli Papirovski authored
Refactor Immediates handling to allow for them to be unrefed, similar to setTimeout, but without extra handles. Document the new `immediate.ref()` and `immediate.unref()` methods. Add SetImmediateUnref on the C++ side. PR-URL: https://github.com/nodejs/node/pull/18139 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/17708 Reviewed-By:
-
wandalen authored
This imports a standard test from w3c/web-platform-tests (console-is-a-namespace). PR-URL: https://github.com/nodejs/node/pull/17708 Reviewed-By:
-
Ruben Bridgewater authored
According to the standard the property descriptor of console should be writable and non-enumerable. PR-URL: https://github.com/nodejs/node/pull/17708 Fixes: https://github.com/nodejs/node/issues/11805 Reviewed-By:
-
- Jan 18, 2018
-
-
Michael Dawson authored
This was the only instance were we said a parameter was required. It is assumed parameters are required unless the doc says they are option. Remove `Required` to make consistent with the rest of the doc PR-URL: https://github.com/nodejs/node/pull/18184 Reviewed-By:
-
Suixinlei authored
Fixes: https://github.com/nodejs/node/issues/12516 Refs: https://github.com/nodejs/node/pull/2497 PR-URL: https://github.com/nodejs/node/pull/17705 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Matheus Marchini authored
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: https://github.com/nodejs/node/pull/16735 Refs: https://github.com/nodejs/node/issues/16278 Refs: https://github.com/nodejs/node/issues/14336 Reviewed-By:
-
Anatoli Papirovski authored
This reverts this behaviour introduced in a recent PR, and updates the test. Without this change, CitGM and other packages are broken. PR-URL: https://github.com/nodejs/node/pull/18210 Fixes: https://github.com/nodejs/citgm/issues/536 Reviewed-By:
-
Rich Trott authored
Change `run time` to `runtime` for both correctness and consistency with every other instance of the expression in the docs. PR-URL: https://github.com/nodejs/node/pull/18142 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/18222 Reviewed-By:
-
Rich Trott authored
Change many instances of "x is considered to be y" to "x is y". PR-URL: https://github.com/nodejs/node/pull/18095 Reviewed-By:
-
