- May 09, 2020
-
-
Ben Noordhuis authored
It's also handled in C++ land now, per the previous commit, but intercepting it in JS land makes for prettier error messages. PR-URL: https://github.com/nodejs/node/pull/33045 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Ben Noordhuis authored
`{ windowBits: 8 }` is legal for deflate streams but not gzip streams. Fix a nullptr dereference when formatting the error message. Bug introduced in commit c34eae5f ("zlib: refactor zlib internals") from September 2018. PR-URL: https://github.com/nodejs/node/pull/33045 Reviewed-By: -
Derek Lewis authored
Prior to this commit, there was no GitHub issue template guiding users to open issues about gaps in the API reference docs. Refs: https://github.com/nodejs/node/pull/31123 PR-URL: https://github.com/nodejs/node/pull/32944 Fixes: https://github.com/nodejs/nodejs.org/issues/2866 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Stephen Belanger authored
This avoids the need to wrap every promise in an AsyncWrap and also makes it easier to skip the machinery to track destroy events when there's no destroy listener. Co-authored-by:
Andrey Pechkurov <apechkurov@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32891 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com>
-
Yash Ladha authored
In previous implementation it was clubbed into declaration of scheduling policies and fetching the schedulingPolicy. Now they are separate variables, so that in future if one want to add new scheduling policy. It is much simpler and not obsfucated. PR-URL: https://github.com/nodejs/node/pull/32663 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Anna Henningsen authored
This isn’t conceptually tied to anything Node.js-specific at all. PR-URL: https://github.com/nodejs/node/pull/33272 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Myles Borins authored
We do not support importing named exports from a CJS module. This change decorates the error message for missing named exports in the case where the module being imported is expected to be CJS by the ESM loader. Signed-off-by:
Myles Borins <myles.borins@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33256 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/31818 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/33204 Refs: https://github.com/nodejs/node/issues/25969 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
- May 08, 2020
-
-
cjihrig authored
The WASM memory interfacing logic was wrong (particularly around the size of __wasi_subscription_t). This commit fixes the logic. PR-URL: https://github.com/nodejs/node/pull/33250 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Gabriel Schulhof authored
* Initialize structure members. * Factor out common `Debug()` prefix. * Remove unused `text_region` field. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/33255 Reviewed-By:
-
Jonathan Buhacoff authored
Calling `decipher.setAuthTag` after `decipher.update` will result in an error like `Unsupported state or unable to authenticate data`. The example code in [CCM mode](https://nodejs.org/docs/latest-v14.x/api/crypto.html#crypto_ccm_mode) is correct, but to demonstrate the mistake in the documentation you can take the same example and move the `setAuthTag` call to in between `update` and `final` you will see the error.
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/33100 Reviewed-By:
-
Adam Majer authored
Add capabilities to common test module to detect and skip tests on dumb terminals. In some of our build environments, like s390x, the terminal is a dumb terminal meaning it has very rudimentary capabilities. These in turn prevent some of the tests from completing with errors as below. not ok 1777 parallel/test-readline-tab-complete --- duration_ms: 0.365 severity: fail exitcode: 1 stack: |- assert.js:103 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: '\t' !== '' at /home/abuild/rpmbuild/BUILD/node-git.8698dd98/test/parallel/test-readline-tab-complete.js:63:14 at Array.forEach (<anonymous>) at /home/abuild/rpmbuild/BUILD/node-git.8698dd98/test/parallel/test-readline-tab-complete.js:18:17 at Array.forEach (<anonymous>) at Object.<anonymous> (/home/abuild/rpmbuild/BUILD/node-git.8698dd98/test/parallel/test-readline-tab-complete.js:17:3) at Module._compile (internal/modules/cjs/loader.js:1176:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10) at Module.load (internal/modules/cjs/loader.js:1040:32) at Function.Module._load (internal/modules/cjs/loader.js:929:14) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) { generatedMessage: true, code: 'ERR_ASSERTION', actual: '\t', expected: '', operator: 'strictEqual' } ... PR-URL: https://github.com/nodejs/node/pull/33165 Reviewed-By: -
szTheory authored
PR-URL: https://github.com/nodejs/node/pull/33211 Reviewed-By:
-
osher authored
Ran into #30189, solved by this comment: https://github.com/nodejs/node/issues/30189#issuecomment-548250793 Refs: https://github.com/nodejs/node/issues/30189 PR-URL: https://github.com/nodejs/node/pull/33174 Reviewed-By:
Christian Clauss <cclauss@me.com>
-
Karol Walasek authored
PR-URL: https://github.com/nodejs/node/pull/33179 Reviewed-By:
-
Nikolai Vavilov authored
It returns zero-filled memory since v8.0.0. PR-URL: https://github.com/nodejs/node/pull/33198 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
himself65 authored
This enables loading this module during early bootstrapping. PR-URL: https://github.com/nodejs/node/pull/33212 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Pranshu Srivastava authored
PR-URL: https://github.com/nodejs/node/pull/33217 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/33224 Reviewed-By:
-
Simen Bekkhus authored
PR-URL: https://github.com/nodejs/node/pull/33230 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/33235 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/33248 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Andrey Pechkurov authored
AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: https://github.com/nodejs/node/pull/33249 Reviewed-By:
-
James M Snell authored
Signed-off-by:
Mathias Buus <mathiasbuus@gmail.com> Reviewed-By:
-
- May 07, 2020
-
-
Gabriel Schulhof authored
Adds a test to ensure that napi_get_value_uint32 returns 0xffffffff for -1. Re: https://github.com/nodejs/node/issues/33117 Signed-off-by:
Zeyu Yang <himself65@outlook.com>
-
Robert Nagy authored
Currently from will eagerly buffer up items which means that errors are also eagerly encountered and items which are buffer when an error occurs will be discarded, which is inconsistent with how generators work. Fixes: https://github.com/nodejs/node/issues/29428 PR-URL: https://github.com/nodejs/node/pull/33201 Reviewed-By:
-
Michael Dawson authored
Fixes: https://github.com/nodejs/node/issues/33153 Change documentation to make async_resource required as opposed to optional in napi-async_init. Changes over time mean this parameter is required for proper operation of async hooks (which are still experimental). This changes the documentation to document what callers should do. We are doing this only in the doc in order to avoid a breaking change in N-API. We could create a new version of the method for which the parametrer is enforced as mandatory but we should only do that once async hooks is no longer experimental. In that case we could deprecate (but not remove this version of the method). Signed-off-by:
Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33181 Reviewed-By:
-
James M Snell authored
The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
- May 06, 2020
-
-
James M Snell authored
Allow the AsyncWrap to be properly detached. Extracted from the [QUIC PR](https://github.com/nodejs/node/pull/32379 ). Signed-off-by:
-
Richard Lau authored
This reverts commit e08ac095. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Richard Lau authored
This reverts commit babeb58c. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Joyee Cheung authored
Instead of passing them through the data bound to function templates, store references to them in a list embedded inside the context. This makes the function templates more context-independent, and makes it possible to embed binding data in non-main contexts. Co-authored-by:
-
Michaël Zasso authored
Notable changes: * Track function calls with `assert.CallTracker` (experimental). https://github.com/nodejs/node/pull/31982 * Added a `groupIndentation` option to the `Console` constructor. https://github.com/nodejs/node/pull/32964 PR-URL: https://github.com/nodejs/node/pull/33232
-
Myles Borins authored
If package authors don't explicitly include all previously supported entry points introducing package.exports will be a Semver-Major change. Add a warning about this behavior and offer two potential solutions for module authors. Refs: https://github.com/then/is-promise/issues/20 PR-URL: https://github.com/nodejs/node/pull/33074 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
-
- May 05, 2020
-
-
John Leidegren authored
Fixes: https://github.com/nodejs/node/issues/29394 Refs: https://github.com/nodejs/node/pull/33167#issuecomment-622102450 PR-URL: https://github.com/nodejs/node/pull/33190 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/33194 Reviewed-By:
-
Julian Duque authored
PR-URL: https://github.com/nodejs/node/pull/33185 Reviewed-By:
Adrian Estrada <edsadr@gmail.com> Reviewed-By:
-
- May 04, 2020
-
-
Ruben Bridgewater authored
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by:
-
