- Nov 12, 2020
-
-
Ole André Vadla Ravnås authored
Original commit message: [mac] Set MAP_JIT only when necessary This is a "minimal" change to achieve the required goal: seeing that there is only one place where we need to indicate that memory should be reserved with MAP_JIT, we can add a value to the Permissions enum instead of adding a second, orthogonal parameter. That way we avoid changing public API functions, which makes this CL easier to undo once we have platform-independent w^x in Wasm. Bug: chromium:1117591 Change-Id: I6333d69ab29d5900c689f08dcc892a5f1c1159b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435365 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70379} PR-URL: https://github.com/nodejs/node/pull/35986 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Ole André Vadla Ravnås authored
Original commit message: [platform] Add Permission::kNoAccessWillJitLater enum value This value is unused for now. This CL is part 1 of a 3-step dance. Part 2 will be teaching Chrome's Platform implementation to accept the new value. Part 3 will then actually use it in V8. Bug: chromium:1117591 Change-Id: Ie3aed20d4cc58f3def3be2a3a03bba4c3a37bf44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2450056 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#70335} PR-URL: https://github.com/nodejs/node/pull/35986 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Ole André Vadla Ravnås authored
Original commit message: [wasm][mac] Support w^x codespaces for Apple Silicon Apple's upcoming arm64 devices will prevent rwx access to memory, but in turn provide a new per-thread way to switch between write and execute permissions. This patch puts that system to use for the WebAssembly subsystem. The approach relies on CodeSpaceWriteScope objects for now. That isn't optimal for background threads (which could stay in "write" mode permanently instead of toggling), but its simplicity makes it a good first step. Background: https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon Bug: chromium:1117591 Change-Id: I3b60f0efd34c0fed924dfc71ee2c7805801c5d42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2378307 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#69791} PR-URL: https://github.com/nodejs/node/pull/35986 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
raisinten authored
Fixes: https://github.com/nodejs/node/issues/36045 Co-authored-by:
Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36052 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Remove flaky designation for test-worker-eventlooputil fixed in 9dbde1d4. PR-URL: https://github.com/nodejs/node/pull/35961 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36049 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Rich Trott authored
remark-parse@9.0.0 combined with our html.js tool ends a list if a multi-line item does not include indentation. Update our docs for this formatting. I looked around for a lint rule to enforce this but didn't find one readily available. (Happy to be shown that I'm wrong about that!) We may need to write one. PR-URL: https://github.com/nodejs/node/pull/36049 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36020 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Ole André Vadla Ravnås authored
So that “config.gypi” gets serialized correctly in cases such as: ./configure --v8-options='--write-protect-code-memory \ --wasm-write-protect-code-memory' Where “v8_options” gets prettyprinted into a multiline string. PR-URL: https://github.com/nodejs/node/pull/35982 Reviewed-By:Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
James M Snell authored
Cleaup and improvement of crypto_context and SecureContext. Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35665 Reviewed-By:
Alba Mendez <me@alba.sh> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Dmitry Semigradsky authored
PR-URL: https://github.com/nodejs/node/pull/36085 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
- Nov 11, 2020
-
-
zhangyongsheng authored
PR-URL: https://github.com/nodejs/node/pull/35978 Fixes: https://github.com/nodejs/node/issues/31084 Refs: https://github.com/nodejs/node/pull/26962 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com>
-
Szymon Marczak authored
PR-URL: https://github.com/nodejs/node/pull/35985 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Add missing coverage for setLocalAddress() method of dns.Resolver class. The case where a valid IPv4 argument was supplied along with an invalid IPv6 argument was not being checked. Refs: https://coverage.nodejs.org/coverage-85b42af4398073f8/lib/internal/dns/utils.js.html#L124 PR-URL: https://github.com/nodejs/node/pull/36039 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Stephen Belanger authored
If exit is called and then run or enterWith are called within the exit function, the als instace should not be added to the storageList additional times. The correct behaviour is to remove the instance from the storageList before executing the exit handler and then to restore it after. PR-URL: https://github.com/nodejs/node/pull/35779 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Luigi Pinca authored
Update ESLint to 7.13.0 PR-URL: https://github.com/nodejs/node/pull/36031 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Ethan Arrowood authored
Add WPT AddEventListenerOptions-once test. PR-URL: https://github.com/nodejs/node/pull/34169 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Robert Nagy authored
Don't error if not ended. Fixes: https://github.com/nodejs/node/issues/36029 PR-URL: https://github.com/nodejs/node/pull/36043 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Danielle Adams authored
Notable changes: * events: * getEventListeners static (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/35991) * fs: * support abortsignal in writeFile (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/35993) * add support for AbortSignal in readFile (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/35911) * stream: * fix thrown object reference (Gil Pedersen) (https://github.com/nodejs/node/pull/36065) PR URL: https://github.com/nodejs/node/pull/36055
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/34179 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Luigi Pinca authored
`readable._construct()` and `writable._construct()` were added to Node.js v15.0.0 via fb8cc72e. Fixes: https://github.com/nodejs/node/issues/36058 PR-URL: https://github.com/nodejs/node/pull/36067 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Mattias Runge-Broberg authored
Since there is a setPrompt() there should be a getPrompt(). There are use-cases where it is needed to know what the current prompt is. Adding a getPrompt() negates the need to store the set prompt externally or read the internal _prompt which would be bad practice. Co-authored-by:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33675 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Gil Pedersen authored
PR-URL: https://github.com/nodejs/node/pull/36065 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
- Nov 10, 2020
-
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/35993 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/36034 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Gerhard Stoebich authored
Fix two races in test-performance-eventlooputil resulting in a flaky test. elu1 was capture after start time t from spin look. If OS descides to reschedule the process after capturing t but before getting elu for >=50ms the spin loop is actually a nop. elu1 doesn't show this and as a result elut3 = eventLoopUtilization(elu1) results in elu3.active === 0. Moving capturing of t after capturing t, just before the spin look avoids this. Similar if OS decides to shedule a different process between getting the total elu from start and the diff elu showing the spin loop the check to verify that total active time is long then the spin loop fails. Exchanging these statements avoids this race. PR-URL: https://github.com/nodejs/node/pull/36028 Fixes: https://github.com/nodejs/node/issues/35309 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: https://github.com/nodejs/node/pull/36027 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Richard Lau authored
Search the default installation path for NASM installed by a user without administrator privileges when not found on the Path or in the default system-wide installation path. PR-URL: https://github.com/nodejs/node/pull/36014 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Robert Nagy authored
Don't write to a stream which already has a full buffer. Fixes: https://github.com/nodejs/node/issues/35341 PR-URL: https://github.com/nodejs/node/pull/35348 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36012 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/35679 Fixes: https://github.com/nodejs/node/issues/35629 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du Hamel authored
Make the linter recommend replacing `globalThis.Map` by `primordials.SafeMap`, and similar for `Set`, `WeakSet`, and `WeakMap`. PR-URL: https://github.com/nodejs/node/pull/36026 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Shingo Inoue <leko.noor@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36024 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Baruch Odem (Rothkoff) authored
https://github.com/nodejs/node/pull/35993#discussion_r518703665 PR-URL: https://github.com/nodejs/node/pull/35995 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du Hamel authored
`EventTarget` is exposed on the global scope, there is no need to use `--expose-internals` flag in the tests. Refs: https://github.com/nodejs/node/pull/35496 PR-URL: https://github.com/nodejs/node/pull/36002 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/35999 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/35633 Fixes: https://github.com/nodejs/node/issues/35600 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
dev-script authored
In stream write encoding can be null. Fixes: https://github.com/nodejs/node/issues/33715 PR-URL: https://github.com/nodejs/node/pull/35372 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
masx200 authored
PR-URL: https://github.com/nodejs/node/pull/35197 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Denys Otrishko authored
Refs: https://github.com/nodejs/node/pull/34944#discussion_r480321239 Co-authored-by:
Anna Henningsen <anna@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/35000 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-