Commits · d005f382cdcec7dff1d61cf5ab3604e55f004471 · github.com / v8-riscv / node

Apr 04, 2019

process: store argv in Environment · d005f382

Joyee Cheung authored Mar 20, 2019

This gets rid of Environment::ExecutionMode as well now that
we use the original arguments to determine execution mode.

PR-URL: https://github.com/nodejs/node/pull/26945


Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

d005f382

doc: fix section sorting, add link reference · 10eaf6a0

Vse Mozhet Byt authored Apr 03, 2019

PR-URL: https://github.com/nodejs/node/pull/27075


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

10eaf6a0

2019-04-03, Version 6.17.1 'Boron' (LTS) · 883a0d52

Beth Griggs authored Mar 15, 2019

Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](https://github.com/nodejs/node/pull/25939)

PR-URL: https://github.com/nodejs/node/pull/26684

883a0d52

esm: fix typos · 5e98f875

Geoffrey Booth authored Apr 03, 2019

PR-URL: https://github.com/nodejs/node/pull/27067


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

5e98f875

src: apply clang-tidy rule bugprone-incorrect-roundings · d711b97a

gengjiawen authored Mar 24, 2019

PR-URL: https://github.com/nodejs/node/pull/26885


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

d711b97a

Apr 03, 2019

deps: update nghttp2 to 1.37.0 · 5c2ee4ee

gengjiawen authored Mar 30, 2019

PR-URL: https://github.com/nodejs/node/pull/26990


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

5c2ee4ee

test: make module test pass with NODE_PENDING_DEPRECATION · 198d7a47

Anna Henningsen authored Mar 30, 2019

Some people set the `NODE_PENDING_DEPRECATION` environment variable
globally. This makes the test added in 115f0f5a
pass when that is the case.

Refs: https://github.com/nodejs/node/pull/26823

PR-URL: https://github.com/nodejs/node/pull/27019


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

198d7a47

lib: force using primordials for JSON, Math and Reflect · 0817840f

Michaël Zasso authored Mar 31, 2019

Use the "no-restricted-globals" ESLint rule to lint for it.

PR-URL: https://github.com/nodejs/node/pull/27027


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

0817840f

module: fix repl require calling the same file again · 8a6dcd04

Ruben Bridgewater authored Mar 26, 2019

This makes sure multiple require calls will not fail in case a file
was created after the first attempt.

PR-URL: https://github.com/nodejs/node/pull/26928
Fixes: https://github.com/nodejs/node/issues/26926


Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>

8a6dcd04

src: check return value, silence coverity warning · 1087805e

Ben Noordhuis authored Mar 29, 2019

PR-URL: https://github.com/nodejs/node/pull/26997


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

1087805e

readline: make Symbol.asyncIterator support stable · 4de5e0a9

Matteo Collina authored Apr 01, 2019

PR-URL: https://github.com/nodejs/node/pull/26989


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

4de5e0a9

stream: make Symbol.asyncIterator support stable · 1d8298a5

Matteo Collina authored Mar 29, 2019

PR-URL: https://github.com/nodejs/node/pull/26989


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1d8298a5

deps: V8: cherry-pick 0188634 · 5b8434ee

Michaël Zasso authored Mar 30, 2019

Original commit message:

    [ptr-compr][ubsan] Use [Read/Write]UnalignedValue for unaligned fields

    When pointer compression is enabled the [u]intptr_t and double fields are
    only kTaggedSize aligned so in order to avoid undefined behavior in C++ code
    we have to access these values in an unaligned pointer friendly way although
    both x64 and arm64 architectures (where pointer compression is supported)
    allow unaligned access.

    These changes will be removed once v8:8875 is fixed and all the
    kSystemPointerSize fields are properly aligned.

    Bug: v8:7703
    Change-Id: I4df477cbdeab806303bb4f675d52b61c06342c8e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528996


    Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60321}

Refs: https://github.com/v8/v8/commit/0188634ee523aef39ba71732b1ab9d422f449825

PR-URL: https://github.com/nodejs/node/pull/27013


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

5b8434ee

deps: V8: cherry-pick c8785d1 · 8cc181c8

Michaël Zasso authored Mar 30, 2019

Original commit message:

    [heap, api] Advance deprecations around global handles

    Bug: chromium:923361, v8:8834
    Change-Id: I46b6ad9eaa86476963a4e2cb3a5712447f180c20
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528235


    Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60303}

Refs: https://github.com/v8/v8/commit/c8785d1572b8b7d7dc4df3578e249312a30be4b9

PR-URL: https://github.com/nodejs/node/pull/27013


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

8cc181c8

deps: V8: cherry-pick f4b860d · 2ea9de2e

Michaël Zasso authored Mar 30, 2019

Original commit message:

    [heap,api] Remove deprecated APIs

    Bug: chromium:923361, v8:8834
    Change-Id: I6ec42aeb74bea5c0629fcdc3f95c125f5de534a0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526195


    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60289}

Refs: https://github.com/v8/v8/commit/f4b860d9b81956fb9d6815932522f4043fef56fa

PR-URL: https://github.com/nodejs/node/pull/27013


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

2ea9de2e

doc: document the 'pause' and 'resume' events · 98b5ba84

Luigi Pinca authored Mar 29, 2019

PR-URL: https://github.com/nodejs/node/pull/26999


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

98b5ba84

dgram: add support for UDP connected sockets · 9e960175

Santiago Gimeno authored Mar 16, 2019

Added the `dgram.connect()` and `dgram.disconnect()` methods that
associate/disassociate a udp socket to/from a remote address.
It optimizes for cases where lots of packets are sent to the same
address.
Also added the `dgram.remoteAddress()` method to retrieve the associated
remote address.

PR-URL: https://github.com/nodejs/node/pull/26871


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

9e960175

doc: remove unnecessary intro in governance doc · 38f0e382

Rich Trott authored Mar 31, 2019

The introductory paragraph in GOVERNANCE.md does not add anything that
isn't obvious from the document itself. Remove it.

PR-URL: https://github.com/nodejs/node/pull/27036


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

38f0e382

report: add cwd to report · d5a5b99e

cjihrig authored Mar 30, 2019

The diagnostic report currently contains command line
information, and the environment, which contains the PWD
environment variable. This combination covers the majority
of cases, but it would be useful to have the result of
uv_cwd() as an additional data point. This commit adds that
information.

PR-URL: https://github.com/nodejs/node/pull/27022


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

d5a5b99e

process: run RunBootstrapping in CreateEnvironment · 19442656

Joyee Cheung authored Mar 20, 2019

Also creates `CreateMainEnvironment` to encapsulate the code
creating the main environment from the provided Isolate data
and arguments.

PR-URL: https://github.com/nodejs/node/pull/26788


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

19442656

doc: remove old system_errors · e02f511d

Minwoo Jung authored Mar 29, 2019

Remove old errors_system_errors, any useful information
in it moved into the SystemError class docs.

Fixes: https://github.com/nodejs/node/issues/26861
PR-URL: https://github.com/nodejs/node/pull/27037


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

e02f511d

path: refactor for less indentation · dd0d6df9

Ruben Bridgewater authored Mar 26, 2019

This just switches the statements in a way that it reduces the
overall indentation. The function has a very deep indentation in
general and this should improve the readability.

PR-URL: https://github.com/nodejs/node/pull/26917


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

dd0d6df9

util: improve error property inspection · f7c96856

Ruben Bridgewater authored Mar 29, 2019

This makes sure that errors that contain extra properties show those
properties on a separate line.

PR-URL: https://github.com/nodejs/node/pull/26984


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

f7c96856

util: improve `inspect()` compact number mode · 14b2db01

Ruben Bridgewater authored Mar 29, 2019

This fixes a proportion calculation for lots of short array entries
with at least one bigger one that alone makes up for more than one
fifth of all other entries together.

PR-URL: https://github.com/nodejs/node/pull/26984


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

14b2db01

module: mark DEP0019 as End-of-Life · 75007d64

Ruben Bridgewater authored Mar 29, 2019

In certain cases, `require('.')` could resolve outside the package
directory. This behavior has been removed.

PR-URL: https://github.com/nodejs/node/pull/26973
Refs: https://github.com/nodejs/node/pull/3384


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

75007d64

test: simplify date inspection tests · 666c67e0

Ruben Bridgewater authored Mar 26, 2019

The code duplicated a lot of logic that was already abstracted. Use
the abstraction instead to remove code overhead.

PR-URL: https://github.com/nodejs/node/pull/26922


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

666c67e0

util: `inspect()` should not exceed `breakLength` · e1e9f1e9

Ruben Bridgewater authored Mar 26, 2019

Using `util.inspect()` with the `compact` option set to a number
could result in output that exceeded the `breakLength` option. This
change makes sure that limit is taken into account.

PR-URL: https://github.com/nodejs/node/pull/26914


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

e1e9f1e9

doc: unify link formatting in buffer.md · 7aa7971e

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

7aa7971e

doc: unify periods in comments in buffer.md · 35d83d51

Vse Mozhet Byt authored Mar 30, 2019

"Prints: ..." comments were excepted to avoid confusion.

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

35d83d51

doc: add notes about negative offsets in buffer.md · 2de67343

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

2de67343

doc: mark optional parameters in buffer.md · 82a95fed

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

82a95fed

doc: add note about Buffer octets integer coercion · 0e803d1d

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

0e803d1d

doc: fix error notes in `Buffer.from()` variants · e4c6c3bf

Vse Mozhet Byt authored Mar 30, 2019

Make notes about `TypeError` conditions in `Buffer.from()` variants
more accurate.

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

e4c6c3bf

doc: unify number/integer types in buffer.md · 2f338f3f

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

2f338f3f

doc: add missing types in buffer.md · 3c11f64e

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

3c11f64e

doc: fix possible typo in buffer.md · f89568e8

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

f89568e8

doc: remove description duplication in buffer.md · 1dd9662e

Vse Mozhet Byt authored Mar 30, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1dd9662e

src: replace c-style cast · 4d273945

gengjiawen authored Mar 24, 2019

PR-URL: https://github.com/nodejs/node/pull/26888


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

4d273945

Apr 02, 2019

test: remove test-trace-events-api-worker-disabled from flaky · da79d30c

Rich Trott authored Mar 30, 2019

PR-URL: https://github.com/nodejs/node/pull/27020


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

da79d30c

tools: fix `test.py --time` · 8bfce899

Richard Lau authored Mar 30, 2019

PR-URL: https://github.com/nodejs/node/pull/27007


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8bfce899