- Oct 16, 2020
-
-
Michaël Zasso authored
The other way is deprecated. PR-URL: https://github.com/nodejs/node/pull/35638 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michaël Zasso authored
It is already installed in the GitHub runners. PR-URL: https://github.com/nodejs/node/pull/35638 Reviewed-By:
-
Daijiro Wachi authored
Refs: https://github.com/web-platform-tests/wpt/pull/25987 PR-URL: https://github.com/nodejs/node/pull/35636 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Myles Borins authored
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) https://github.com/nodejs/node/pull/35546 doc: * add aduh95 to collaborators (Antoine du Hamel) https://github.com/nodejs/node/pull/35542 fs: * (SEMVER-MINOR) add rm method (Ian Sutherland) https://github.com/nodejs/node/pull/35494 http: * (SEMVER-MINOR) allow passing array of key/val into writeHead (Robert Nagy) https://github.com/nodejs/node/pull/35274 src: * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) https://github.com/nodejs/node/pull/35512 PR-URL: https://github.com/nodejs/node/pull/35648
-
Robert Nagy authored
Fixes some compatibility issues where it is expected that for await stops reading when the stream is destroyed. Refs: https://github.com/nodejs/node/pull/34887 PR-URL: https://github.com/nodejs/node/pull/35640 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
James M Snell authored
SSLWrap was needlessly defined as a template class, splitting the TLS implementation over multiple locations. The original idea, I surmise, was to make it possible to reuse SSLWrap for some other purpose that never manifest. This squashes them down into a single TLSWrap class and moves tls_wrap.h/cc into src/crypto. Signed-off-by:
Alba Mendez <me@alba.sh>
-
- Oct 15, 2020
-
-
James M Snell authored
Running tests comparitively on older versions of Node.js that do not have AbortController can be a pain. Only add the AbortController to knownGlobals if it actually exists. Signed-off-by:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35625 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/35613 Reviewed-By:
-
Gireesh Punathil authored
This api does not alter the behavior of diagnostic report configured on uncaught exceptions. This is deemed as a bug. Honor this API. Refs: https://github.com/nodejs/node/pull/35588 PR-URL: https://github.com/nodejs/node/pull/35595 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Hussaina Begum Nandyala authored
Signed-off-by:
Hussaina Begum Nandyala <hexxdump@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35618 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Ian Sutherland authored
This is a follow up to #35494 to add a deprecation warning when using recursive rmdir. This only warns if you are attempting to remove a file or a nonexistent path. PR-URL: https://github.com/nodejs/node/pull/35562 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35634 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org>
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/35559 PR-URL: https://github.com/nodejs/node/pull/35612 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Anna Henningsen authored
Original commit message: [heap-profiler] Fix crash when a snapshot deleted while taking one Fix a crash/hang that occurred when deleting a snapshot during the GC that is part of taking another one. Specifically, when deleting the only other snapshot in such a situation, the `v8::HeapSnapshot::Delete()` method sees that there is only one (complete) snapshot at that point, and decides that it is okay to perform “delete all snapshots” instead of just deleting the requested one. That resets the internal string lookup table of the heap profiler, but the new snapshot that is currently in progress still holds references to the old string lookup table, leading to a use-after-free segfault or infinite loop. Fix this by guarding against resetting the string table while another heap snapshot is being taken, and add a test that would crash before this fix. This can be triggered in Node.js by repeatedly calling `v8.getHeapSnapshot()`, which provides heap snapshots as weakly held host objects. Change-Id: If9ac3728bf79114000982f1e7bb05e8034299e3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464823 Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#70445} Refs: https://github.com/v8/v8/commit/3176bfd447a909fa9608687fe3eabcf62ec7b2eb PR-URL: https://github.com/nodejs/node/pull/35612 Refs: https://github.com/nodejs/node/issues/35559 Reviewed-By:
-
Anna Henningsen authored
Provide helpers for a) spinning the event loop and b) setting up and tearing down the objects involved in a single Node.js instance, as they would typically be used. The former helper is also usable inside Node.js itself, for both Worker and main threads. PR-URL: https://github.com/nodejs/node/pull/35597 Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/35541 Refs: https://github.com/nodejs/node/pull/32703 Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com>
-
- Oct 14, 2020
-
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/35631 Reviewed-By:
Ruy Adorno <ruyadorno@github.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/35631 Reviewed-By:
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/node/pull/35206 PR-URL: https://github.com/nodejs/node/pull/35599 Reviewed-By:
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35611 Reviewed-By:
-
Rod Vagg authored
Ref: https://github.com/nodejs/node-gyp/issues/2233 Ref: https://github.com/nodejs/gyp-next/pull/69 PR-URL: https://github.com/nodejs/node/pull/35635 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Ujjwal Sharma authored
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 PR-URL: https://github.com/nodejs/node/pull/35635 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/35551 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/35566 Reviewed-By:
-
Tobias Nießen authored
"GB" refers to 10**9 bytes, whereas the actual limit is 2**30. The correct unit symbol is "GiB". PR-URL: https://github.com/nodejs/node/pull/35051 Reviewed-By:
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/35630 Reviewed-By:
-
James M Snell authored
Appears to be flaky only on rhe17-390x. Will be investigating refs: https://github.com/nodejs/node/issues/35586 PR-URL: https://github.com/nodejs/node/pull/35587 Refs: https://github.com/nodejs/node/issues/35586 Reviewed-By:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Simple method for retrieving basic information about a cipher (such as block length, expected or default iv length, key length, etc) Signed-off-by:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Oct 13, 2020
-
-
cjihrig authored
This commit updates validateRmOptions() to throw on input validation failures. This is consistent with how Node handles validation in most places across the codebase. PR-URL: https://github.com/nodejs/node/pull/35602 Reviewed-By:
-
Daniil Demidovich authored
PR-URL: https://github.com/nodejs/node/pull/35292 Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/35622 Fixes: https://github.com/nodejs/node/issues/35621 Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/35622 Fixes: https://github.com/nodejs/node/issues/35621 Reviewed-By:
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139 PR-URL: https://github.com/nodejs/node/pull/35575 Reviewed-By:
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35589 Reviewed-By:
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35590 Reviewed-By:
-
Shelley Vohr authored
This is the certdata.txt[0] from NSS 3.56, released on 2020-08-21. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_56_RTM/lib/ckfw/builtins/certdata.txt crypto: update root certificates Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: - Microsoft ECC Root Certificate Authority 2017 - Microsoft RSA Root Certificate Authority 2017 - e-Szigno Root CA 2017 - certSIGN Root CA G2 Certificates removed: - Verisign Class 3 Public Primary Certification Authority - G3 - AddTrust External Root - Staat der Nederlanden Root CA - G2 - LuxTrust Global Root 2 PR-URL: https://github.com/nodejs/node/pull/35546 Reviewed-By:
-
Dmitry Gozman authored
Debugger.CallFrameId is defined as an opaque string [1]. Some tests currently hardcode the value, relying on undocumented internal details of V8. This makes it hard for V8 to change the internal representation. We should instead use the reported call frame id from the Debugger.paused event directly. This is how every inspector client does it. [1] https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#type-CallFrameId PR-URL: https://github.com/nodejs/node/pull/35570 Reviewed-By:
Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By:
-
