- Apr 19, 2018
-
-
Daven Casia authored
PR-URL: https://github.com/nodejs/node/pull/20021 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Rich Trott authored
Per conversation with Mikeal, moving to Collaborator Emeriti list. Mikeal will remain active in Evangelism so you'll still see him around the org. PR-URL: https://github.com/nodejs/node/pull/20113 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
Minor re-wording of three sentences to make them slightly more natural. Ending sentences with prepositions is fine in many cases, but these three cases are a bit awkward. PR-URL: https://github.com/nodejs/node/pull/20037 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Peter Marshall authored
PR-URL: https://github.com/nodejs/node/pull/19999 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
- Apr 18, 2018
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20111 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Myles Borins authored
This was missed in a previous PR PR-URL: https://github.com/nodejs/node/pull/20105 Refs: https://github.com/nodejs/node/pull/20016 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
James M Snell authored
Removes the requirement to use `--trace-events-enabled` to enable trace events. Tracing is enabled automatically if there are any enabled categories. Adds a new `trace_events` module with an API for enabling/disabling trace events at runtime without a command line flag. ```js const trace_events = require('trace_events'); const categories = [ 'node.perf', 'node.async_hooks' ]; const tracing = trace_events.createTracing({ categories }); tracing.enable(); // do stuff tracing.disable(); ``` Multiple `Tracing` objects may exist and be enabled at any point in time. The enabled trace event categories is the union of all enabled `Tracing` objects and the `--trace-event-categories` flag. PR-URL: https://github.com/nodejs/node/pull/19803 Reviewed-By:Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Anatoli Papirovski authored
The current check for socket.server[kIncomingMessage] does not account for the possibility of a socket.server that doesn't have that property defined. Fix it. PR-URL: https://github.com/nodejs/node/pull/20029 Fixes: https://github.com/nodejs/node/issues/19231 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Anatoli Papirovski authored
When an interval callback throws an error, the destroy hook is never called due to a faulty if condition. PR-URL: https://github.com/nodejs/node/pull/20001 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Anatoli Papirovski authored
A bug was introduced in #17704 which meant that subsequent calls to enroll would unset the new _idleTimeout and the enrolled object could never again function as a timer. PR-URL: https://github.com/nodejs/node/pull/19936 Reviewed-By:
-
davidmarkclements authored
Changes the base instance for ERR_INVALID_CURSOR_POS from Error to TypeError as a more accurate representation of the error. PR-URL: https://github.com/nodejs/node/pull/19960 Reviewed-By:
-
Anatoli Papirovski authored
A whole part of the test-http-agent-destroyed-socket test was not running as the semantics of http events changed slightly and were no longer triggering the expected event. Instead listen to the same event on the socket to verify that the code being tested is still working as expected. PR-URL: https://github.com/nodejs/node/pull/20006 Fixes: https://github.com/nodejs/node/issues/8613 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20087 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20086 Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com>
-
- Apr 17, 2018
-
-
Anna Henningsen authored
This reverts commit b994b8ef. This caused regressions in ecosystem code. While the change originally was semver-major and could be postponed until after Node.js 10, I think reverting it is a good choice at this point. Also, I personally do not think defaulting to a shallow inspect is a bad thing at all – quite the opposite: It makes `util.inspect()` give an overview of an object, rather than providing a full display of its contents. Changing the `depth` default to infinity fundamentally changed the role that `util.inspect()` plays, and makes output much more verbose and thus at times unusable for `console.log()`-style debugging. Fixes: https://github.com/nodejs/node/issues/19405 Refs: https://github.com/nodejs/node/pull/17907 PR-URL: https://github.com/nodejs/node/pull/20089 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This reverts commit 8f153092. PR-URL: https://github.com/nodejs/node/pull/20089 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/19995 Refs: https://github.com/v8/v8/compare/6.6.346.23...6.6.346.24 Reviewed-By:
-
Ujjwal Sharma authored
PR-URL: https://github.com/nodejs/node/pull/20081 Reviewed-By:
-
James M Snell authored
Rather than an option, introduce a method and an event... ```js server.on('stream', (stream) => { stream.respond(undefined, { waitForTrailers: true }); stream.on('wantTrailers', () => { stream.sendTrailers({ abc: 'xyz'}); }); stream.end('hello world'); }); ``` This is a breaking change in the API such that the prior `options.getTrailers` is no longer supported at all. Ordinarily this would be semver-major and require a deprecation but the http2 stuff is still experimental. PR-URL: https://github.com/nodejs/node/pull/19959 Reviewed-By: -
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20078 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20071 Reviewed-By:
-
Ruben Bridgewater authored
In case an object contained a circular reference `Object.keys` was called even though it was not necessary at all. This caused a significant overhead for objects that contained a lot of such entries. PR-URL: https://github.com/nodejs/node/pull/20007 Reviewed-By:
-
davidmarkclements authored
Changes the base instance for ERR_INVALID_PROTOCOL from Error to TypeError as a more accurate representation of the error. PR-URL: https://github.com/nodejs/node/pull/19983 Reviewed-By:
-
Mathias Buus authored
PR-URL: https://github.com/nodejs/node/pull/19828 Reviewed-By:
-
Alec Larson authored
PR-URL: https://github.com/nodejs/node/pull/19900 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20050 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20047 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20046 Reviewed-By:
-
Anatoli Papirovski authored
The http spec does not say anything about Upgrade headers making protocol switch mandatory but Node.js implements them as if they are. Relax the requirements to only destroy the socket if no upgrade listener exists on the client when status code is 101. PR-URL: https://github.com/nodejs/node/pull/19981 Fixes: https://github.com/nodejs/node/issues/11552 Refs: https://tools.ietf.org/html/rfc7230#section-6.7 Reviewed-By:
-
James M Snell authored
Indicate that `base` is ignored if `input` is absolute. PR-URL: https://github.com/nodejs/node/pull/19899 Reviewed-By:
-
davidmarkclements authored
Changes the base instance for ERR_INVALID_DOMAIN_NAME from Error to TypeError as a more accurate representation of the error. PR-URL: https://github.com/nodejs/node/pull/19961 Reviewed-By:
-
Rémi Berson authored
According to HTML Living Standard, "either method [clearInterval or clearTimeout] can be used to clear timers created by setTimeout() or setInterval().". The current implementation of clearTimeout is already able to destroy a timer created by setInterval, but not the other way around. PR-URL: https://github.com/nodejs/node/pull/19952 Refs: https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#dom-setinterval Reviewed-By:
-
Rod Vagg authored
Was 72c5458a: PR-URL: https://github.com/nodejs/node/pull/5090 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reimplemented for c-ares 1.13.0 PR-URL: https://github.com/nodejs/node/pull/15378 Reviewed-By:
-
Rod Vagg authored
c-ares switched to using ares_ssize_t for platform-independent ssize_t, our GYP usage to include config/<platform>/ares_config.h causes problems when including gyp as a library in core, i.e. in env.h and cares_wrap.h, where the defines don't get pulled in properly. This, so far, is the easiest approach to just making it work nicely--explicitly defining ares_ssize_t for the different Windows variants and ssize_t for non-Windows where we don't have a configured type from an ares_config.h. In all of our non-Windows platforms it is ssize_t anyway so this is safe. PR-URL: https://github.com/nodejs/node/pull/15378 Reviewed-By:
-
Rod Vagg authored
* Fix patch for CVE-2017-1000381 to not be overly aggressive. * win32: Preserve DNS server order returned by Windows when sorting and exclude DNS servers in legacy subnets. * win32: Support most recent Visual Studio 2017. * gethostbyaddr should fail with ECANCELLED not ENOTFOUND when ares_cancel is called. * win32: Exclude legacy ipv6 subnets. * android: Applications compiled for Oreo can no longer use __system_property_get and must use Java calls to retrieve DNS servers. * win32: Force use of ANSI functions. * CMake minimum version is now 3.1. * ares_gethostbyname.3: fix callback status values. * docs: Document WSAStartup requirement. * Fix a typo in init_by_resolv_conf. * Android JNI code leaks local references in some cases. * Force using the ANSI versions of WinAPI functions. The most important changes have already been included via * 50e580df deps: cherry-pick 0ef4a0c64b6 from c-ares upstream * 9a0631df deps: cherry-pick 18ea996 from c-ares upstream PR-URL: https://github.com/nodejs/node/pull/19939 Reviewed-By:
-
Beth Griggs authored
PR-URL: https://github.com/nodejs/node/pull/19378 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This adds a example to `assert.throws` to document checking against error instances. It also makes it clearer what some arguments can receive as input. PR-URL: https://github.com/nodejs/node/pull/19885 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure `assert.rejects` is always called with a second argument. Besides that it is also changes a eslint error message to suggest objects instead of a regular expression. PR-URL: https://github.com/nodejs/node/pull/19885 Reviewed-By:
-
Ruben Bridgewater authored
This adds direct promise support to `assert.rejects` and `assert.doesNotReject`. It will now accept both, functions and ES2015 promises as input. Besides this the documentation was updated to reflect the latest changes. It also refactors the tests to a non blocking way to improve the execution performance and improves the coverage. PR-URL: https://github.com/nodejs/node/pull/19885 Reviewed-By:
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/19643 Reviewed-By:
-
