- Jan 18, 2018
-
-
Rich Trott authored
Change many instances of "x is considered to be y" to "x is y". PR-URL: https://github.com/nodejs/node/pull/18095 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Steven R. Loomis authored
- Update to Maintainance ICU 60.2 - CLDR 32.0.1 - http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes - Subsumes https://github.com/nodejs/node/pull/16931 PR-URL: https://github.com/nodejs/node/pull/17687 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
Replace some repeated full links with concise ones and bottom references. PR-URL: https://github.com/nodejs/node/pull/18213 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
陈刚 authored
Fixes: https://github.com/nodejs/node/issues/18116 PR-URL: https://github.com/nodejs/node/pull/18121 Reviewed-By:
Weijia Wang <starkwang@126.com>
-
Michael Dawson authored
Update so that it includes some of the more recent additions. PR-URL: https://github.com/nodejs/node/pull/18167 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Yosuke Furukawa authored
PR-URL: https://github.com/nodejs/node/pull/18201 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
sreepurnajasti authored
Refs: #13836 PR-URL: https://github.com/nodejs/node/pull/18034 Refs: https://github.com/nodejs/node/issues/13836 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/18161 Fixes: https://github.com/nodejs/node/issues/18160 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
- Jan 17, 2018
-
-
cjihrig authored
This commit reorders the function level changelogs of Buffer.prototype.fill() and Buffer.alloc() to reflect the order in which the entries were added. PR-URL: https://github.com/nodejs/node/pull/18129 Fixes: https://github.com/nodejs/node/issues/18128 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
cjihrig authored
Prior to this commit, Node would enter an infinite loop when attempting to fill a non-zero length buffer with a zero length buffer. This commit introduces a thrown exception in this scenario. PR-URL: https://github.com/nodejs/node/pull/18129 Fixes: https://github.com/nodejs/node/issues/18128 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/18105 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/18103 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
laino authored
Relative unix sockets paths were previously interpreted relative to the master's CWD, which was inconsistent with non-cluster behavior. A test case has been added as well. PR-URL: https://github.com/nodejs/node/pull/16749 Fixes: https://github.com/nodejs/node/issues/16387 Reviewed-By:
-
Yihong Wang authored
Refine the static and shared lib build process in order to integrate static and shared lib verfication into CI. When building both static and shared lib, we still build node executable now and it uses the shared and static lib. Signed-off-by:
Yihong Wang <yh.wang@ibm.com> Fixes: https://github.com/nodejs/node/issues/14158 PR-URL: https://github.com/nodejs/node/pull/17604 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Kyle Farnung authored
* Added a `lint-cpp` argument * Updated `findstr` calls to output to `nul` * Updated `findstr` calls to only use `/r` when the input is a regex PR-URL: https://github.com/nodejs/node/pull/18012 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/18097 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Moritz Peters authored
PR-URL: https://github.com/nodejs/node/pull/18166 Reviewed-By:
-
furstenheim authored
PR-URL: https://github.com/nodejs/node/pull/18148 Reviewed-By:
-
Roman Reiss authored
PR-URL: https://github.com/nodejs/node/pull/18151 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/17914 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/17914 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/17914 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/17914 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/17914 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/17914 Reviewed-By:
-
Jinho Bang authored
According to the ECMA spec, we should throw a RangeError in the following cases: - `(length * elementSize) + offset` > the size of the array passed in - `offset % elementSize` != `0` In the current implementation, this check was omitted. So, the following code will cause a crash. ``` napi_create_typedarray(env, napi_uint16_array, 2 /* length */, buffer, 1 /* byte_offset */, &output_array); ``` This change fixes the problem and write some related tests. Refs: https://tc39.github.io/ecma262/#sec-typedarray-buffer-byteoffset-length PR-URL: https://github.com/nodejs/node/pull/18037 Reviewed-By: -
Ruben Bridgewater authored
This is the only double line break in the file and for consistency one is removed. PR-URL: https://github.com/nodejs/node/pull/17581 Reviewed-By:
Ron Korving <ron@ronkorving.nl>
-
Ruben Bridgewater authored
`assert.ok()` should always receive a value. Otherwise there might be a bug or it was intended to use `assert.fail()`. PR-URL: https://github.com/nodejs/node/pull/17581 Reviewed-By:
-
Ruben Bridgewater authored
This improves the error message in simple asserts by using the real call information instead of the already evaluated part. PR-URL: https://github.com/nodejs/node/pull/17581 Reviewed-By:
-
Joyee Cheung authored
Also provide an example on how to use internal/errors to handle errors in C++. PR-URL: https://github.com/nodejs/node/pull/18149 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Joyee Cheung authored
This patch migrates all the `ASYNC_CALL` macro in `node_file.cc` to the template counterpart AsyncCall. Also goes with a different style of wrapping the arguments so it's clearer to see what arguments are passed to which `uv_fs_*` functions. PR-URL: https://github.com/nodejs/node/pull/18144 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18150 Fixes: https://github.com/nodejs/node/issues/17053 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Joyee Cheung authored
* Throw ERR_TLS_SNI_FROM_SERVER when setting server names on a server-side socket instead of returning silently * Assert on wrap_->started and wrap_->ssl instead of throwing errors since these errors indicate that the user either uses private APIs, or monkey-patches internals, or hits a bug. PR-URL: https://github.com/nodejs/node/pull/18125 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
-
Joyee Cheung authored
* Throw ERR_INVALID_ARG_TYPE from public APIs * Assert argument types in bindings instead of throwing errors PR-URL: https://github.com/nodejs/node/pull/18125 Reviewed-By:
-
Ali Ijaz Sheikh authored
Some of the API section headers had emphasis, while others did not. Use a consistent style (no emphasis) for all of them, as that matches our other API docs. PR-URL: https://github.com/nodejs/node/pull/18122 Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com> Reviewed-By:
-
Ali Ijaz Sheikh authored
Some of the section headers had unbalanced emphasis. PR-URL: https://github.com/nodejs/node/pull/18122 Reviewed-By:
-
- Jan 16, 2018
-
-
Michael Dawson authored
In https://github.com/nodejs/node/pull/17987 which updated the location of the code coverage patches I missed a few changes needed to properly clean up for code coverage. Add these. PR-URL: https://github.com/nodejs/node/pull/18081 Reviewed-By:
-
Ruben Bridgewater authored
Since the default for depth is changed to `Infinity` it is logical to change the %o default to the same as well. Using %o with `util.format` will now always print the whole object. PR-URL: https://github.com/nodejs/node/pull/17907 Refs: https://github.com/nodejs/node/issues/12693 Reviewed-By:
-
Ruben Bridgewater authored
The current default is not ideal in most use cases. Therefore it is changed to showing unlimited depth in case util.inspect is called directly. The default is kept as before for console.log and similar. Using console.dir will now show a depth of up to five and console.assert / console.trace will show a unlimited depth. PR-URL: https://github.com/nodejs/node/pull/17907 Refs: https://github.com/nodejs/node/issues/12693 Reviewed-By:
-
Ruben Bridgewater authored
Currently inspecting the BufferList can result a maximum call stack size error. Adding a individual inspect function prevents this. PR-URL: https://github.com/nodejs/node/pull/17907 Refs: https://github.com/nodejs/node/issues/12693 Reviewed-By:
-
